From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4C2FB21ED1C7A for ; Wed, 7 Mar 2018 07:56:18 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id u5so4000772itc.1 for ; Wed, 07 Mar 2018 08:02:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=+tOAVpeV2Jk5oBbLfFc7dPaxrq4CcPhTkTaGCPQB2mE=; b=WkNWhhdxJg7CEa+yMMpHTW1PdVTETCm2Jkq4ZIm7BpcKUwN2KLANn8cpU4df6WnS6y 9LIAfZrxK8U8AAGgofUD+RUxIrv07vtOPgIMH1gyuhg9Ii7a7bfn4kTvllMuL2oAGYAV MKQ0gEwAbCG0eY7Z55FLqP2sChq1OyzPFFO/c= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=+tOAVpeV2Jk5oBbLfFc7dPaxrq4CcPhTkTaGCPQB2mE=; b=Z3pOQyOZXRyUEBM+rTSBQbEY1IEUT3lVuN2E3FdbDKOX0NJkQj0V1sWgOLd41emTN1 ngo9dlxZ/dYU4NO7gYNFhOGzjO4tjPdT6mEOHxvJBxunQUtv+j1wWyvWHBFSXY26XmGl 4bndwO+XfJiJzm0agyJkSPhZ4lUfGG7Fzj9Z9ZIXrn4SalU1e+Ci0f+Ll1N4OTNm/mGQ lH9QWOMklGa6lPLyg59SIifjMtY7PNxrECZ28F6urSwHlFjpkig9BhAD5UXXXIJYu1NR t3iLQprlu1y2H8mNN6p7Nf0dDgPqaEwC96LW3zb47aewguvJZF/wX8XADXzACfG0oNxy XpYg== X-Gm-Message-State: AElRT7FlAz0v5IYuCvwOv2BHoFQ09F3uOLdLTAFSrOf2NDJ/JA8KWV6u pwmJgSMPPTz6RKO1D6j+jLlnnUDKZKtCeqrMnkzDoQHi X-Google-Smtp-Source: AG47ELs1EFREqYOf5p0GWYbpw++eXFEHsSLlMfl2iC62x/A8GCbXTGZg1mxNZDEc1NZ7NCIPztKCqbdNRv+zSIDQnLc= X-Received: by 10.36.90.5 with SMTP id v5mr23834931ita.138.1520438552798; Wed, 07 Mar 2018 08:02:32 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Wed, 7 Mar 2018 08:02:30 -0800 (PST) In-Reply-To: <1520391833-9344-2-git-send-email-heyi.guo@linaro.org> References: <1520391833-9344-1-git-send-email-heyi.guo@linaro.org> <1520391833-9344-2-git-send-email-heyi.guo@linaro.org> From: Ard Biesheuvel Date: Wed, 7 Mar 2018 16:02:30 +0000 Message-ID: To: Heyi Guo Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH 2/2] Hisilicon/D0x: Enable tftp command by default X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 15:56:18 -0000 Content-Type: text/plain; charset="UTF-8" On 7 March 2018 at 03:03, Heyi Guo wrote: > Since D0x platforms always have network enabled, we would like to > enable tftp command by default so that we can download something in > EFI Shell. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Heyi Guo > Cc: Ard Biesheuvel > Cc: Leif Lindholm The first patch looks fine to me, but I would like to give Leif a chance to comment on the policy side of this patch. Please ping us by the end of next week if we haven't responded by then. > --- > Platform/Hisilicon/D03/D03.dsc | 2 ++ > Platform/Hisilicon/D05/D05.dsc | 1 + > 2 files changed, 3 insertions(+) > > diff --git a/Platform/Hisilicon/D03/D03.dsc b/Platform/Hisilicon/D03/D03.dsc > index cb0669d639d1..fce1e60b1275 100644 > --- a/Platform/Hisilicon/D03/D03.dsc > +++ b/Platform/Hisilicon/D03/D03.dsc > @@ -29,6 +29,8 @@ [Defines] > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > + > !include Silicon/Hisilicon/Hisilicon.dsc.inc > > [LibraryClasses.common] > diff --git a/Platform/Hisilicon/D05/D05.dsc b/Platform/Hisilicon/D05/D05.dsc > index 8373a821a496..f007f3d2d7e8 100644 > --- a/Platform/Hisilicon/D05/D05.dsc > +++ b/Platform/Hisilicon/D05/D05.dsc > @@ -29,6 +29,7 @@ [Defines] > SKUID_IDENTIFIER = DEFAULT > FLASH_DEFINITION = Platform/Hisilicon/$(PLATFORM_NAME)/$(PLATFORM_NAME).fdf > DEFINE EDK2_SKIP_PEICORE=0 > + DEFINE INCLUDE_TFTP_COMMAND = TRUE > DEFINE NETWORK_IP6_ENABLE = FALSE > DEFINE HTTP_BOOT_ENABLE = FALSE > > -- > 2.7.4 >