From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B38182097411C for ; Mon, 18 Jun 2018 02:45:00 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id 188-v6so11070437ita.5 for ; Mon, 18 Jun 2018 02:45:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ttyQxSUg2ZJpOIX1bdEy9r6B8eHfVsFAnBs180/JvOs=; b=S8Xl959q8RGtPi/Zi8ypGRj0+bQF7vsQAOH1RmY6inZHqxeA4pxBxn869pEDhAzZNq cCdyOFYSRXSJDZiNdX/ZPMAy4NqL1OVdkJFpyS56e7HPFZwAKHPxDhsmy/cdSLUVQ6sL qv31umN8+cvRpg8DBNga8guLeM4XQP3UqDtUA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ttyQxSUg2ZJpOIX1bdEy9r6B8eHfVsFAnBs180/JvOs=; b=XYbFEJWP5HBbBCAT/JdJhx6KFkymN06PWKQRa6xpNzpCxyCoOp6Y9ojhWMNiGwpdtC zhHNfiPE43A6cqCbwlwy+egLdWoUGbHfan1H5ukfoQBTqxtG+K0TGSU9D1BmW0+6Arxh QQqP/zDyYyqb3dDT8mZ7bog+zq7q74UT4/sJRoa/qLp2K8tfzagqFJtaIiVl1cld1/sd L0GOOqhwEiCWRY2JP/CuG/UYhNzmkyDebbk8v3wEeqVJHBRTchB9QeaYe01nmoUtyCXC B8k/Lp09NLZQstpXQbKjHOsuiY2+CYSp2a3MLgkZx1RkwbPLKK5IAxNsveAlWpGy2LFh sTTQ== X-Gm-Message-State: APt69E2H3oS/KdKWkB2fIziE+kSSBOq4rblT/ikThpypTMqf/gYEj1RQ 9gsZk6AFYqSibHaQt02rr+9P5iOhVuE3S3CdsUpBEw== X-Google-Smtp-Source: ADUXVKLRYnyo2BnCMYgH9LgR433IqNx5WXTFWtmxtSA9HGCRboaekO++X4pDd0Ho7Ud3rNATW/yqHZ9EpwkXBzGGpZE= X-Received: by 2002:a24:e105:: with SMTP id n5-v6mr9046399ith.68.1529315099575; Mon, 18 Jun 2018 02:44:59 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 02:44:59 -0700 (PDT) In-Reply-To: <1529299741-30054-1-git-send-email-chandni.cherukuri@arm.com> References: <1529299741-30054-1-git-send-email-chandni.cherukuri@arm.com> From: Ard Biesheuvel Date: Mon, 18 Jun 2018 11:44:59 +0200 Message-ID: To: Chandni Cherukuri Cc: "edk2-devel@lists.01.org" , Leif Lindholm Subject: Re: [PATCH edk2-platforms v3 0/2] Platform/ARM/Sgi: Enable Dynamic Configuration feature X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 09:45:00 -0000 Content-Type: text/plain; charset="UTF-8" On 18 June 2018 at 07:28, Chandni Cherukuri wrote: > Changes since v2: > - Addressed comments from Ard > - Depex on gHwConfigDtInfoPpiGuid > - Use address of DT instead of pointer to the address of DT > > Changes since v1: > - Addressed comments from Ard and Leif > - move definition of HwConfigDtBlob to PlatformLib.c > - use adr instead of ldr assembly instruction > - declare PPI in a PPI specific header file > - invert if conditional expression > - remove changes unrelated to the patch > - rename PEI files as per the standard > > On SGI platforms, the trusted firmware executes prior to the SEC > phase. It supplies to the SEC phase, a pointer to a HW CONFIG fdt > in the x1 which contains platform specific information such as part > number and config number of the SGI platform. > > The HW CONFIG FDT would look as, > /dts-v1/; > / { > /* compatible string */ > compatible = "arm,sgi-isys3"; > > /* platform ID node */ > system-id { > platform-id = <0x03000783>; > } > }; > > In the very first step of the assembly code which executes in SEC phase > the fdt pointer is stored in a global variable from the register. A PPI > is created during the SEC phase which stores the global variable. > > During PEI phase, a Platform ID PEIM is installed which accessess the PPI > and retrieves the platform information using FDT helper functions and a > PlatformId HOB is created and populated with the information. > > During DXE phase the drivers can access the Platform ID HOB to get the > platform information and perform platform specific functions based on the > platform. > > Chandni Cherukuri (2): > Platform/ARM/Sgi: Install a Platform ID HOB > Platform/ARM/Sgi: Pick ACPI tables to install based on platform ID > Reviewed-by: Ard Biesheuvel Pushed as f65939a9d98b..e93b4c776420 I did notice that there is a typo in the identifier 'gSgi575AcpiTablesiFileGuid' Could you please send a patch to fix up all occurrences? Thanks, Ard. > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.c | 30 +++++- > Platform/ARM/SgiPkg/Drivers/PlatformDxe/PlatformDxe.inf | 2 + > Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h | 23 ++++ > Platform/ARM/SgiPkg/Include/SgiPlatform.h | 13 +++ > Platform/ARM/SgiPkg/Library/PlatformLib/AArch64/Helper.S | 13 ++- > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.c | 10 ++ > Platform/ARM/SgiPkg/Library/PlatformLib/PlatformLib.inf | 3 + > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPei.inf | 40 +++++++ > Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c | 112 ++++++++++++++++++++ > Platform/ARM/SgiPkg/SgiPlatform.dec | 5 + > Platform/ARM/SgiPkg/SgiPlatform.dsc | 1 + > Platform/ARM/SgiPkg/SgiPlatform.fdf | 1 + > 12 files changed, 245 insertions(+), 8 deletions(-) > create mode 100644 Platform/ARM/SgiPkg/Include/Ppi/SgiPlatformId.h > create mode 100644 Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPei.inf > create mode 100644 Platform/ARM/SgiPkg/Library/SgiPlatformPei/SgiPlatformPeim.c > > -- > 2.7.4 >