From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x235.google.com (mail-it0-x235.google.com [IPv6:2607:f8b0:4001:c0b::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 3DA491A1E3D for ; Wed, 31 Aug 2016 02:53:20 -0700 (PDT) Received: by mail-it0-x235.google.com with SMTP id i184so4248209itf.1 for ; Wed, 31 Aug 2016 02:53:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=txLJPv+KlRcJa7wMR+9Aif/Ho2aeD1MJpOLzVaETa9Q=; b=d04xexC+omOgaztnbiu1KrY8TKLsUxrWeF+VNqbY+XuVFtjlOIb10u3cpMkkan4qpM yqZ6Si+QMWQF+CFPmLr2DzHKS8nDwBuMjtdsy7eziUhXWfxX2/V+LsnDAGTBRzOLhLMt 7zZz8/H3aTspiwebFXzNVRlDv90Di5TZ7wvtQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=txLJPv+KlRcJa7wMR+9Aif/Ho2aeD1MJpOLzVaETa9Q=; b=Olo+1haz/BkqOrwmKjmzXTPX3AuiPLlTrMmiiTojN3M6zarumypN5QKDScrzJ2T++/ PWGq9Ylo373TeAHnS8HsqQ0ZwtgCL7LygPqhPQIoW0A+gkmCdlT+AtTEizvhPkqJnW5w bczvRhM0rr/Udqr3Kq1HGtoJeSilOhbtOlMhbRXxCYuY+OADUpgABlPMoudGvTkwL5OL zloFqH0Kr6oSMAoom7MX0obwzFWIDi/EhlvU/skyepBmSnJQIedsoioeqy9j91ejRC2D xbf9aiQ69XmbWM6O6JqFD+k+Ec82wxdaF89ZvTuvTVHHa3l3MRaqZma3UOlWL8JRAfzs QvkA== X-Gm-Message-State: AE9vXwN3bqC7r9kNAMRP7ISBBaFqw0Ug2QtIUOEd8NUPBQKXdchaqTaa75OUF24VzTsLOlF2rMKmgMq2Kax72rg3 X-Received: by 10.36.34.204 with SMTP id o195mr11794986ito.29.1472637199633; Wed, 31 Aug 2016 02:53:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.36.204.195 with HTTP; Wed, 31 Aug 2016 02:53:18 -0700 (PDT) In-Reply-To: References: <1470842282-8415-1-git-send-email-ard.biesheuvel@linaro.org> <1470842282-8415-23-git-send-email-ard.biesheuvel@linaro.org> <20160811083817.GQ31760@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 31 Aug 2016 10:53:18 +0100 Message-ID: To: Michael Zimmermann Cc: Evan Lloyd , Leif Lindholm , "edk2-devel@lists.01.org" , "Cohen, Eugene" , Laszlo Ersek Subject: Re: [PATCH 22/26] ArmPlatformPkg/PrePi: switch to ASM_FUNC() asm macro X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 Aug 2016 09:53:20 -0000 Content-Type: text/plain; charset=UTF-8 On 31 August 2016 at 10:52, Michael Zimmermann wrote: >>Sorry to be pedantic, but shouldn't "Reviewed-by" mean code reviewed, and >> "Tested-by" > mean tested? > Yes you're right, sorry. I guess I just had too much hope in reviewers > actually testing the changes :D > You mean those reviewers that actually own a BeagleBoard? > On Wed, Aug 31, 2016 at 11:47 AM, Evan Lloyd wrote: >> >> >-----Original Message----- >> >From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >> >Michael Zimmermann >> >Sent: 31 August 2016 05:33 >> >To: Leif Lindholm >> >Cc: edk2-devel@lists.01.org; Cohen, Eugene; Laszlo Ersek; >> >ard.biesheuvel@linaro.org >> >Subject: Re: [edk2] [PATCH 22/26] ArmPlatformPkg/PrePi: switch to >> >ASM_FUNC() asm macro >> > >> >reviewed should mean tested ;) >> > >> Sorry to be pedantic, but shouldn't "Reviewed-by" mean code reviewed, and >> "Tested-by" mean tested? >> >> Evan >> ... >> >> IMPORTANT NOTICE: The contents of this email and any attachments are >> confidential and may also be privileged. If you are not the intended >> recipient, please notify the sender immediately and do not disclose the >> contents to any other person, use it for any purpose, or store or copy the >> information in any medium. Thank you. >> >