From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::133; helo=mail-it1-x133.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x133.google.com (mail-it1-x133.google.com [IPv6:2607:f8b0:4864:20::133]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 26C39211D35C2 for ; Tue, 5 Mar 2019 08:07:29 -0800 (PST) Received: by mail-it1-x133.google.com with SMTP id g17so4848799ita.2 for ; Tue, 05 Mar 2019 08:07:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6/1o8IiWtiAqiM23jjJTT1CNHGOtmG5vRkxHcM24yLg=; b=GKVAW8saA26Gyt1vaX2VHYWpoL7MzKS4feBqhwx/aAEr/w/WDDdXUSGGPqI9rGDyc8 1OJn8JhKSxJXem32mV58bY+oay+cv/KDYj9OQAAdUBr4uMnx0Whic9wP/2ewdNaID3Y7 7wPzxWdwGtlKYTEV+dtl5fZxCh1M6WbnXSi5ACF2QV3QqFvlZiI7/+TgyQel4GQMunRd e8P3r7UDn2y8A1YlLJAtpXXvdOQbPdb1zT/Xcs04mfZ5KoeXwqSH/xV4/3YbgcHCvJOF p/3unOpuLRppTtt7Tw/GNXR4qVOenuXiSWweBpuhSsFRFhqbCB+YDbhK8BwQ7zHRm8My QQ3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6/1o8IiWtiAqiM23jjJTT1CNHGOtmG5vRkxHcM24yLg=; b=e9zaqZOjBDzXu0aMc14M9pSoIlJKFJSd9anPwFOimI4yn9DVdOBw5sg2apleT3lXiV e4M1THEKuMevcIFTRaxSQvKvPU6Ai8Yit+kqlYnyBc4JQDWapXHjrJqO4jJZeYJLlWn5 nCI2UdrsuatWGKTQCUFWWYNP+o4pJooytJWH2BxhtnIzWdMpnfICrySxhOHdhvOn0Rmx fpVZqKETGxaFpDptLcbjUX9z1R2nMVupUY89Rs0dqbGGqoosrhWQYWBVwr1T1FquQgk7 7DVSPsClvTzUKDSJkJyhbqqCk0wpN8h0yegjNtuWqZgOFTaAoQshqDdV8vt6QVUnks2K Pnmg== X-Gm-Message-State: APjAAAVGvELl/L2S9ZlHBjkgirsI9vraSwtnHDdd+qQuOiYWvRjC6++U kSvH6okh8aknI8+4MUe3GZ9FXen+McCltytrrRExnA== X-Google-Smtp-Source: APXvYqwEa+p2RFfX7buZKgL7+ScrLU3lRlOP4fho6MOvIHfIqfe5S74+nteL8BNTlXNhzYi3lMoRTrijLUUfItiGGB0= X-Received: by 2002:a24:1947:: with SMTP id b68mr2718014itb.121.1551802048123; Tue, 05 Mar 2019 08:07:28 -0800 (PST) MIME-Version: 1.0 References: <20190305133248.4828-1-ard.biesheuvel@linaro.org> <20190305133248.4828-11-ard.biesheuvel@linaro.org> <74D8A39837DF1E4DA445A8C0B3885C503F54D1FD@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503F54F0BB@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503F54F0BB@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Tue, 5 Mar 2019 17:07:16 +0100 Message-ID: To: "Yao, Jiewen" Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal architected PI events into MM context X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 05 Mar 2019 16:07:29 -0000 Content-Type: text/plain; charset="UTF-8" On Tue, 5 Mar 2019 at 17:04, Yao, Jiewen wrote: > > OK. To keep the compatibility of existing MM driver. That makes sense. > > If it is for security, I think EndOfDxe is the only point. > ReadyToBoot and ExitBootService cannot be used for security purpose. > OK, good to know. I will keep them for the time being - MM drivers may be able to release resources or do other useful things when the non-secure side enters runtime mode. > Then do we need SmmReadyToLock ? :-) > Good point. It looked fairly x86 specific to me. Do you think it is likely to be used in OEM code running in MM mode? > > -----Original Message----- > > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > > Ard Biesheuvel > > Sent: Tuesday, March 5, 2019 7:58 AM > > To: Yao, Jiewen > > Cc: edk2-devel@lists.01.org > > Subject: Re: [edk2] [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal > > architected PI events into MM context > > > > On Tue, 5 Mar 2019 at 16:56, Yao, Jiewen wrote: > > > > > > Hi > > > In original SMM infrastructure, there are lots of interaction that SMM has > > to know the DXE status. > > > > > > In StandaloneMm, I don't expect we have many interaction. Is there any > > specific example? > > > > > > I am totally OK to add those. And I just want to know more usage. > > > > > > Reviewed-by: Jiewen.yao@intel.com > > > > > > > Jiewen, > > > > Thanks for the review. > > > > It is not 100% clear at the moment, but since existing third party > > software designed to run in MM context may make assumptions about > > security of the platform (e.g., before vs after end of dxe) based on > > these events, we should at least signal the common ones added in this > > patch. > > > > > > > > > > > > -----Original Message----- > > > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > > > Sent: Tuesday, March 5, 2019 5:33 AM > > > > To: edk2-devel@lists.01.org > > > > Cc: Ard Biesheuvel ; Achin Gupta > > > > ; Supreeth Venkatesh > > > > ; Yao, Jiewen ; > > > > Leif Lindholm ; Jagadeesh Ujja > > > > > > > > Subject: [PATCH 10/10] ArmPkg/MmCommunicationDxe: signal > > architected > > > > PI events into MM context > > > > > > > > PI defines a few architected events that have significance in the MM > > > > context as well as in the non-secure DXE context. So register notify > > > > handlers for these events, and relay them into the standalone MM world. > > > > > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > > > Signed-off-by: Ard Biesheuvel > > > > --- > > > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf | 5 > > +++ > > > > ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c | 47 > > > > +++++++++++++++++++- > > > > 2 files changed, 50 insertions(+), 2 deletions(-) > > > > > > > > diff --git > > a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > > > b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > > > index 88beafa39c05..8bf269270f9d 100644 > > > > --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > > > +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf > > > > @@ -48,6 +48,11 @@ [LibraryClasses] > > > > [Protocols] > > > > gEfiMmCommunicationProtocolGuid ## PRODUCES > > > > > > > > +[Guids] > > > > + gEfiEndOfDxeEventGroupGuid > > > > + gEfiEventExitBootServicesGuid > > > > + gEfiEventReadyToBootGuid > > > > + > > > > [Pcd.common] > > > > gArmTokenSpaceGuid.PcdMmBufferBase > > > > gArmTokenSpaceGuid.PcdMmBufferSize > > > > diff --git > > a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > > > > b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > > > > index feb9fa9f4ead..3203cf801a19 100644 > > > > --- a/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > > > > +++ b/ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.c > > > > @@ -265,6 +265,43 @@ GetMmCompatibility () > > > > return Status; > > > > } > > > > > > > > +STATIC EFI_GUID* CONST mGuidedEventGuid[] = { > > > > + &gEfiEndOfDxeEventGroupGuid, > > > > + &gEfiEventExitBootServicesGuid, > > > > + &gEfiEventReadyToBootGuid, > > > > +}; > > > > + > > > > +STATIC EFI_EVENT mGuidedEvent[ARRAY_SIZE (mGuidedEventGuid)]; > > > > + > > > > +/** > > > > + Event notification that is fired when GUIDed Event Group is signaled. > > > > + > > > > + @param Event The Event that is being > > processed, > > > > not used. > > > > + @param Context Event Context, not used. > > > > + > > > > +**/ > > > > +STATIC > > > > +VOID > > > > +EFIAPI > > > > +MmGuidedEventNotify ( > > > > + IN EFI_EVENT Event, > > > > + IN VOID *Context > > > > + ) > > > > +{ > > > > + EFI_MM_COMMUNICATE_HEADER Header; > > > > + UINTN Size; > > > > + > > > > + // > > > > + // Use Guid to initialize EFI_SMM_COMMUNICATE_HEADER structure > > > > + // > > > > + CopyGuid (&Header.HeaderGuid, Context); > > > > + Header.MessageLength = 1; > > > > + Header.Data[0] = 0; > > > > + > > > > + Size = sizeof (Header); > > > > + MmCommunicationCommunicate (&mMmCommunication, &Header, > > > > &Size); > > > > +} > > > > + > > > > /** > > > > The Entry Point for MM Communication > > > > > > > > @@ -287,6 +324,7 @@ MmCommunicationInitialize ( > > > > ) > > > > { > > > > EFI_STATUS Status; > > > > + UINTN Index; > > > > > > > > // Check if we can make the MM call > > > > Status = GetMmCompatibility (); > > > > @@ -351,8 +389,13 @@ MmCommunicationInitialize ( > > > > NULL, > > > > &mSetVirtualAddressMapEvent > > > > ); > > > > - if (Status == EFI_SUCCESS) { > > > > - return Status; > > > > + ASSERT_EFI_ERROR (Status); > > > > + > > > > + for (Index = 0; Index < ARRAY_SIZE (mGuidedEventGuid); Index++) { > > > > + Status = gBS->CreateEventEx (EVT_NOTIFY_SIGNAL, > > TPL_CALLBACK, > > > > + MmGuidedEventNotify, > > mGuidedEventGuid[Index], > > > > + mGuidedEventGuid[Index], > > > > &mGuidedEvent[Index]); > > > > + ASSERT_EFI_ERROR (Status); > > > > } > > > > > > > > gBS->UninstallProtocolInterface ( > > > > -- > > > > 2.20.1 > > > > > _______________________________________________ > > edk2-devel mailing list > > edk2-devel@lists.01.org > > https://lists.01.org/mailman/listinfo/edk2-devel