From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x236.google.com (mail-io0-x236.google.com [IPv6:2607:f8b0:4001:c06::236]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E2991803D2 for ; Wed, 22 Mar 2017 07:19:10 -0700 (PDT) Received: by mail-io0-x236.google.com with SMTP id z13so66369322iof.2 for ; Wed, 22 Mar 2017 07:19:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=pgmnpiB0kRNR95iIVeBqUFt8fX8FhAPBYjG4bI4ND1w=; b=a7h1ujBL/XxwuPEna+NEmiXa9Zzl1Phtb3RW0ej8RB8nmUBbuoZdw81krQW1nTX05S Jgte72od1uH7DKsoo8h2aBAJiEt5W6iDt/M7iSGhtgzjTko3VeYfdVnJ/mWvC9hQJetV hnJfkFG7rK6iz9vcpo5aEu7HFE3yl/BEfc4HY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=pgmnpiB0kRNR95iIVeBqUFt8fX8FhAPBYjG4bI4ND1w=; b=jGzL5Q1JYKtJcK4LgzbiePLenJvtoDNcZsrUcHRsuhJE+NYNJZbRedYRmQUbV2AlmI s99WIlVQEnw/bfNO9ZwHAOddeuOfDguOtfbHI/GBolqXTLI74hFUZ/7hz294cpyGe5mN QO2bT4AYOUUSlMXEpO0aAuKRRcEszUUyRWPZf5NoKpYXwQWSUpGBtBFj6aIjTUwjt5p+ aVPwEzVla8vzK7VoB/oIYG81EZ+sa8H5Oa+CrBYCwhFLHNYgYUpUbVojKArf8eH+zJQc 7qJ+sjX2tJx9TDVBXJ1bUdU4v85ue5wM9Lw+6hlLvYtBbeiF7IC9IiBLnELvykIrALMX wQfw== X-Gm-Message-State: AFeK/H111j21nwDEjo9l/eu8PLp5tDuuF29mNBc11MSTCcCuiC5f3kzey1yVGDjOd/c9HG3+Nz3eZAokTw92HRQp X-Received: by 10.107.168.21 with SMTP id r21mr34691998ioe.45.1490192350266; Wed, 22 Mar 2017 07:19:10 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Wed, 22 Mar 2017 07:19:09 -0700 (PDT) In-Reply-To: <20170317204731.31488-13-lersek@redhat.com> References: <20170317204731.31488-1-lersek@redhat.com> <20170317204731.31488-13-lersek@redhat.com> From: Ard Biesheuvel Date: Wed, 22 Mar 2017 14:19:09 +0000 Message-ID: To: Laszlo Ersek Cc: edk2-devel-01 , Leif Lindholm Subject: Re: [PATCH v2 12/12] ArmVirtPkg: remove PURE_ACPI_BOOT_ENABLE and PcdPureAcpiBoot X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 14:19:11 -0000 Content-Type: text/plain; charset=UTF-8 On 17 March 2017 at 20:47, Laszlo Ersek wrote: > The build flag and the FeaturePCD have no effect any longer, remove them. > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Laszlo Ersek Reviewed-by: Ard Biesheuvel > --- > ArmVirtPkg/ArmVirtPkg.dec | 10 ---------- > ArmVirtPkg/ArmVirtQemu.dsc | 5 ----- > 2 files changed, 15 deletions(-) > > diff --git a/ArmVirtPkg/ArmVirtPkg.dec b/ArmVirtPkg/ArmVirtPkg.dec > index a5ec42166445..efe83a383d55 100644 > --- a/ArmVirtPkg/ArmVirtPkg.dec > +++ b/ArmVirtPkg/ArmVirtPkg.dec > @@ -58,13 +58,3 @@ [PcdsFixedAtBuild, PcdsPatchableInModule] > # EFI_VT_100_GUID. > # > gArmVirtTokenSpaceGuid.PcdTerminalTypeGuidBuffer|{0x65, 0x60, 0xA6, 0xDF, 0x19, 0xB4, 0xD3, 0x11, 0x9A, 0x2D, 0x00, 0x90, 0x27, 0x3F, 0xC1, 0x4D}|VOID*|0x00000007 > - > -[PcdsFeatureFlag] > - # > - # Pure ACPI boot > - # > - # Inhibit installation of the FDT as a configuration table if this feature > - # PCD is TRUE. Otherwise, the OS is presented with both a DT and an ACPI > - # description of the platform, and it is up to the OS to choose. > - # > - gArmVirtTokenSpaceGuid.PcdPureAcpiBoot|FALSE|BOOLEAN|0x0000000a > diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc > index 328c2b79994b..88523650e946 100644 > --- a/ArmVirtPkg/ArmVirtQemu.dsc > +++ b/ArmVirtPkg/ArmVirtQemu.dsc > @@ -34,7 +34,6 @@ [Defines] > # -D FLAG=VALUE > # > DEFINE SECURE_BOOT_ENABLE = FALSE > - DEFINE PURE_ACPI_BOOT_ENABLE = FALSE > > !include ArmVirtPkg/ArmVirt.dsc.inc > > @@ -95,10 +94,6 @@ [PcdsFeatureFlag.common] > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutGopSupport|TRUE > gEfiMdeModulePkgTokenSpaceGuid.PcdConOutUgaSupport|FALSE > > -!if $(PURE_ACPI_BOOT_ENABLE) == TRUE > - gArmVirtTokenSpaceGuid.PcdPureAcpiBoot|TRUE > -!endif > - > [PcdsFixedAtBuild.common] > gArmPlatformTokenSpaceGuid.PcdCoreCount|1 > !if $(ARCH) == AARCH64 > -- > 2.9.3 >