[PATCH v1 1/1] ArmPkg/ArmPkg.dsc: Add missing components

[PATCH v1 1/1] ArmPkg/ArmPkg.dsc: Add missing components

[Michael Kubacki]

From: Michael Kubacki <michael.kubacki@microsoft.com>

REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2574

The following components are currently missing from the [Components]
section of ArmPkg.dsc:
  * ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
  * ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
  * ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf
  * ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf

This commit includes the components in the package DSC build.

Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: Leif Lindholm <leif@nuviainc.com>
Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>
---
 ArmPkg/ArmPkg.dsc | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
index 5f090d308766..549a2d29ab61 100644
--- a/ArmPkg/ArmPkg.dsc
+++ b/ArmPkg/ArmPkg.dsc
@@ -4,6 +4,7 @@
 # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
 # Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.<BR>
 # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
+# Copyright (c) Microsoft Corporation.<BR>
 #
 #    SPDX-License-Identifier: BSD-2-Clause-Patent
 #
@@ -133,11 +134,15 @@
   ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf
   ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf
   ArmPkg/Library/ArmLib/ArmBaseLib.inf
+  ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf
   ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
+  ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
   ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
   ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
 
+  ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
   ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
+  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
 
 [Components.AARCH64]
   ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
-- 
2.16.3.windows.1

Re: [PATCH v1 1/1] ArmPkg/ArmPkg.dsc: Add missing components

[Ard Biesheuvel]

On Tue, 24 Mar 2020 at 03:16, Michael Kubacki
<michael.kubacki@outlook.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2574
>
> The following components are currently missing from the [Components]
> section of ArmPkg.dsc:
>   * ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
>   * ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
>   * ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf
>   * ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>
> This commit includes the components in the package DSC build.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks Michael

> ---
>  ArmPkg/ArmPkg.dsc | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index 5f090d308766..549a2d29ab61 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -4,6 +4,7 @@
>  # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
>  # Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.<BR>
>  # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
> +# Copyright (c) Microsoft Corporation.<BR>
>  #
>  #    SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -133,11 +134,15 @@
>    ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf
>    ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf
>    ArmPkg/Library/ArmLib/ArmBaseLib.inf
> +  ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf
>    ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> +  ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>    ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
>    ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>
> +  ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
>    ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
> +  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
>
>  [Components.AARCH64]
>    ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
> --
> 2.16.3.windows.1
>