From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from mail-wr1-f65.google.com (mail-wr1-f65.google.com [209.85.221.65])
 by mx.groups.io with SMTP id smtpd.web12.8152.1585130232150838402
 for <devel@edk2.groups.io>;
 Wed, 25 Mar 2020 02:57:12 -0700
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=e6PTqbhY;
 spf=pass (domain: linaro.org, ip: 209.85.221.65, mailfrom: ard.biesheuvel@linaro.org)
Received: by mail-wr1-f65.google.com with SMTP id s1so2116118wrv.5
        for <devel@edk2.groups.io>; Wed, 25 Mar 2020 02:57:11 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=dMZSCNcimnTHd5wBUHg8Z+1Btvc6sF8IhI7FoNHzVtk=;
        b=e6PTqbhY5KJgxb6GtGYAWenUiOXdpjvRHSfzi8mPIgKWBOVjFuD8SknYEjCBz29Pz2
         MEczLnoCi4QKFG+VeHVu7b8hHTRuWDKa5t0HmrwDNYR46TbnOkUGIbpWjwh2HCP05bfr
         L9AbAJ7pxkI5D3LeIvcUezzLi4S/TRuKBia+XVMkUOo0eLrmyXmqVK/TN6m6gyYBwmcm
         5Kiu5GfifRmXmWGNtLmD1gWG4w9CGS/k/ffbPcd2uYu1M4nwtjgBrswTsi9Flv75OXpI
         fpmrCyEwiz1W5GiO9Qe5RU63OYGjIXtwHS2riqhqNhcF56Wg6nWDMRthuXGufXctUGD/
         7dyw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=dMZSCNcimnTHd5wBUHg8Z+1Btvc6sF8IhI7FoNHzVtk=;
        b=UhnPauqa1rnzFWoiDB4yIKfwRaWR9PLIip/Qpw0FiaItODVoukPCpNCIU4CH79F/Uk
         qO9O2wAyEpMGysgI4gypdpoYg7lG6xQmSfnfuaBjb2TemI7kfXkTb6PS3kZ7HeALHHjO
         bjoTD8UvC4YeAEWjMYQbFmzqUINw+kEbySK6TU63cfdDeQV3nfgfmn2/+g3rL2aExHLq
         9JAyb+GoQR7B86my4MeXn6QmcSZ5t6KU+z6SPtWSBRiZyrKDW6JCStXqZacKydd9/Tik
         f1drGeun9RxhSIP+UnHzk5eCsNzAPKtaC45NnzCl7KDDVbiDviOQuStumwqMOTciosq9
         /o7Q==
X-Gm-Message-State: ANhLgQ1SrVvvGZ0D0v/wumE9IjLFuTmy9dG2eHBnjOOvxImUdxFywU12
	kIM5mr1faVxZNPSWb3f4cn3fJfNebfYwMw6hytKjLA==
X-Google-Smtp-Source: ADFU+vvku52FDR5txbBARlpK2SFPX/ICEh1EEooreCMcGD/IKEyIWRQPW4PkTPVxuKmiL8vNpECtBnEBddbgmpvMvAA=
X-Received: by 2002:adf:fdc6:: with SMTP id i6mr2605236wrs.252.1585130230747;
 Wed, 25 Mar 2020 02:57:10 -0700 (PDT)
MIME-Version: 1.0
References: <MWHPR07MB344049AA86496A27C4944B47E9F10@MWHPR07MB3440.namprd07.prod.outlook.com>
In-Reply-To: <MWHPR07MB344049AA86496A27C4944B47E9F10@MWHPR07MB3440.namprd07.prod.outlook.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Wed, 25 Mar 2020 10:56:59 +0100
Message-ID: <CAKv+Gu_XYmas-dFD+PC7+vc4idA6nz50Yh_XQ6nDSs0yhbn2tQ@mail.gmail.com>
Subject: Re: [PATCH v1 1/1] ArmPkg/ArmPkg.dsc: Add missing components
To: Michael Kubacki <michael.kubacki@outlook.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Leif Lindholm <leif@nuviainc.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 24 Mar 2020 at 03:16, Michael Kubacki
<michael.kubacki@outlook.com> wrote:
>
> From: Michael Kubacki <michael.kubacki@microsoft.com>
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2574
>
> The following components are currently missing from the [Components]
> section of ArmPkg.dsc:
>   * ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
>   * ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
>   * ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf
>   * ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>
> This commit includes the components in the package DSC build.
>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Leif Lindholm <leif@nuviainc.com>
> Signed-off-by: Michael Kubacki <michael.kubacki@microsoft.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

Thanks Michael

> ---
>  ArmPkg/ArmPkg.dsc | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/ArmPkg/ArmPkg.dsc b/ArmPkg/ArmPkg.dsc
> index 5f090d308766..549a2d29ab61 100644
> --- a/ArmPkg/ArmPkg.dsc
> +++ b/ArmPkg/ArmPkg.dsc
> @@ -4,6 +4,7 @@
>  # Copyright (c) 2009 - 2010, Apple Inc. All rights reserved.<BR>
>  # Copyright (c) 2011 - 2018, ARM Ltd. All rights reserved.<BR>
>  # Copyright (c) 2016, Linaro Ltd. All rights reserved.<BR>
> +# Copyright (c) Microsoft Corporation.<BR>
>  #
>  #    SPDX-License-Identifier: BSD-2-Clause-Patent
>  #
> @@ -133,11 +134,15 @@
>    ArmPkg/Library/ArmGicArchLib/ArmGicArchLib.inf
>    ArmPkg/Library/ArmGicArchSecLib/ArmGicArchSecLib.inf
>    ArmPkg/Library/ArmLib/ArmBaseLib.inf
> +  ArmPkg/Library/ArmMtlNullLib/ArmMtlNullLib.inf
>    ArmPkg/Library/ArmSoftFloatLib/ArmSoftFloatLib.inf
> +  ArmPkg/Library/ArmSmcPsciResetSystemLib/ArmSmcPsciResetSystemLib.inf
>    ArmPkg/Library/PeiServicesTablePointerLib/PeiServicesTablePointerLib.inf
>    ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
>
> +  ArmPkg/Drivers/ArmCrashDumpDxe/ArmCrashDumpDxe.inf
>    ArmPkg/Drivers/ArmScmiDxe/ArmScmiDxe.inf
> +  ArmPkg/Drivers/MmCommunicationDxe/MmCommunication.inf
>
>  [Components.AARCH64]
>    ArmPkg/Library/ArmMmuLib/ArmMmuPeiLib.inf
> --
> 2.16.3.windows.1
>