From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency
Date: Thu, 8 Feb 2018 19:22:33 +0000 [thread overview]
Message-ID: <CAKv+Gu_XvzVdtq841cyGCGO6xhr-jtb7R3B5Ptq68pwEqPENZQ@mail.gmail.com> (raw)
In-Reply-To: <20180208191925.24269-1-leif.lindholm@linaro.org>
On 8 February 2018 at 19:19, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to
> actually drop it as a dependency for BeagleBoardLib.
>
> Get rid of it, so the module will still build when the Pcd is _really_
> removed.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
For the series:
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> index e004d6f10b..3b62f3cbf7 100644
> --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf
> @@ -44,9 +44,6 @@ [Sources.common]
> BeagleBoardHelper.S | GCC
> BeagleBoardHelper.asm | RVCT
>
> -[FeaturePcd]
> - gEmbeddedTokenSpaceGuid.PcdCacheEnable
> -
> [FixedPcd]
> gArmTokenSpaceGuid.PcdFdBaseAddress
> gArmTokenSpaceGuid.PcdFdSize
> --
> 2.11.0
>
next prev parent reply other threads:[~2018-02-08 19:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-08 19:19 [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency Leif Lindholm
2018-02-08 19:19 ` [PATCH 2/2] EmbeddedPkg: _really_ delete PcdCacheEnable from .dec Leif Lindholm
2018-02-08 19:22 ` Ard Biesheuvel [this message]
2018-02-09 9:41 ` [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_XvzVdtq841cyGCGO6xhr-jtb7R3B5Ptq68pwEqPENZQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox