From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EB31C222DE12E for ; Thu, 8 Feb 2018 11:16:49 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id 72so6967499iom.10 for ; Thu, 08 Feb 2018 11:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=AG+SMhJR6U1pHMlpX5eeEopwcnQfF5s1NT8sLCooKRU=; b=Gh0lOAdBp1xCF4daFrR2xYsTeEzjEKz4YAoAPab85z6WdliZyyqL69Hi0IhBTshc/f fw4ojcKLYkleoDFUMbC51Do88GrI1/+fb134My5HIbUbB0zkdQ2G13JRrcpOl29OCzNZ 12GU6QDQAN7ifCEd4oe/DoN80qCaFoHYRYAKM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=AG+SMhJR6U1pHMlpX5eeEopwcnQfF5s1NT8sLCooKRU=; b=gLLmyQmL2iGFK7FpBsrDEdm3zsqPdcyqpk/s5PPa2HSRJDNyJI4c9kLQjpUzj8ngBp Ck0++E4gUlow6jebSKuXedXdJiNGmLsB5K6SI3hc2vr8PzojljqDD0lgTwA3FCZUhHUO D0j9mrF6mUy8VejbXVyFahm3F/DNCtzJ0Vv+XhPNBVGUd0w4Y+/jweZk+SFJzsxe1rK1 V42T8+k/dM2n7w3yu3NzDyOAsSNqnacOnGM/zYUKN9zyMPuJfpBNxG94XEC0yty8oAcB f9dnfIfHpkBT3hoivBj38AKfn1k5mYO5ApNMOYR+rBBmm5EXTC7XfZLJjZzbwlRGQi/c 8R8w== X-Gm-Message-State: APf1xPAPPPH5v6O8azAmdt7AU+seFrD4MOuiBePQtfFCYRpMOStJveXj LT8m+P1tk4nouw3JvVla4Xic0u9fkgXHwuh4/DsbIg== X-Google-Smtp-Source: AH8x224uiJcIDBPx/oE72POQZNpnArGx2XAspn0O6nFKlvtJBclHK9PdsCgVZtNq2CFMZqz9ftbmzUpA3Gqrmyel8Dc= X-Received: by 10.107.33.65 with SMTP id h62mr153138ioh.104.1518117754132; Thu, 08 Feb 2018 11:22:34 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.112.13 with HTTP; Thu, 8 Feb 2018 11:22:33 -0800 (PST) In-Reply-To: <20180208191925.24269-1-leif.lindholm@linaro.org> References: <20180208191925.24269-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Thu, 8 Feb 2018 19:22:33 +0000 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH 1/2] BeagleBoardPkg: drop unused PcdCacheEnabled dependency X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Feb 2018 19:16:50 -0000 Content-Type: text/plain; charset="UTF-8" On 8 February 2018 at 19:19, Leif Lindholm wrote: > Commit f72df138 got rid of the use of PcdCacheEnabled, but failed to > actually drop it as a dependency for BeagleBoardLib. > > Get rid of it, so the module will still build when the Pcd is _really_ > removed. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Leif Lindholm For the series: Reviewed-by: Ard Biesheuvel > --- > BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > index e004d6f10b..3b62f3cbf7 100644 > --- a/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > +++ b/BeagleBoardPkg/Library/BeagleBoardLib/BeagleBoardLib.inf > @@ -44,9 +44,6 @@ [Sources.common] > BeagleBoardHelper.S | GCC > BeagleBoardHelper.asm | RVCT > > -[FeaturePcd] > - gEmbeddedTokenSpaceGuid.PcdCacheEnable > - > [FixedPcd] > gArmTokenSpaceGuid.PcdFdBaseAddress > gArmTokenSpaceGuid.PcdFdSize > -- > 2.11.0 >