From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 096BE201B045C for ; Wed, 20 Feb 2019 06:48:45 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id l15so16006229iti.4 for ; Wed, 20 Feb 2019 06:48:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NXN65/9vRZbmhEdRJQDFpTeXT8awaTS8YE5CXSchhOE=; b=poqYwb/aPL3FiWt4rQru8ZRniv0rfo55fTW4wJx3CYnAVBFtEWU2VrsDn/TY3S9CCO 2snEJ8NPQvOfx2h7EWeh9vVfU5r5piRfPn8BrlruWIIiT2stwApjQi3VN02Lv+cR6Uza P4c8RXWwDDDqdjMTRHuMVmA+cB3jWccSBTwhbinFJY3fpckQhbw2KiR8Xlrz/UOlsARM ikQpcvx+IAWuls4hekomFi/2xhTJIs6o82OmhWOef2nSv2p2cKnjH9Qm+413dqQCj8Tb R42flVEv74wAcVZ8y9/0RQFwMSBtj53B4HfQAM8Z9PDCeYJuaCm8xpGFxe1uhf7wmFk1 KA7g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NXN65/9vRZbmhEdRJQDFpTeXT8awaTS8YE5CXSchhOE=; b=F676UG3tU1tMl1oBu4kTMZCtl+ObqNwHVDuEb6piJ0Ss4n0O1Rokc8Q7cg7WvIZORF pVXj5S9kCfRVGfGnhpDQBDgUvuyYglNhhroWdxsThL9xMaJ4aFc3kv4Ztb8uOs+UjG3A gjPYhzgbNwY3MHkZxUY/+0GAbMF90q+BMncBsOegw+lgwhlEA89aJwsB90K6bytoRCh2 IXnKZDlKTBIZcTp7NHZ3rTi5q9JxNBYfFdK9i1CTeuXmX5C3cLSaLvF21apw7YMfCsu7 0zyt1ljShnjSZBM3tI2+xylq4qQ1aNrn3h4Hk6OAX/DitjSAyetHxQxWoVy+g6kh8x8X yOrA== X-Gm-Message-State: AHQUAubaxVcTZM7xps25MoVSkoIGsTjqShN4Pz4M3D7Ilv3MDaqPyAf5 O4sfFGNSiofBMn1KUBsbWmKAoeATA7J3QNeIxnoj+w== X-Google-Smtp-Source: AHgI3IYSw4b7v4WvxDN2UuM1WZVzjJbcQQfR3XROCo8TwO89wmjAeRI3LKoSaJvCtNA2pIO9Q0KziGVRZDJHqjneNTw= X-Received: by 2002:a24:45dd:: with SMTP id c90mr5992264itd.71.1550674125029; Wed, 20 Feb 2019 06:48:45 -0800 (PST) MIME-Version: 1.0 References: <20190220142741.28232-1-ard.biesheuvel@linaro.org> <20190220143820.en6bdbi7swbhpsgx@bivouac.eciton.net> In-Reply-To: <20190220143820.en6bdbi7swbhpsgx@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 20 Feb 2019 15:48:33 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH edk2-platforms] Silicon/AMD/Styx/Drivers/AcpiPlatformDxe: use correct object ref in DBG2 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 20 Feb 2019 14:48:46 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 20 Feb 2019 at 15:38, Leif Lindholm wrote: > > On Wed, Feb 20, 2019 at 03:27:41PM +0100, Ard Biesheuvel wrote: > > The NamespaceString[] field in the DBG2 table should contain a fully > > qualified ACPI namespace object reference. This was found by fwts. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks. Pushed as 76d9e9a5da9e..54f98cb1789a > > --- > > Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc > > index 07635aa9dd8e..e55119258bac 100644 > > --- a/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc > > +++ b/Silicon/AMD/Styx/Drivers/AcpiPlatformDxe/Dbg2.aslc > > @@ -25,7 +25,7 @@ > > #define EFI_ACPI_DBG2_REVISION 0 > > #define DBG2_NUM_DEBUG_PORTS 1 > > #define DBG2_NUMBER_OF_GENERIC_ADDRESS_REGISTERS 1 > > -#define DBG2_NAMESPACESTRING_FIELD_SIZE 8 > > +#define DBG2_NAMESPACESTRING_FIELD_SIZE 9 > > #define DBG2_OEM_DATA_FIELD_SIZE 0 > > #define DBG2_OEM_DATA_FIELD_OFFSET 0 > > > > @@ -33,7 +33,7 @@ > > #define DBG2_DEBUG_PORT_SUBTYPE_UEFI 0x0007 // Sub type for UEFI Debug Port > > #define PL011_UART_LENGTH 0x1000 > > > > -#define NAME_STR_UART1 {'C', 'O', 'M', '1', '\0', '\0', '\0', '\0'} > > +#define NAME_STR_UART1 "\\SB.COM1" > > #define NAME_STR_UEFI {'U', 'E', 'F', 'I', '\0', '\0', '\0', '\0'} > > > > > > -- > > 2.20.1 > >