From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::142; helo=mail-it1-x142.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x142.google.com (mail-it1-x142.google.com [IPv6:2607:f8b0:4864:20::142]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 23531211ACEBE for ; Mon, 7 Jan 2019 05:06:02 -0800 (PST) Received: by mail-it1-x142.google.com with SMTP id w18so962290ite.1 for ; Mon, 07 Jan 2019 05:06:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q6vuuPjWmevfUpV5wW53Xj3Z+0UadD/veJeZCBy+XtM=; b=QtNjxy/uR7KdUuJfwO5S91Cbp7ejKKYQpE3EcFA1OQV4/DFlGDyPQhwL7KChNVDe3r F1FHv23HfUZ4XrfSoSPZWXclc+EmZPoaJ60lctdsTxQp/ufwnR2RhmDM8cASK0OjENIr SjSz5zbHqc0WipuByHZPMVnT7LJjcBqiCSyMU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q6vuuPjWmevfUpV5wW53Xj3Z+0UadD/veJeZCBy+XtM=; b=WYeX2c78kdYwm14wvatoUx8IcFEQQJIhI5Owe90j8RtZEljJpsVA6rIqMy4FefCIpA 0H9LgtWRTaGMCgCcJhVEZ+Ba28liaQvfNYUhteOsc/eaYnwk7R9cn4Y8Rf/rhLMFxgBf 3f6ZUud2ng3ZgVfLRq6+ACd7zJ6k+04MUHcSJfb+TAdq4K4AN+SaTagPV4d3Sc2UaqeW ZgnWrBbgVPzTq4q3+lSJWNMw/n6GspWL9Ak7melD4iGBASoKMnDgDyMa4PdeSLkyuhLi xTI0vfAxhkvsLECe9kWM7X8ImxXVSUgaVRp30L0BescUNHsBpk/VVB937tAtO0vLjvhe +/9g== X-Gm-Message-State: AJcUukdHArvpEPUnwfuG8hl+qRn7BJKXDjUmZuqshHTSuyWI+GoPOeRW Jj+S0DklIHTKyEMRWmeeHnMINfaMEnK/f7ukC1FwFg== X-Google-Smtp-Source: ALg8bN4Uwafc3cvlwpHUxpqhZNw9sQFKgpb0qaZ7EEPF2a3Ya0jK/7oltOcg9J11vX2fzfmuHRDsVpTbhKLcJkXyRSA= X-Received: by 2002:a05:660c:4b:: with SMTP id p11mr7400536itk.71.1546866361744; Mon, 07 Jan 2019 05:06:01 -0800 (PST) MIME-Version: 1.0 References: <20190103182825.32231-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AD13F@SHSMSX152.ccr.corp.intel.com> In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E3AD13F@SHSMSX152.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 7 Jan 2019 14:05:49 +0100 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Wang, Jian J" , "Wu, Hao A" , Jagadeesh Ujja , Achin Gupta , Thomas Panakamattam Abraham , Sami Mujawar Subject: Re: [PATCH 0/6] implement standalone MM versions of the variable runtime drivers X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 07 Jan 2019 13:06:03 -0000 Content-Type: text/plain; charset="UTF-8" On Mon, 7 Jan 2019 at 13:44, Gao, Liming wrote: > > Ard: > I agree this design is good. But, I need some time to evaluate its impact on our X86 platform. Could you wait for several days? > Of course. Thanks, > > -----Original Message----- > > From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] > > Sent: Friday, January 4, 2019 2:28 AM > > To: edk2-devel@lists.01.org > > Cc: Ard Biesheuvel ; Laszlo Ersek ; Leif Lindholm ; Kinney, > > Michael D ; Gao, Liming ; Wang, Jian J ; Wu, Hao A > > ; Jagadeesh Ujja ; Achin Gupta ; Thomas Panakamattam > > Abraham ; Sami Mujawar > > Subject: [PATCH 0/6] implement standalone MM versions of the variable runtime drivers > > > > This series proposed an alternative approach to the series sent out by > > Jagadeesh [0]. In particular, it gets rid of the InMm() calls and the > > special PCD, as well as some other if() conditionals. > > > > The primary difference is that this series defines and implements > > MmServicesTableLib in such a way that the traditional SMM drivers > > can use it as well. This is appropriate, considering that the PI > > spec has rebranded traditional SMM as one implementation of the generic > > MM framework. > > > > Patch #1 is based on Jagadeesh's patch, and introduces the MmServicesTableLib > > library class, but for all SMM flavours, not only for standalone MM. > > > > Patch #2 implements MmServicesTableLib for traditional SMM implementations. > > > > Patch #3 refactors FaultTolerantWriteDxe so that the parts of the SMM > > driver that invoke boot services are separated from the core SMM pieces. > > > > Patch #4 implements FaultTolerantWriteSmm for the standalone MM environment. > > > > Patches #5 and #6 do the same, respectively, for the variable runtime driver. > > > > This approach minimizes the delta, and thus the maintenance burden, between > > the traditional SMM and standalone MM drivers, while not resorting to runtime > > checks or other conditionals in the code to implement logic that should be > > decided at build time. > > > > Note that this series only covers part of the work contributed by Jagadeesh. > > This series focuses on the MdePkg and MdeModulePkg changes that affect shared > > code. > > > > Cc: Laszlo Ersek > > Cc: Leif Lindholm > > Cc: Michael D Kinney > > Cc: Liming Gao > > Cc: Jian J Wang > > Cc: Hao Wu > > Cc: Jagadeesh Ujja > > Cc: Achin Gupta > > Cc: Thomas Panakamattam Abraham > > Cc: Sami Mujawar > > > > Ard Biesheuvel (5): > > MdePkg: implement MmServicesTableLib based on traditional SMM > > MdeModulePkg/FaultTolerantWriteDxe: factor out boot service accesses > > MdeModulePkg/FaultTolerantWriteDxe: implement standalone MM version > > MdeModulePkg/VariableRuntimeDxe: factor out boot service accesses > > MdeModulePkg/VariableRuntimeDxe: implement standalone MM version > > > > Jagadeesh Ujja (1): > > MdePkg/Include: add MmServicesTableLib header file > > > > MdeModulePkg/MdeModulePkg.dsc | 1 + > > .../FaultTolerantWrite.h | 22 ++- > > .../FaultTolerantWriteDxe.c | 31 ++++ > > .../FaultTolerantWriteSmm.c | 54 +++---- > > .../FaultTolerantWriteSmm.inf | 5 +- > > .../FaultTolerantWriteSmmCommon.h | 31 ++++ > > .../FaultTolerantWriteSmmDxe.c | 1 + > > .../FaultTolerantWriteStandaloneMm.c | 70 +++++++++ > > .../FaultTolerantWriteStandaloneMm.inf | 90 ++++++++++++ > > .../FaultTolerantWriteTraditionalMm.c | 94 ++++++++++++ > > .../UpdateWorkingBlock.c | 10 +- > > .../Variable/RuntimeDxe/TcgMorLockSmm.c | 18 +-- > > .../Universal/Variable/RuntimeDxe/Variable.h | 50 +++++++ > > .../Variable/RuntimeDxe/VariableSmm.c | 59 +++----- > > .../Variable/RuntimeDxe/VariableSmm.inf | 5 +- > > .../RuntimeDxe/VariableStandaloneMm.c | 69 +++++++++ > > .../RuntimeDxe/VariableStandaloneMm.inf | 135 ++++++++++++++++++ > > .../RuntimeDxe/VariableTraditionalMm.c | 114 +++++++++++++++ > > MdePkg/Include/Library/MmServicesTableLib.h | 25 ++++ > > .../MmServicesTableLib/MmServicesTableLib.c | 63 ++++++++ > > .../MmServicesTableLib/MmServicesTableLib.inf | 45 ++++++ > > .../MmServicesTableLib/MmServicesTableLib.uni | 22 +++ > > MdePkg/MdePkg.dec | 4 + > > MdePkg/MdePkg.dsc | 1 + > > 24 files changed, 916 insertions(+), 103 deletions(-) > > create mode 100644 MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.c > > create mode 100644 MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteStandaloneMm.inf > > create mode 100644 MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteTraditionalMm.c > > create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.c > > create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableStandaloneMm.inf > > create mode 100644 MdeModulePkg/Universal/Variable/RuntimeDxe/VariableTraditionalMm.c > > create mode 100644 MdePkg/Include/Library/MmServicesTableLib.h > > create mode 100644 MdePkg/Library/MmServicesTableLib/MmServicesTableLib.c > > create mode 100644 MdePkg/Library/MmServicesTableLib/MmServicesTableLib.inf > > create mode 100644 MdePkg/Library/MmServicesTableLib/MmServicesTableLib.uni > > > > -- > > 2.17.1 >