From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Kalyan Nagabhirava <kalyankumar.nagabhirava@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
Mark Gregotski <mark.gregotski@linaro.org>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH edk2-platforms]: resolving Hikey platform build error
Date: Tue, 14 Nov 2017 11:18:25 +0000 [thread overview]
Message-ID: <CAKv+Gu_YYwxgXzjR34EyjdXC_yAo8xocS2ximcHJfVjGEvS9wg@mail.gmail.com> (raw)
In-Reply-To: <CAPcudRgM123V6DLGQLhziXEWuLfZHRhDUr2CxqwQhw8tBaOXEA@mail.gmail.com>
On 14 November 2017 at 11:16, Kalyan Nagabhirava
<kalyankumar.nagabhirava@linaro.org> wrote:
>
> "Instance of library class [CapsuleLib] is not found" build error is coming
> for Hikey platform, to resolve this issueadded CapsuleLib to
> "LibraryClasses.common" section
>
> diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc
> b/Platform/Hisilicon/HiKey/HiKey.dsc
> index 968e8ac..2e3b1c8 100644
> --- a/Platform/Hisilicon/HiKey/HiKey.dsc
> +++ b/Platform/Hisilicon/HiKey/HiKey.dsc
> @@ -61,6 +61,7 @@
>
> SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf
>
> FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf
> + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf
>
> UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
>
> PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf
> BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf
>
>
Thanks Kalyan
Could you resend it as a proper patch, please? I.e., with the appropriate
Contributed-under: TianoCore Contribution Agreement 1.1
and Signed-off-by line,
next parent reply other threads:[~2017-11-14 11:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CAPcudRgM123V6DLGQLhziXEWuLfZHRhDUr2CxqwQhw8tBaOXEA@mail.gmail.com>
2017-11-14 11:18 ` Ard Biesheuvel [this message]
2017-11-15 11:27 [PATCH] [edk2-platforms]:resolving Hikey platform build error kalyan-nagabhirava
2017-11-15 11:34 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_YYwxgXzjR34EyjdXC_yAo8xocS2ximcHJfVjGEvS9wg@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox