From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::244; helo=mail-it0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x244.google.com (mail-it0-x244.google.com [IPv6:2607:f8b0:4001:c0b::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8497F2035A7AF for ; Tue, 14 Nov 2017 03:14:19 -0800 (PST) Received: by mail-it0-x244.google.com with SMTP id l196so13119580itl.4 for ; Tue, 14 Nov 2017 03:18:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=G/B15Or9kHCGZn6RkyDZ3f3iFEacMM1HCeAbo2ahU9I=; b=SCCFJqe2UihBlXKziBotKz6N1oqXDCE9VHDPPzv2iZlB/4YJh677F2aKnJgC9wOxKN DioqxRUTV8BR84bHTcbKa2DAJEhwlt0BhgyGuwX/oqJmpOa2mrLEMI1o6MtIPIocK1WV zP8E01h/fwYjy4bTlH8LPOOk2pJ0B7Iu0w4bU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=G/B15Or9kHCGZn6RkyDZ3f3iFEacMM1HCeAbo2ahU9I=; b=GXbYp5pRuy61NagvlT0VdhfVtNQS2quqgpEwhj9DWl6htm07RtwqcAYEP0gXKry+CX cDjkfvbAyRtJL93BFPq7Mt1f8nuF48ipDfbex/kL9TiGyiMS7ifnZWbCG7HbEiBmYBIv 08EAxYxBaPU/X8VptoiqSFRNEK9XPLqxSxzRdy8Aq2iGQYylrnO2KnfyqMRdRn33IpDF NEp6Ddiz8lQxOvPJcn6VLVyYs4Bvq3mUcMgJC95geNT3ZUaCDubN5l1vzdiA+8ooIibD QaYDJND/iMZvrfKvuE5OdiVjMOX7cVeCsPbvZYEhMZ724BsBoVn0g9W2kIJMNw4Jp1Mu eLEw== X-Gm-Message-State: AJaThX6bMrf+kA47uzDR6EGExRcZEcXKLLItCPgwcbkPrlRpQiDvfzS+ mgaTwzvbThwUGy5RAjpaT2AiG/HxWh0lePrXbd01ZwmxOYg= X-Google-Smtp-Source: AGs4zMY0htm4M7m0P9jOhpqKbtJVKwcnSrQNPhQY0k0ZCVqevQECu/mU0RQs1amMF+j7pZSIjWFp0yyNiwcb7WfIHD0= X-Received: by 10.36.31.212 with SMTP id d203mr13493884itd.48.1510658306178; Tue, 14 Nov 2017 03:18:26 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.104.20 with HTTP; Tue, 14 Nov 2017 03:18:25 -0800 (PST) In-Reply-To: References: From: Ard Biesheuvel Date: Tue, 14 Nov 2017 11:18:25 +0000 Message-ID: To: Kalyan Nagabhirava Cc: "edk2-devel@lists.01.org" , Mark Gregotski , Leif Lindholm Subject: Re: [PATCH edk2-platforms]: resolving Hikey platform build error X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 14 Nov 2017 11:14:19 -0000 Content-Type: text/plain; charset="UTF-8" On 14 November 2017 at 11:16, Kalyan Nagabhirava wrote: > > "Instance of library class [CapsuleLib] is not found" build error is coming > for Hikey platform, to resolve this issueadded CapsuleLib to > "LibraryClasses.common" section > > diff --git a/Platform/Hisilicon/HiKey/HiKey.dsc > b/Platform/Hisilicon/HiKey/HiKey.dsc > index 968e8ac..2e3b1c8 100644 > --- a/Platform/Hisilicon/HiKey/HiKey.dsc > +++ b/Platform/Hisilicon/HiKey/HiKey.dsc > @@ -61,6 +61,7 @@ > > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > > FdtLib|EmbeddedPkg/Library/FdtLib/FdtLib.inf > + CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf > > UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf > > PlatformBootManagerLib|ArmPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf > BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf > > Thanks Kalyan Could you resend it as a proper patch, please? I.e., with the appropriate Contributed-under: TianoCore Contribution Agreement 1.1 and Signed-off-by line,