From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4720421EB529A for ; Thu, 31 Aug 2017 06:37:28 -0700 (PDT) Received: by mail-io0-x229.google.com with SMTP id k22so22950607iod.2 for ; Thu, 31 Aug 2017 06:40:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=S1oxQLQKNjiSIZIavz5sXcrELMHGZBtmdJISp4w9eJA=; b=iaxFn2HXszc1B4PBDliKWzwmpbfjsKkhkBCmUdu1tj0iNHU8r4yxx47QNggUxzW4Vx m4qaZwQ0sU3u/ePx2iTsNNNguudoD9iEGF60yD7oi5IPybkDSpbntvIeHl8xF5dBupC3 cf83yGyDqB/0fnpYjVhP8YOuvjZjVnFgYnk0M= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=S1oxQLQKNjiSIZIavz5sXcrELMHGZBtmdJISp4w9eJA=; b=jGioYDSh9j0gng9+OwNAiVPEiDPWmmuknfskcVkg/ByjNJTheeiBnjfLJl8XY3AOa8 ZSznvkqIzUUuvXSKle7emgYCbo+xs0+dW9UmoDf9plWLaAAKqKi6tVGXEwuYJlrn+JGJ KokwtGjcDiAflwdoA64ENvwq/4vwYzQfYbDXf3ml4U9LYRiJd7hHOaeuDRT8vpGuvVky aDjODcEZxkKg6+vxKE/xgpJUTql33DleZjN85jcLzPXIeKdbuKyMBHmO9zH89fTkKdWf 7i7FQsAorGXsRxHh4vpcsVW599q+0ihJv80zO9z2+VJJJ7UdtHugeA5LUtnD68IBfzou W1gA== X-Gm-Message-State: AHPjjUg8abFkhy/v/QT7hyyC8Updot+D0WoN26ghEQgEuBN/6CR3rS9y 7iHuGByAPsGLreVgaqKlRQMzSBfwS/jY X-Google-Smtp-Source: ADKCNb5QJfBbRjpq9f4gXfU1SbxvYwgaPA1Kn0TInysu4Usxcsz6Q8HRlY2tmi93X6DN3hOUpFQjN0o8Yq9wXz/wirw= X-Received: by 10.107.131.153 with SMTP id n25mr5174375ioi.263.1504186811072; Thu, 31 Aug 2017 06:40:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Thu, 31 Aug 2017 06:40:10 -0700 (PDT) In-Reply-To: References: <20170825122554.17819-1-ard.biesheuvel@linaro.org> <20170829154603.fvhfwp66asipxnoe@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 31 Aug 2017 14:40:10 +0100 Message-ID: To: Marcin Wojtas Cc: Leif Lindholm , edk2-devel-01 Subject: Re: [PATCH] Platform/Armada/Pp2Dxe: switch to ArmDmaLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 31 Aug 2017 13:37:28 -0000 Content-Type: text/plain; charset="UTF-8" On 31 August 2017 at 14:35, Marcin Wojtas wrote: > Hi Ard, > > 2017-08-30 15:26 GMT+02:00 Ard Biesheuvel : >> On 29 August 2017 at 18:01, Ard Biesheuvel wrote: >>> On 29 August 2017 at 16:53, Marcin Wojtas wrote: >>>> 2017-08-29 17:48 GMT+02:00 Ard Biesheuvel : >>>>> On 29 August 2017 at 16:47, Marcin Wojtas wrote: >>>>>> 2017-08-29 17:46 GMT+02:00 Leif Lindholm : >>>>>>> On Fri, Aug 25, 2017 at 01:25:54PM +0100, Ard Biesheuvel wrote: >>>>>>>> Instead of hardcoding the non-cache coherent nature of this device >>>>>>>> by invoking UncachedMemoryAllocationLib directly for allocating >>>>>>>> shared buffers, switch to DmaLib, which encapsulates this at a >>>>>>>> more abstract level. This allows the driver to be shared with >>>>>>>> platforms that are cache coherent (by simply switching to another >>>>>>>> DmaLib implementation), and removes the hardcoded dependency on >>>>>>>> UncachedMemoryAllocationLib, which will be removed from upstream >>>>>>>> EDK2. >>>>>>>> >>>>>>>> Contributed-under: TianoCore Contribution Agreement 1.1 >>>>>>>> Signed-off-by: Ard Biesheuvel >>>>>>> >>>>>>> Ah, and there is the non-bogus fix :) >>>>>>> Reviewed-by: Leif Lindholm >>>>>> >>>>>> Please let me just run this on the HW before merge - I'll do it tomorrow. >>>>>> >>>>> >>>>> Sure. Note that you will need to sync EDK2 after I merged the DmaLib >>>>> changes (which I will do today) >>>> >>>> Ok, please let know once it's available and also it would be great if >>>> this patch could be shared via github repo. >>>> >>> >>> The prerequisite patches for DmaLib are in EDK2 now. >>> >>> https://git.linaro.org/people/ard.biesheuvel/edk2-platforms.git/log/?h=mvpp2-dmalib >> >> Note that I just updated this branch to use NonCoherentDmaLib rather >> than ArmDmaLib > > Network continues to work fine on Armada 7040 DB, so > > Tested-by: Marcin Wojtas Thank you!