From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::243; helo=mail-it0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x243.google.com (mail-it0-x243.google.com [IPv6:2607:f8b0:4001:c0b::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 53D8B207DF288 for ; Fri, 1 Jun 2018 08:10:53 -0700 (PDT) Received: by mail-it0-x243.google.com with SMTP id v83-v6so2215610itc.3 for ; Fri, 01 Jun 2018 08:10:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aS4QLvlZ/Pu9zW3ze4kwWHUc7BPAoBPznSNo1QP3If0=; b=FqLiPYy8Rm5djZYpbsludq9Z1/0BG8y2uTppf3eRFHdyRGVekFAPqXIOL4x84KgJfN VkwYXdtqMZ08kJvTmZz/Fei8pvddGM1nsVcUOiatzDL9u09BclXDnKGnKI7OVGSpNAld dEM7a61wrM7CVzIQT3o95u6KfIVfmI+rKlnGo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aS4QLvlZ/Pu9zW3ze4kwWHUc7BPAoBPznSNo1QP3If0=; b=A00+o/WtqvS+mitWgfhbmMXw2Z8XB5eOgaJWmbZrvJ4OuR+CAhWdMukKlrAM34YyqK i/iR1/rnRQunDVInZ/mHJx8pKRZAcRX4QBMx6UVggvYvSKfBbwEIDlAtLF+s9o7euWOr ah1Gpj96jmzn+4n32VFRrTy/N0GWvVCUbBW/UdaZUeiyUEHFChfvx3NTGQ0rQovygwDx DojxN75Fh/VZWQ0YTSl+BXjkmt12Q1587KLzRalL5O2sr1ryuAviXDI4Wal46rMpJb8v apPH443BHaEiQDftSTGR0Ar8OMJEfeu2BOC4MNBjll4JHcK2gEPEWcQ0GUlQyg8SnZg7 UeeA== X-Gm-Message-State: APt69E3yaTWiCRhha5UXi34FEnDZUpX9ilP/HVpI6JVfjLG5lCoUzbav d0hm4LNjO+67HPmE1XLmQqqc9oAf4fkowD7x72uTfw== X-Google-Smtp-Source: ADUXVKKEC91cnE7bSzUUc1n7buwFnkHnkxHZjeQTz7LPAPgnd+GIieT7eXxxbjes8lXY5gh7sfAiaBugbUlnsPAXKGI= X-Received: by 2002:a24:5091:: with SMTP id m139-v6mr4652378itb.50.1527865853309; Fri, 01 Jun 2018 08:10:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bb86:0:0:0:0:0 with HTTP; Fri, 1 Jun 2018 08:10:52 -0700 (PDT) In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503AC1F635@shsmsx102.ccr.corp.intel.com> References: <20180531090149.29202-1-ard.biesheuvel@linaro.org> <0C09AFA07DD0434D9E2A0C6AEB0483103BB5009F@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C503AC1F635@shsmsx102.ccr.corp.intel.com> From: Ard Biesheuvel Date: Fri, 1 Jun 2018 17:10:52 +0200 Message-ID: To: "Yao, Jiewen" Cc: "Zeng, Star" , "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" Subject: Re: [PATCH] SignedCapsulePkg: add PcdLowestSupportedFirmwareVersion X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 15:10:54 -0000 Content-Type: text/plain; charset="UTF-8" On 1 June 2018 at 17:09, Yao, Jiewen wrote: > I am about to agree. > > Would you please share a real example on how this PCD is used in some open source platforms? > Please refer to this patch https://lists.01.org/pipermail/edk2-devel/2018-March/022914.html Thanks, Ard. >> -----Original Message----- >> From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >> Sent: Friday, June 1, 2018 3:06 AM >> To: Zeng, Star ; Yao, Jiewen >> Cc: edk2-devel@lists.01.org; leif.lindholm@linaro.org >> Subject: Re: [edk2] [PATCH] SignedCapsulePkg: add >> PcdLowestSupportedFirmwareVersion >> >> On 31 May 2018 at 11:12, Zeng, Star wrote: >> > It could be reused by platform SystemFirmwareDescriptor, for example. >> > >> Vlv2TbltDevicePkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwa >> reDescriptor.inf >> > >> QuarkPlatformPkg/Feature/Capsule/SystemFirmwareDescriptor/SystemFirmwa >> reDescriptor.inf >> > >> > So, I agree this patch, Reviewed-by: Star Zeng . >> > >> > Please also get Jiewen's RB for the patch. >> > >> >> @Jiewen, any comments? >> >> Thanks, >> Ard. >> >> >> > -----Original Message----- >> > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ard >> Biesheuvel >> > Sent: Thursday, May 31, 2018 5:02 PM >> > To: edk2-devel@lists.01.org >> > Cc: Yao, Jiewen ; Zeng, Star ; >> leif.lindholm@linaro.org; Ard Biesheuvel >> > Subject: [edk2] [PATCH] SignedCapsulePkg: add >> PcdLowestSupportedFirmwareVersion >> > >> > Add a PCD that holds the lowest supported version number, so that we can >> allow the platform to configure this at build time. >> > >> > Cc: Jiewen Yao >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Ard Biesheuvel >> > --- >> > As discussed a while ago: >> > https://lists.01.org/pipermail/edk2-devel/2018-March/022914.html >> > >> > SignedCapsulePkg/SignedCapsulePkg.dec | 4 ++++ >> > 1 file changed, 4 insertions(+) >> > >> > diff --git a/SignedCapsulePkg/SignedCapsulePkg.dec >> b/SignedCapsulePkg/SignedCapsulePkg.dec >> > index b27e87409b19..f06e07656de9 100644 >> > --- a/SignedCapsulePkg/SignedCapsulePkg.dec >> > +++ b/SignedCapsulePkg/SignedCapsulePkg.dec >> > @@ -52,6 +52,10 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, >> PcdsDynamic, PcdsDynamicEx] >> > # @Prompt GUID of the FFS which contains the Pkcs7TestPublicKeyFile. >> > >> gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiPkcs7TestPublicKeyFileGuid|{0xb >> a, 0xf5, 0x93, 0xf0, 0x37, 0x6f, 0x16, 0x48, 0x9e, 0x52, 0x91, 0xbe, 0xa0, 0xf7, >> 0xe0, 0xb8}|VOID*|0xA0010002 >> > >> > + ## This is the lowest supported version number that can be upgraded to, as >> exposed via the System Firmware descriptor. >> > + # @Prompt Lowest support version number that can be upgraded to via >> > + capsule update >> > + >> > + >> gEfiSignedCapsulePkgTokenSpaceGuid.PcdLowestSupportedFirmwareVersion|0 >> > + x1|UINT32|0xA0010003 >> > + >> > [PcdsDynamicEx] >> > ## This dynamic PCD holds the EDKII system firmware image descriptor. >> > # This information can be used for version check in EDKII system FMP >> capsule. >> > -- >> > 2.17.0 >> > >> > _______________________________________________ >> > edk2-devel mailing list >> > edk2-devel@lists.01.org >> > https://lists.01.org/mailman/listinfo/edk2-devel