From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4003:c06::243; helo=mail-oi0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-oi0-x243.google.com (mail-oi0-x243.google.com [IPv6:2607:f8b0:4003:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D6D74222CF1A3 for ; Mon, 22 Jan 2018 09:22:27 -0800 (PST) Received: by mail-oi0-x243.google.com with SMTP id t16so6468368oif.10 for ; Mon, 22 Jan 2018 09:27:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=6yOCA62Aj2kBlqIw/Ybrlxdaer2KPHPmhHmbQ1Q+Vt8=; b=WkBQq6+cqgcgdngfR1Aw0sofNfOLrd2nVYC65wxXCZfDN/r5Us+Rm+ZmVRRqOu84eH 373M7qjOm7IxTFUuHUfpUefrQF+cIqHVhkfKCYmQMFrCQbRybGvfoa2p4LiUxMuB3xuQ Q9E6/935j3gDzW9rzdgHMUWMPKXKZnNs7AZgE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=6yOCA62Aj2kBlqIw/Ybrlxdaer2KPHPmhHmbQ1Q+Vt8=; b=XRuZCRWEejMXc0UWabaxEvMp4B36FrdUhP4OfSvydHLn4P+l+5I4g24hzAJUAi0C2c ZWz/gbJR3BU6SVfwnci60ccVmqUZhZscFiX6Z9S8D6L1v/PhXjTNZHoCzTQ5uTWV53Q3 zrPX1pccYt58Jfkm6xUmFP58tFvXirf2scs99XszNeWmM6759m/8SCRxsFo0jGIur4NN wfGWz4lXRjyy++jJdv8ANJUw4NSEHpaI6O4P6D/KpP+2KFmgqF+AMFkg8vUgZ/bG//9k BKZvykgu+jFrps5A9Hn33Eg04hq46Y8AZ0mE0a9JM1A4niFLhfh1Av8pckFw8abrPcea CIlw== X-Gm-Message-State: AKwxytfBNWDuDmWh6RI4cZ+eVCVKA/2PaUMGiVUDpGj/OkS/Riz8f1+d mgZ70kdARE3e8HFjW8T7p6XTiAhMYAryZ5TI43WbYA== X-Google-Smtp-Source: AH8x227k56qN8qYsYuzVqDNRuwpq+JShB6wvarp0JkaG7mAKPiGhwKu0dj+NQ3X9540z3aieMI8RqU6S2xIlz/hwtK0= X-Received: by 10.202.225.212 with SMTP id y203mr4567209oig.64.1516642072774; Mon, 22 Jan 2018 09:27:52 -0800 (PST) MIME-Version: 1.0 Received: by 10.157.63.206 with HTTP; Mon, 22 Jan 2018 09:27:52 -0800 (PST) In-Reply-To: <20180122165905.10368-1-evan.lloyd@arm.com> References: <20180122165905.10368-1-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Mon, 22 Jan 2018 17:27:52 +0000 Message-ID: To: Evan Lloyd Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , <"ard.biesheuvel@linaro.org"@arm.com>, <"leif.lindholm@linaro.org"@arm.com>, <"Matteo.Carlini@arm.com"@arm.com>, <"Alexei.Fedorov@arm.com"@arm.com>, <"nd@arm.com"@arm.com> Subject: Re: [PATCH] Platform/ARM: Fix flash alignment access X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 22 Jan 2018 17:22:28 -0000 Content-Type: text/plain; charset="UTF-8" On 22 January 2018 at 16:59, wrote: > From: Alexei Fedorov > > Flash memory is mapped as device memory and should use only aligned > accesses. > Update VariableRuntimeDxe from using BaseMemoryLibOptDxe to the generic > BaseMemoryLib which provides aligned memory access only. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Alexei Fedorov > Signed-off-by: Evan Lloyd Reviewed-by: Ard Biesheuvel > --- > Platform/ARM/JunoPkg/ArmJuno.dsc | 1 + > Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc | 3 ++- > Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc | 1 + > 3 files changed, 4 insertions(+), 1 deletion(-) > > diff --git a/Platform/ARM/JunoPkg/ArmJuno.dsc b/Platform/ARM/JunoPkg/ArmJuno.dsc > index 5c2a29fe8330bbf308e31e34b617517a5aebcf6d..9d7317683ef39ab47429234b98d94c04953b41cb 100644 > --- a/Platform/ARM/JunoPkg/ArmJuno.dsc > +++ b/Platform/ARM/JunoPkg/ArmJuno.dsc > @@ -234,6 +234,7 @@ [Components.common] > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { > > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > } > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > index 1f612cc282eb8bf4fdc74ff0933c36ecf70c6daf..6c6c8d3938e61abf7456b4c2cd6b464c0238353b 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-CTA15-A7.dsc > @@ -1,5 +1,5 @@ > # > -# Copyright (c) 2012-2015, ARM Limited. All rights reserved. > +# Copyright (c) 2012-2017, ARM Limited. All rights reserved. > # Copyright (c) 2015, Intel Corporation. All rights reserved.
> # > # This program and the accompanying materials > @@ -215,6 +215,7 @@ [Components.common] > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { > > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > } > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > diff --git a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > index 3dbc105f6f8a565da34807508ac8178e4d524e41..295e9a126b0ebaa4653d7e25e2f7d8c396403764 100644 > --- a/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > +++ b/Platform/ARM/VExpressPkg/ArmVExpress-FVP-AArch64.dsc > @@ -224,6 +224,7 @@ [Components.common] > MdeModulePkg/Universal/Variable/RuntimeDxe/VariableRuntimeDxe.inf { > > NULL|MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf > + BaseMemoryLib|MdePkg/Library/BaseMemoryLib/BaseMemoryLib.inf > } > MdeModulePkg/Universal/FaultTolerantWriteDxe/FaultTolerantWriteDxe.inf > MdeModulePkg/Universal/MonotonicCounterRuntimeDxe/MonotonicCounterRuntimeDxe.inf > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >