From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: edk2-devel-01 <edk2-devel@lists.01.org>,
"Gao, Liming" <liming.gao@intel.com>,
Laszlo Ersek <lersek@redhat.com>,
Leif Lindholm <leif.lindholm@linaro.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Zhu, Yonghong" <yonghong.zhu@intel.com>,
stephano.cetola@linux.intel.com
Subject: BaseTools/ build broken due to unreviewed patch - PLEASE FIX
Date: Sat, 13 Oct 2018 10:17:59 +0200 [thread overview]
Message-ID: <CAKv+Gu_Z1Rx-fXtpziOZAEasNZJX__fsHroa=Euja95BcTjxFQ@mail.gmail.com> (raw)
Commit ea787b6b55499e8f931201f8f49daaaeb2e4409f
"BaseTools: update Test scripts support python3"
[which has never been sent out for review to the mailing list, as far
as I can tell] is breaking the BaseTools build
make -C Tests
make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests'
/bin/sh: 1: RunTests.py: not found
GNUmakefile:17: recipe for target 'test' failed
make[1]: *** [test] Error 127
make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests'
GNUmakefile:25: recipe for target 'Tests' failed
make: *** [Tests] Error 2
make: Leaving directory '/home/ard/build/edk2/BaseTools'
I tried reverting that patch alone, but that gives me
make -C Tests
make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests'
Traceback (most recent call last):
File "RunTests.py", line 36, in <module>
allTests = GetAllTestsSuite()
File "RunTests.py", line 33, in GetAllTestsSuite
return unittest.TestSuite([GetCTestSuite(), GetPythonTestSuite()])
File "RunTests.py", line 30, in GetPythonTestSuite
return PythonToolsTests.TheTestSuite()
File "/home/ard/build/edk2/BaseTools/Tests/PythonToolsTests.py",
line 27, in TheTestSuite
import CheckUnicodeSourceFiles
File "/home/ard/build/edk2/BaseTools/Tests/CheckUnicodeSourceFiles.py",
line 25, in <module>
from Common.Misc import PathClass
File "/home/ard/build/edk2/BaseTools/Source/Python/Common/Misc.py",
line 27, in <module>
from collections import UserDict as IterableUserDict
ImportError: cannot import name UserDict
GNUmakefile:17: recipe for target 'test' failed
make[1]: *** [test] Error 1
make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests'
GNUmakefile:25: recipe for target 'Tests' failed
make: *** [Tests] Error 2
make: Leaving directory '/home/ard/build/edk2/BaseTools'
Breaking the build for everyone with an unreviewed patch 2 days before
the plugfest is NOT OK.
Please fix or revert ASAP
(I suppose that the failing test is a false negative in this case, but
that is not really the point - my CI jobs are broken due to this and
so are many others, I imagine)
next reply other threads:[~2018-10-13 8:18 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-13 8:17 Ard Biesheuvel [this message]
2018-10-13 8:44 ` BaseTools/ build broken due to unreviewed patch - PLEASE FIX Gao, Liming
2018-10-13 8:46 ` Ard Biesheuvel
2018-10-13 8:57 ` Gao, Liming
2018-10-13 9:23 ` Gao, Liming
2018-10-13 12:18 ` Ard Biesheuvel
2018-10-13 15:12 ` Andrew Fish
2018-10-13 15:48 ` Gao, Liming
2018-10-13 9:22 ` Leif Lindholm
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAKv+Gu_Z1Rx-fXtpziOZAEasNZJX__fsHroa=Euja95BcTjxFQ@mail.gmail.com' \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox