From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::132; helo=mail-it1-x132.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x132.google.com (mail-it1-x132.google.com [IPv6:2607:f8b0:4864:20::132]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D7D321173C7A for ; Sat, 13 Oct 2018 01:18:00 -0700 (PDT) Received: by mail-it1-x132.google.com with SMTP id 74-v6so22135038itw.1 for ; Sat, 13 Oct 2018 01:18:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:from:date:message-id:subject:to; bh=R/4Pu+bEFqRCE1sGB6cHHeEfcSVqv/mCQNDI1mbM6WU=; b=d2VeoBg5kSOWwrip6C1nOSKjHQT01i6s4FFNer2Bi7GzMh/QqLe3LAs6nyLtlZNGXo lKk/PPJkqlP9Is7PumNkKo8wu0Miww/yoS6CAhNODr+AvSoQB7vF9IUnvlwi6jp062cn NgKQhHRv9A37pOMCMiv/jh2aSbgCFPi+rM2Bs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=R/4Pu+bEFqRCE1sGB6cHHeEfcSVqv/mCQNDI1mbM6WU=; b=YLxRWrr3myg4N3DqbzSQIbigNbkDUXonWJBWFXPSTyus97k4COrhpUfJGtXWNimuXa zjpIM+bCE0feOV6kTfxty+S45yHau+D2qTbCjJbmgitMq9E3vy84qVKeKGPI7pBYAWla 5rhItJDlpjsf+MlNN5LqPdCyUVtmvgxGKkBGE+YP+Shay+y0x0r9ZiMbj6a0b00vTb4W 8R19fuXz8yVJmzJ0j931kupPyEwfPQTx636gBFHil82Kof7pRRcwMNokfulp3yBZcWwo BXn5AeKaMjAfXUcbVKKXsxdeAPEz0v+R4F0uLo6a/ib2UN74yyYc85mJWzGz+bwLzv0q 4anQ== X-Gm-Message-State: ABuFfogNXSfXJyDhzMMQRS5tlqYfXVfQGDuvp21Ewa1kGQMCc7gnImGZ zsN2YRIhBDKS064tlWKaK8oeHQhe0lNsLgE6oSN2HjCWZas= X-Google-Smtp-Source: ACcGV63jhhvFhpVcutxrGffTBfsEx4vU85/Uxnz0RmpiJ5vg91Tbm0azaLZXxvX6quCRroZ4ckHj8NYzhGlI9QY3jMQ= X-Received: by 2002:a24:4ac5:: with SMTP id k188-v6mr7829026itb.158.1539418679608; Sat, 13 Oct 2018 01:17:59 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:5910:0:0:0:0:0 with HTTP; Sat, 13 Oct 2018 01:17:59 -0700 (PDT) From: Ard Biesheuvel Date: Sat, 13 Oct 2018 10:17:59 +0200 Message-ID: To: edk2-devel-01 , "Gao, Liming" , Laszlo Ersek , Leif Lindholm , "Kinney, Michael D" , "Zhu, Yonghong" , stephano.cetola@linux.intel.com Subject: BaseTools/ build broken due to unreviewed patch - PLEASE FIX X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 08:18:01 -0000 Content-Type: text/plain; charset="UTF-8" Commit ea787b6b55499e8f931201f8f49daaaeb2e4409f "BaseTools: update Test scripts support python3" [which has never been sent out for review to the mailing list, as far as I can tell] is breaking the BaseTools build make -C Tests make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' /bin/sh: 1: RunTests.py: not found GNUmakefile:17: recipe for target 'test' failed make[1]: *** [test] Error 127 make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' GNUmakefile:25: recipe for target 'Tests' failed make: *** [Tests] Error 2 make: Leaving directory '/home/ard/build/edk2/BaseTools' I tried reverting that patch alone, but that gives me make -C Tests make[1]: Entering directory '/home/ard/build/edk2/BaseTools/Tests' Traceback (most recent call last): File "RunTests.py", line 36, in allTests = GetAllTestsSuite() File "RunTests.py", line 33, in GetAllTestsSuite return unittest.TestSuite([GetCTestSuite(), GetPythonTestSuite()]) File "RunTests.py", line 30, in GetPythonTestSuite return PythonToolsTests.TheTestSuite() File "/home/ard/build/edk2/BaseTools/Tests/PythonToolsTests.py", line 27, in TheTestSuite import CheckUnicodeSourceFiles File "/home/ard/build/edk2/BaseTools/Tests/CheckUnicodeSourceFiles.py", line 25, in from Common.Misc import PathClass File "/home/ard/build/edk2/BaseTools/Source/Python/Common/Misc.py", line 27, in from collections import UserDict as IterableUserDict ImportError: cannot import name UserDict GNUmakefile:17: recipe for target 'test' failed make[1]: *** [test] Error 1 make[1]: Leaving directory '/home/ard/build/edk2/BaseTools/Tests' GNUmakefile:25: recipe for target 'Tests' failed make: *** [Tests] Error 2 make: Leaving directory '/home/ard/build/edk2/BaseTools' Breaking the build for everyone with an unreviewed patch 2 days before the plugfest is NOT OK. Please fix or revert ASAP (I suppose that the failing test is a false negative in this case, but that is not really the point - my CI jobs are broken due to this and so are many others, I imagine)