Re: [PATCH edk2-platforms] Platform/OverdriveBoard: move device tree compilation into build

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 29 August 2017 at 20:26, Alan Ott <alan@softiron.com> wrote:
> On 08/29/2017 12:27 PM, Ard Biesheuvel wrote:
>>
>> Use the proposed BaseTools support for device tree compilation to
>> build the device tree binary from source at build time. Give it its
>> own .inf and a build rule so the tools take care of everything.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>> ---
>>   Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dtb
>> | Bin 9357 -> 0 bytes
>>   Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dts
>> | 510 --------------------
>>   Platform/AMD/OverdriveBoard/OverdriveBoard.dsc
>> |   1 +
>>   Platform/AMD/OverdriveBoard/OverdriveBoard.fdf
>> |   9 +-
>>
>> Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts
>> | 487 +++++++++++++++++++
>>
>> Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf
>> |  28 ++
>>   6 files changed, 521 insertions(+), 514 deletions(-)
>
>
> I like this in principle, but what's the 23 line difference in the DTS
> and/or should it be in a separate patch from the patch that moves the file
> so the difference is clear?
>

Yeah, fair point. Once the upstream prerequisite patch is merged, I
will split this into 2 or 3 patches.