From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x22e.google.com (mail-it0-x22e.google.com [IPv6:2607:f8b0:4001:c0b::22e]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7D51621E70D31 for ; Tue, 29 Aug 2017 12:25:52 -0700 (PDT) Received: by mail-it0-x22e.google.com with SMTP id o132so4871578itc.1 for ; Tue, 29 Aug 2017 12:28:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Ed06/fWTi6nA6QIggGnZdMK2ekoElxD9wDifjDN0pSo=; b=CnV4nVD/81tD9b+lmp8o+5LHzQ4zEjd54dB8A/k094m3P876XIN9mrgDoeEmnLpLSq str8a6fJWW21SKZDuGZbzZJl7V20Berarcxw+0+/DficQh1NgCncv5bF/hWGPnA2IK+C ur4F40Hr0jmCTWvKOruq2lhTXFlQNtA/74v9s= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Ed06/fWTi6nA6QIggGnZdMK2ekoElxD9wDifjDN0pSo=; b=nQiJL8pDL/RxaWiqWx5EAiEhNlIYO45SNQTN/+SaUAfAjtNlxfKW2i1ZbNkM8HYlTF YoxqceGd6/AckN24PNZHotEEutF2GM/sE2WjHCcDYFhnyyq4Lwosvf2G387o3PcKXKr3 gZW++lBObheihKoShc4etXwPJaajpFJJ4UNkOoi9lN86OLWrm0vhjSCEbyd/vQ4pBADX 0HKSNAZabY7lIC9/65OovuTzs3SlA4KQJpFkR9uDl9NjJAtZzjd7eFmEIDceK6q6OTpT LdSbGBUxODsd/w96ios2Vn45QVOaJpmCJMvh78k4mzgbeHxYZ9j6ANjeh2VNZjrspqUq TxvA== X-Gm-Message-State: AHYfb5gXfF/5se3jd7gf8SUvvqPrwhDGDCeMMn80IpYYTb6fb7akwSQc 5PLnHKbhtwEpU70rlp5giyppiWYVVFsj X-Received: by 10.36.91.195 with SMTP id g186mr5096075itb.63.1504034912425; Tue, 29 Aug 2017 12:28:32 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.162.1 with HTTP; Tue, 29 Aug 2017 12:28:31 -0700 (PDT) In-Reply-To: References: <20170829162751.25226-1-ard.biesheuvel@linaro.org> From: Ard Biesheuvel Date: Tue, 29 Aug 2017 20:28:31 +0100 Message-ID: To: Alan Ott Cc: "edk2-devel@lists.01.org" , Leif Lindholm , "Gao, Liming" , "Zhu, Yonghong" Subject: Re: [PATCH edk2-platforms] Platform/OverdriveBoard: move device tree compilation into build X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 29 Aug 2017 19:25:52 -0000 Content-Type: text/plain; charset="UTF-8" On 29 August 2017 at 20:26, Alan Ott wrote: > On 08/29/2017 12:27 PM, Ard Biesheuvel wrote: >> >> Use the proposed BaseTools support for device tree compilation to >> build the device tree binary from source at build time. Give it its >> own .inf and a build rule so the tools take care of everything. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Ard Biesheuvel >> --- >> Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dtb >> | Bin 9357 -> 0 bytes >> Platform/AMD/OverdriveBoard/FdtBlob/styx-overdrive.dts >> | 510 -------------------- >> Platform/AMD/OverdriveBoard/OverdriveBoard.dsc >> | 1 + >> Platform/AMD/OverdriveBoard/OverdriveBoard.fdf >> | 9 +- >> >> Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.dts >> | 487 +++++++++++++++++++ >> >> Platform/AMD/OverdriveBoard/OverdriveBoardDeviceTree/OverdriveBoardDeviceTree.inf >> | 28 ++ >> 6 files changed, 521 insertions(+), 514 deletions(-) > > > I like this in principle, but what's the 23 line difference in the DTS > and/or should it be in a separate patch from the patch that moves the file > so the difference is clear? > Yeah, fair point. Once the upstream prerequisite patch is merged, I will split this into 2 or 3 patches.