From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22a.google.com (mail-io0-x22a.google.com [IPv6:2607:f8b0:4001:c06::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id EC53221DFA8F2 for ; Thu, 6 Apr 2017 13:32:38 -0700 (PDT) Received: by mail-io0-x22a.google.com with SMTP id t68so4035567iof.0 for ; Thu, 06 Apr 2017 13:32:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=dH/p199gS2m8A27X/d8RpBexMHt6LHFAp4bSmIWXiCQ=; b=OfhEhGevWNNxpdt/bu7f0I3jnIxmXpWHHLJ2Brlo9jLhCSAHlny65kML5EquyRiC1v 3hWNFcwNOts8gJN/aB7BAJr+ATCnuvxElNO1LXAxf7H70HLnz89apiDUD7+dFMkR3AvX TU6irazpw6sF8QlJ8Swdf36cvb8QvadG/MfGk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=dH/p199gS2m8A27X/d8RpBexMHt6LHFAp4bSmIWXiCQ=; b=o0F85NvF5+yOrI8XUbbRelfrU697R8OaAuWKbJQg6jsr8za6LVfDOyWVk4wsxaEq91 +BPmkzQXB8PyJX00NEpGyrSXdhXshKawuVJWS6bDrGSfkYGdZ3FuBhxwPH5tD0vSmkua Xwn+CQzaebZV3qvx9twTFfgQE+9DZqzcqHhvQ0gN1q/rfteCUx4ysSPTuEtASDjlJSb4 KEQsH89kAR/gpfd+CwHFViMsfGpqS6yGFZ6kfsyiQXdMVBd1d+sTp05t5p+gNRqGqX/s I74HVK3687akqQ7EYDkQMYyPDzzYOD/hV8L/uG9C10qFdhS7yVP9Ylwh/OFqH/KmqFKL S8OA== X-Gm-Message-State: AFeK/H3rSus1eXHaJ6fClHNe2jzAPrbpzuYmOnP6F1W2lYF41Q/hag7ZjjXrbg+WXlH6BE48hUWvUfDgZiLvIE9k X-Received: by 10.107.132.155 with SMTP id o27mr33786703ioi.138.1491510758294; Thu, 06 Apr 2017 13:32:38 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.149.5 with HTTP; Thu, 6 Apr 2017 13:32:37 -0700 (PDT) In-Reply-To: <20170406182904.GL25239@bivouac.eciton.net> References: <20170406131551.3322-1-ard.biesheuvel@linaro.org> <20170406182904.GL25239@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 6 Apr 2017 21:32:37 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Ryan Harkin , Evan Lloyd , Jeremy Linton Subject: Re: [PATCH v2 0/5] ArmPlatformPkg: map VRAM using memory semantics X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 06 Apr 2017 20:32:39 -0000 Content-Type: text/plain; charset=UTF-8 On 6 April 2017 at 19:29, Leif Lindholm wrote: > On Thu, Apr 06, 2017 at 02:15:46PM +0100, Ard Biesheuvel wrote: >> As reported by Jeremy, the recently introduced accelerated memcpy/memset >> routines are causing problems when used on framebuffer memory. While >> framebuffers are arguably right on the blurry line between MMIO (with >> side effects that are sensitive to ordering) and memory, mapping VRAM >> as device memory is unnecessary to begin with, and so we can improve >> our situation by using memory semantics for the VRAM mappings. (Whether >> we end up reverting to the unaccelerated memcpy/memset routines is a >> separate matter) >> >> So fix both the FVP case, which has a separate VRAM region, and TC2, which >> allocates VRAM from normal memory and changes the mapping attributes. > > For 2-5/5: > Reviewed-by: Leif Lindholm > Thanks all. Pushed.