public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
To: Hao A Wu <hao.a.wu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>,
	Ray Ni <ray.ni@intel.com>,
	 Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH v1 1/2] EmbeddedPkg DSC: Use ReportStatusCodeLib (DXE) in MdeModulePkg
Date: Fri, 17 May 2019 17:50:30 +0200	[thread overview]
Message-ID: <CAKv+Gu_ZwZSFuNRJTB6NUKygrofBSZ5JwnwO1LmHU99VSCc7kA@mail.gmail.com> (raw)
In-Reply-To: <20190514073343.11872-2-hao.a.wu@intel.com>

On Tue, 14 May 2019 at 09:33, Hao A Wu <hao.a.wu@intel.com> wrote:
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1720
>
> This commit will update the package DSC file to consume the
> ReportStatusCodeLib (DXE phase instance) in MdeModulePkg, instead of using
> the one in IntelFrameworkModulePkg.
>
> Please note that, the 2 ReportStatusCodeLib are almost identical. Thus,
> there is no functional impact for this commit.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>

Can we use the NULL status code library here?

> ---
>  EmbeddedPkg/EmbeddedPkg.dsc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> index b8b6ac90c0..b487337909 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> @@ -105,16 +105,16 @@
>
>  [LibraryClasses.common.DXE_DRIVER]
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>
>
>  [LibraryClasses.common.UEFI_APPLICATION]
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>
>  [LibraryClasses.common.UEFI_DRIVER]
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>
>  [LibraryClasses.common.SEC]
>    ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
> --
> 2.12.0.windows.1
>

  reply	other threads:[~2019-05-17 15:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-14  7:33 [PATCH v1 0/2] EmbeddedPkg: Drop IntelFramework[Module]Pkg dependency Wu, Hao A
2019-05-14  7:33 ` [PATCH v1 1/2] EmbeddedPkg DSC: Use ReportStatusCodeLib (DXE) in MdeModulePkg Wu, Hao A
2019-05-17 15:50   ` Ard Biesheuvel [this message]
2019-05-17 15:56     ` Ard Biesheuvel
2019-05-14  7:33 ` [PATCH v1 2/2] EmbeddedPkg/PrePiLib: Drop dependency on IntelFramework[Module]Pkg Wu, Hao A
2019-05-14  9:20 ` [PATCH v1 0/2] EmbeddedPkg: Drop IntelFramework[Module]Pkg dependency Ni, Ray
2019-05-14 15:27 ` Leif Lindholm
2019-05-15  8:32   ` Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_ZwZSFuNRJTB6NUKygrofBSZ5JwnwO1LmHU99VSCc7kA@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox