From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=Jt6E8TU9;
 spf=pass (domain: linaro.org, ip: 209.85.166.68, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-io1-f68.google.com (mail-io1-f68.google.com [209.85.166.68])
 by groups.io with SMTP; Fri, 17 May 2019 08:50:43 -0700
Received: by mail-io1-f68.google.com with SMTP id g84so5883583ioa.1
        for <devel@edk2.groups.io>; Fri, 17 May 2019 08:50:42 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=4xx78xqu7ZGp28i1YIxPJc1me8sWnRBWsLHBkl+4Wpg=;
        b=Jt6E8TU98ArP4L8TLHDkbKScKLa2XeYRKqgx+7DOCp3Or5fc9cB2VDNe5kILi+3BuC
         Ys+lMlHAOPSYY/7EBN2CF4xphWUKiz4vRgBSNoNB+CXn2iuvaNn9/5kvPmnP3aKJt5M3
         cbBSDyyg0PiMBlnLPkKGX4oxBzBqzMTWlGAJdrctbzkGptB2lk4lQDOJvXJOWUXEBzfS
         G5tVzq4gD+1NcNVd54mHeznwExLL9JFmqRHacofMZ4jkCkvDRM/szuwoaGnW5PUwnxYn
         v8kdFq3CzOAggAsTj2IJLnVM5AnD+8ekpwh/rCxJw9FuNIjtFTUebC0mlZwsNwO1xGow
         MtMA==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=4xx78xqu7ZGp28i1YIxPJc1me8sWnRBWsLHBkl+4Wpg=;
        b=C+lSmA7ZIhoCiA4tfo2u8daZR+7x6KcU3OU4adyrLeLdrmMCM21LddxYjcUoP3riqX
         2zdChPAYujRLBl+tNCF70JcwfXBHtBB2fSAa5CEhizl0irURJkxbfrIGI7AInD4XZfKF
         7jnXS8ehEjf0UnrrXB5fGg940Gzr8+nNEe21HXDAoh9my23fdmJka8aJapUKIptXnx4N
         WpGjxSq2Ro7dEijtkom4XAB9E43rsDUkmgPkTb9s2pQerAsAibfGYHn4HX/btW3zzvrI
         A3/M67MWUAzYjWlr8qX4yDUhd3JK9D3ASWkQIHMGAlFCQzUpEgFNQV+s/+qOWN0nirkh
         p3kA==
X-Gm-Message-State: APjAAAU967oXZ87RYYoIh9/GXLmowhde+HIrvYYQu/E1NRuKH6cyg//1
	ECGhIPMDVhxhWnH/wjhALR6VY4PmhsCCojWLiA9JQA==
X-Google-Smtp-Source: APXvYqzMjhUd0psRTIkbwA2ooeAMEDzOhol8eWl4LfRLWLued+IXTjNk/eyEOF9xb6KTo+FGx0OGKSVt1pyeVGHpYSQ=
X-Received: by 2002:a05:6602:2109:: with SMTP id x9mr10132353iox.128.1558108242442;
 Fri, 17 May 2019 08:50:42 -0700 (PDT)
MIME-Version: 1.0
References: <20190514073343.11872-1-hao.a.wu@intel.com> <20190514073343.11872-2-hao.a.wu@intel.com>
In-Reply-To: <20190514073343.11872-2-hao.a.wu@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Fri, 17 May 2019 17:50:30 +0200
Message-ID: <CAKv+Gu_ZwZSFuNRJTB6NUKygrofBSZ5JwnwO1LmHU99VSCc7kA@mail.gmail.com>
Subject: Re: [PATCH v1 1/2] EmbeddedPkg DSC: Use ReportStatusCodeLib (DXE) in MdeModulePkg
To: Hao A Wu <hao.a.wu@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Ray Ni <ray.ni@intel.com>, 
	Leif Lindholm <leif.lindholm@linaro.org>
Content-Type: text/plain; charset="UTF-8"

On Tue, 14 May 2019 at 09:33, Hao A Wu <hao.a.wu@intel.com> wrote:
>
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=1720
>
> This commit will update the package DSC file to consume the
> ReportStatusCodeLib (DXE phase instance) in MdeModulePkg, instead of using
> the one in IntelFrameworkModulePkg.
>
> Please note that, the 2 ReportStatusCodeLib are almost identical. Thus,
> there is no functional impact for this commit.
>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Signed-off-by: Hao A Wu <hao.a.wu@intel.com>

Can we use the NULL status code library here?

> ---
>  EmbeddedPkg/EmbeddedPkg.dsc | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/EmbeddedPkg/EmbeddedPkg.dsc b/EmbeddedPkg/EmbeddedPkg.dsc
> index b8b6ac90c0..b487337909 100644
> --- a/EmbeddedPkg/EmbeddedPkg.dsc
> +++ b/EmbeddedPkg/EmbeddedPkg.dsc
> @@ -105,16 +105,16 @@
>
>  [LibraryClasses.common.DXE_DRIVER]
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>
>
>  [LibraryClasses.common.UEFI_APPLICATION]
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>
>  [LibraryClasses.common.UEFI_DRIVER]
>    PcdLib|MdePkg/Library/DxePcdLib/DxePcdLib.inf
> -  ReportStatusCodeLib|IntelFrameworkModulePkg/Library/DxeReportStatusCodeLibFramework/DxeReportStatusCodeLib.inf
> +  ReportStatusCodeLib|MdeModulePkg/Library/DxeReportStatusCodeLib/DxeReportStatusCodeLib.inf
>
>  [LibraryClasses.common.SEC]
>    ExtractGuidedSectionLib|EmbeddedPkg/Library/PrePiExtractGuidedSectionLib/PrePiExtractGuidedSectionLib.inf
> --
> 2.12.0.windows.1
>