Re: [PATCH] Platform/ARM: Correct LevelID in PLPI packages of DSDT

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 10 July 2018 at 13:55, Evan Lloyd <Evan.Lloyd@arm.com> wrote:
> Reviewed-by: Evan Lloyd <evan.lloyd@arm.com>
>
>> -----Original Message-----
>> From: AlexeiFedorov <Alexei.Fedorov@arm.com>
>> Sent: 04 July 2018 14:05
>> To: edk2-devel@lists.01.org
>> Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>; Thomas Abraham
>> <thomas.abraham@arm.com>; Ard.Biesheuvel@linaro.org;
>> Leif.Lindholm@linaro.org; Matteo Carlini <Matteo.Carlini@arm.com>;
>> Stephanie Hughes-Fitt <Stephanie.Hughes-Fitt@arm.com>; nd
>> <nd@arm.com>; Thomas Abraham <thomas.abraham@arm.com>; Evan
>> Lloyd <Evan.Lloyd@arm.com>; Sami Mujawar <Sami.Mujawar@arm.com>
>> Subject: [PATCH] Platform/ARM: Correct LevelID in PLPI packages of DSDT
>>
>> From: Alexei Fedorov <alexei.fedorov@arm.com>
>>
>> Juno's DSDT contains 2 PLPI packages in Clusters #0 and #1 and _OSC method
>> reports support for platform coordinated mode only.
>> According to the description of LevelID field in ACPI 6.2 Errata A Specification
>> #8.4.4.3, "In a platform that only supports platform coordinated mode, this
>> field must be 0."
>>
>> This patch fixes the above issue by changing value of LevelID fields from 1 to
>> 0.
>>
>> Contributed-under: TianoCore Contribution Agreement 1.1
>> Signed-off-by: Alexei Fedorov <Alexei.Fedorov@arm.com>

Thanks all

Pushed as 5ba6b64686bf

>> ---
>> All the changes can be reviewed at:
>> https://github.com/AlexeiFedorov/edk2-
>> platforms/tree/282_correct_levelid_v1
>>
>> Notes:
>>     v1:
>>     - Change LevelID Value of PLPI package from 1 to 0.
>>
>>  Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 6 +++---
>>  1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
>> b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
>> index
>> 07e32bae21f891461fde0183028e4c0f817e45a7..702b057757457fee40ddfc10
>> e91d38c5dd7ca0b8 100644
>> --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
>> +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl
>> @@ -1,7 +1,7 @@
>>  /** @file
>>    Differentiated System Description Table Fields (DSDT)
>>
>> -  Copyright (c) 2014-2015, ARM Ltd. All rights reserved.<BR>
>> +  Copyright (c) 2014-2018, ARM Ltd. All rights reserved.<BR>
>>      This program and the accompanying materials
>>    are licensed and made available under the terms and conditions of the BSD
>> License
>>    which accompanies this distribution.  The full text of the license may be
>> found at @@ -65,7 +65,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1,
>> "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
>>        })
>>        Name(PLPI, Package() {
>>          0, // Version
>> -        1, // Level Index
>> +        0, // Level Index
>>          2, // Count
>>          Package() { // WFI for CPU
>>            1, // Min residency (uS)
>> @@ -157,7 +157,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1,
>> "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O
>>        })
>>        Name(PLPI, Package() {
>>          0, // Version
>> -        1, // Level Index
>> +        0, // Level Index
>>          2, // Count
>>          Package() { // WFI for CPU
>>            1, // Min residency (uS)
>> --
>> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)'
>>
>