From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::242; helo=mail-it0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x242.google.com (mail-it0-x242.google.com [IPv6:2607:f8b0:4001:c0b::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 72D0C20337350 for ; Wed, 11 Jul 2018 00:22:55 -0700 (PDT) Received: by mail-it0-x242.google.com with SMTP id y124-v6so17010284itc.0 for ; Wed, 11 Jul 2018 00:22:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=uR0BBs3aC/nQCHvi5/8YqYhGZyQ7jdxryL0KbDiItmk=; b=cdvuQhDIWNqmjN024Hh913xJtW32NB/SNIpyI9v5Qw9p7oVdMD7PtpbWdvUE2LaGCr zpxfI2+w8Kxs54vucGRonCpatkarQmanSkGPrAxXJoVk+kwmEDeqaBhYmY9EMYr0XMTY IxLVFs6BPVY/1gIu1N7RPDALUzGTpjGKLl2dc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=uR0BBs3aC/nQCHvi5/8YqYhGZyQ7jdxryL0KbDiItmk=; b=qS58ZXIrWRflAttNxcyOMxI4iQil9F+H56p7m8reXRQhnPXe/w2meJYKmK2/JIi8ms lSENMwseDIODGspt1PbtPM6IQI1OwqWzu3CT4Ta/3CFEOrizAFToA2nFxDAZfRqOuSls Qmi+KbVEBlBTVmT7PjlRZKD/Tu6wenGXMpNkOXGv93MjPHwvAzc6QJkNvpmqhvm/0uUz WjVgFfRh0kctiMueoP68oKGe0b78qYO7n49jfY2VBT38ody/sIqxEI+SszRBQzKQMzfl S+nccSWayQZk9ZUVWKSTXBqAj4BfcUwg5dKBcd/mGBuT1j4AQr10YTgS6js529GNfeTn XR6w== X-Gm-Message-State: APt69E16EQyD6akkWUwgEXdsepojPx5gOJ6JdCsgGbyK3oiNJ+AZ8hlg gcxKtUr8bgtrQGdqA4OfrXH4MuFLDhSe3Aq450KJ8s3njec= X-Google-Smtp-Source: AAOMgpfd40vLH+kc/W4KWKuIhEalVRY6u/ctE52+giJbZQavdAuqmZeAPzTvtO7zD0LvpcvVaEhGEEtYe0tk9qqoRYk= X-Received: by 2002:a24:64d6:: with SMTP id t205-v6mr22102716itc.138.1531293774725; Wed, 11 Jul 2018 00:22:54 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Wed, 11 Jul 2018 00:22:54 -0700 (PDT) In-Reply-To: References: <20180704130440.32480-1-Alexei.Fedorov@arm.com> From: Ard Biesheuvel Date: Wed, 11 Jul 2018 09:22:54 +0200 Message-ID: To: Evan Lloyd Cc: Alexei Fedorov , "edk2-devel@lists.01.org" , Arvind Chauhan , Thomas Abraham , "Leif.Lindholm@linaro.org" , Matteo Carlini , Stephanie Hughes-Fitt , nd , Sami Mujawar Subject: Re: [PATCH] Platform/ARM: Correct LevelID in PLPI packages of DSDT X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 Jul 2018 07:22:55 -0000 Content-Type: text/plain; charset="UTF-8" On 10 July 2018 at 13:55, Evan Lloyd wrote: > Reviewed-by: Evan Lloyd > >> -----Original Message----- >> From: AlexeiFedorov >> Sent: 04 July 2018 14:05 >> To: edk2-devel@lists.01.org >> Cc: Arvind Chauhan ; Thomas Abraham >> ; Ard.Biesheuvel@linaro.org; >> Leif.Lindholm@linaro.org; Matteo Carlini ; >> Stephanie Hughes-Fitt ; nd >> ; Thomas Abraham ; Evan >> Lloyd ; Sami Mujawar >> Subject: [PATCH] Platform/ARM: Correct LevelID in PLPI packages of DSDT >> >> From: Alexei Fedorov >> >> Juno's DSDT contains 2 PLPI packages in Clusters #0 and #1 and _OSC method >> reports support for platform coordinated mode only. >> According to the description of LevelID field in ACPI 6.2 Errata A Specification >> #8.4.4.3, "In a platform that only supports platform coordinated mode, this >> field must be 0." >> >> This patch fixes the above issue by changing value of LevelID fields from 1 to >> 0. >> >> Contributed-under: TianoCore Contribution Agreement 1.1 >> Signed-off-by: Alexei Fedorov Thanks all Pushed as 5ba6b64686bf >> --- >> All the changes can be reviewed at: >> https://github.com/AlexeiFedorov/edk2- >> platforms/tree/282_correct_levelid_v1 >> >> Notes: >> v1: >> - Change LevelID Value of PLPI package from 1 to 0. >> >> Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl | 6 +++--- >> 1 file changed, 3 insertions(+), 3 deletions(-) >> >> diff --git a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl >> b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl >> index >> 07e32bae21f891461fde0183028e4c0f817e45a7..702b057757457fee40ddfc10 >> e91d38c5dd7ca0b8 100644 >> --- a/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl >> +++ b/Platform/ARM/JunoPkg/AcpiTables/Dsdt.asl >> @@ -1,7 +1,7 @@ >> /** @file >> Differentiated System Description Table Fields (DSDT) >> >> - Copyright (c) 2014-2015, ARM Ltd. All rights reserved.
>> + Copyright (c) 2014-2018, ARM Ltd. All rights reserved.
>> This program and the accompanying materials >> are licensed and made available under the terms and conditions of the BSD >> License >> which accompanies this distribution. The full text of the license may be >> found at @@ -65,7 +65,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, >> "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O >> }) >> Name(PLPI, Package() { >> 0, // Version >> - 1, // Level Index >> + 0, // Level Index >> 2, // Count >> Package() { // WFI for CPU >> 1, // Min residency (uS) >> @@ -157,7 +157,7 @@ DefinitionBlock("DsdtTable.aml", "DSDT", 1, >> "ARMLTD", "ARM-JUNO", EFI_ACPI_ARM_O >> }) >> Name(PLPI, Package() { >> 0, // Version >> - 1, // Level Index >> + 0, // Level Index >> 2, // Count >> Package() { // WFI for CPU >> 1, // Min residency (uS) >> -- >> 'Guid(CE165669-3EF3-493F-B85D-6190EE5B9759)' >> >