From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::244; helo=mail-io0-x244.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x244.google.com (mail-io0-x244.google.com [IPv6:2607:f8b0:4001:c06::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 85E50202E53FD for ; Mon, 18 Jun 2018 08:53:54 -0700 (PDT) Received: by mail-io0-x244.google.com with SMTP id s26-v6so17271004ioj.4 for ; Mon, 18 Jun 2018 08:53:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=L9eHm88bogFeQLXIeHkjLNrBGbGZ+xmOfsp2E4s1MfY=; b=H6pQfzEjWo3kCAaodcYeaQlw3f4reAj6YYA7Y+Lp2DW0/VuHRjwQxMoibffXOZfboX Njo6dMTqQaaIehBgBfL2sm8nrYc5U0kOjOePvGfC49s/KjlppxT10/rAVTmrLB+ceCEl JslR6jn0S1wnl7gBxEl7DUeTMDP4QmRldvuHk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=L9eHm88bogFeQLXIeHkjLNrBGbGZ+xmOfsp2E4s1MfY=; b=o1b3xSlW28j0dMR6ZxDYrdRcIAHVriuWwWmBFMHUoyxyHU1eu2bbLlDb+h7TRsyFJy vvAc/MGsjdCwRVZIvCHxGjX/A2nLiVZLzuoL7UvUcXrzizNnLKLMBXGW2BdsnWa0v3ds 93KrgXUkZtm3T/DZyt/KgyjkUcE5BzvXmicdnAGe5u5k1i55sBn1E/7rRLdVmK5ZnZOG M0Hl5fhGhn98ho3QHE8VyXACFASzgX9GMd8aYVwexRZMNG00NnDE38lAU09QD2yW2b2l gqGBN+Qr4YQceM0OiMwrg/RP9Qix0Jc5uya2F7viFyIqCDyGdLkkdxHAYSA5jTpV5Gjn F+yQ== X-Gm-Message-State: APt69E0Ql526Opvm05DZjE6v6PrxPnLAMXgGa0VnRQI4a0NERLMplzpN DPkFNcwzwrH+pR6RutU3S2sn35lpqvM2x3qsYpjw8A== X-Google-Smtp-Source: ADUXVKJ/n8SEaZ2N5Vrsqjch1t/0K7Q5ZLNqIqNL4oahNglV4gdKVm1l6dkkCp9Ah/B/f1lcvBOafVMPVczVwWchP3w= X-Received: by 2002:a6b:6709:: with SMTP id b9-v6mr10234228ioc.170.1529337233778; Mon, 18 Jun 2018 08:53:53 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Mon, 18 Jun 2018 08:53:53 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E29839E@SHSMSX104.ccr.corp.intel.com> References: <20180618082748.30067-1-ard.biesheuvel@linaro.org> <66c6420b-b874-4ac0-880b-3e83f63ef81b@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E29839E@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Mon, 18 Jun 2018 17:53:53 +0200 Message-ID: To: "Gao, Liming" Cc: Laszlo Ersek , "edk2-devel@lists.01.org" Subject: Re: [PATCH] BaseTools/tools_def IA32: drop -no-pie linker option for GCC49 X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 18 Jun 2018 15:53:54 -0000 Content-Type: text/plain; charset="UTF-8" On 18 June 2018 at 16:47, Gao, Liming wrote: > Our build machine uses GCC4.9.2. I expect GCC49 can work on all GCC49 version. > > Reviewed-by: Liming Gao > Thanks Pushed as 11d0cd23dd1bc15a6e6a1598250ea2e0c4c36e9a >> -----Original Message----- >> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek >> Sent: Monday, June 18, 2018 8:44 PM >> To: Ard Biesheuvel ; edk2-devel@lists.01.org >> Cc: Gao, Liming >> Subject: Re: [edk2] [PATCH] BaseTools/tools_def IA32: drop -no-pie linker option for GCC49 >> >> On 06/18/18 10:27, Ard Biesheuvel wrote: >> > As reported by Liming, GCC 4.9.2 does not support the -no-pie >> > linker option that we added to the GCC49 and GCC5 toolchain >> > profiles in commit c25d3905523a ("BaseTools/tools_def IA32: >> > disable PIE code generation explicitly") to work around issues >> > with recent distro toolchains that enable PIE code generation >> > by default. >> > >> > So rollback the changes for GCC49 but preserve them for GCC5 >> > >> > Contributed-under: TianoCore Contribution Agreement 1.1 >> > Signed-off-by: Ard Biesheuvel >> > --- >> > BaseTools/Conf/tools_def.template | 8 ++++---- >> > 1 file changed, 4 insertions(+), 4 deletions(-) >> > >> > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template >> > index 733c6ec71709..ab57f9c706e3 100755 >> > --- a/BaseTools/Conf/tools_def.template >> > +++ b/BaseTools/Conf/tools_def.template >> > @@ -4648,7 +4648,7 @@ DEFINE GCC48_AARCH64_DLINK2_FLAGS = DEF(GCC47_AARCH64_DLINK2_FLAGS) >> > DEFINE GCC48_ARM_ASLDLINK_FLAGS = DEF(GCC47_ARM_ASLDLINK_FLAGS) >> > DEFINE GCC48_AARCH64_ASLDLINK_FLAGS = DEF(GCC47_AARCH64_ASLDLINK_FLAGS) >> > >> > -DEFINE GCC49_IA32_CC_FLAGS = DEF(GCC48_IA32_CC_FLAGS) -fno-pic -fno-pie >> > +DEFINE GCC49_IA32_CC_FLAGS = DEF(GCC48_IA32_CC_FLAGS) >> > DEFINE GCC49_X64_CC_FLAGS = DEF(GCC48_X64_CC_FLAGS) >> > DEFINE GCC49_IA32_X64_DLINK_COMMON = -nostdlib -Wl,-n,-q,--gc-sections -z common-page-size=0x40 >> > DEFINE GCC49_IA32_X64_ASLDLINK_FLAGS = DEF(GCC49_IA32_X64_DLINK_COMMON) -Wl,--entry,ReferenceAcpiTable -u >> ReferenceAcpiTable >> > @@ -4670,7 +4670,7 @@ DEFINE GCC49_AARCH64_DLINK2_FLAGS = DEF(GCC48_AARCH64_DLINK2_FLAGS) >> > DEFINE GCC49_ARM_ASLDLINK_FLAGS = DEF(GCC48_ARM_ASLDLINK_FLAGS) >> > DEFINE GCC49_AARCH64_ASLDLINK_FLAGS = DEF(GCC48_AARCH64_ASLDLINK_FLAGS) >> > >> > -DEFINE GCC5_IA32_CC_FLAGS = DEF(GCC49_IA32_CC_FLAGS) >> > +DEFINE GCC5_IA32_CC_FLAGS = DEF(GCC49_IA32_CC_FLAGS) -fno-pic -fno-pie >> > DEFINE GCC5_X64_CC_FLAGS = DEF(GCC49_X64_CC_FLAGS) >> > DEFINE GCC5_IA32_X64_DLINK_COMMON = DEF(GCC49_IA32_X64_DLINK_COMMON) >> > DEFINE GCC5_IA32_X64_ASLDLINK_FLAGS = DEF(GCC49_IA32_X64_ASLDLINK_FLAGS) >> > @@ -5357,10 +5357,10 @@ RELEASE_GCC48_AARCH64_CC_FLAGS = DEF(GCC48_AARCH64_CC_FLAGS) -Wno-unused-but-s >> > *_GCC49_IA32_RC_PATH = DEF(GCC49_IA32_PREFIX)objcopy >> > >> > *_GCC49_IA32_ASLCC_FLAGS = DEF(GCC_ASLCC_FLAGS) -m32 >> > -*_GCC49_IA32_ASLDLINK_FLAGS = DEF(GCC49_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 -no-pie >> > +*_GCC49_IA32_ASLDLINK_FLAGS = DEF(GCC49_IA32_X64_ASLDLINK_FLAGS) -Wl,-m,elf_i386 >> > *_GCC49_IA32_ASM_FLAGS = DEF(GCC49_ASM_FLAGS) -m32 -march=i386 >> > *_GCC49_IA32_DLINK_FLAGS = DEF(GCC49_IA32_X64_DLINK_FLAGS) -Wl,-m,elf_i386,--oformat=elf32-i386 >> > -*_GCC49_IA32_DLINK2_FLAGS = DEF(GCC49_IA32_DLINK2_FLAGS) -no-pie >> > +*_GCC49_IA32_DLINK2_FLAGS = DEF(GCC49_IA32_DLINK2_FLAGS) >> > *_GCC49_IA32_RC_FLAGS = DEF(GCC_IA32_RC_FLAGS) >> > *_GCC49_IA32_OBJCOPY_FLAGS = >> > *_GCC49_IA32_NASM_FLAGS = -f elf32 >> > >> >> The latest release in the gcc-4.9 series is 4.9.4, according to the >> online docs, not 4.9.2. Perhaps rechecking with 4.9.4 would make sense; >> I'm not sure. Anyway, >> >> Acked-by: Laszlo Ersek >> >> Thanks! >> Laszlo >> _______________________________________________ >> edk2-devel mailing list >> edk2-devel@lists.01.org >> https://lists.01.org/mailman/listinfo/edk2-devel