public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	Andrew Fish <afish@apple.com>
Subject: Re: [PATCH] EmbeddedPkg: remove GdbDebugAgent library
Date: Wed, 12 Dec 2018 16:10:37 +0100	[thread overview]
Message-ID: <CAKv+Gu_cEpND=4OWv=WWY5CePEt758RUSNzusMXpOWegNu-bHQ@mail.gmail.com> (raw)
In-Reply-To: <20181212150254.dyncmhmb43imrat3@bivouac.eciton.net>

On Wed, 12 Dec 2018 at 16:02, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Dec 12, 2018 at 01:48:42PM +0100, Ard Biesheuvel wrote:
> > The GdbDebugAgent library is unused and unmaintained, and now it
> > turns out it doesn't build with Clang, so let's just get rid of it.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> But that's really only for the ARM-specific bits.
>
> Andrew, did anyone end up using this library for Ia32/X64?
>

Considering the commit log from its introduction

"""
commit 969eba7b0df70c9aa261eaf005085568b88de87c
Author: andrewfish <andrewfish@6f19259b-4bc3-4df7-8a09-765794883524>
Date:   Sat Apr 3 00:41:42 2010 +0000

Add the beginning of a GDB based Debug Agent. IA-32 and X64 don't have
low level interrupt code yet. I've been testing on ARM.

git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10334
6f19259b-4bc3-4df7-8a09-765794883524
"""

the lack of low level interrupt code in this patch, and the following
snippet from the .inf

"""
[Sources.X64]
  Ia32/Processor.c

[Sources.Ia32]
  X64/Processor.c
"""

I think it is safe to say that this code was never used on anything but ARM.


  reply	other threads:[~2018-12-12 15:10 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-12 12:48 [PATCH] EmbeddedPkg: remove GdbDebugAgent library Ard Biesheuvel
2018-12-12 15:02 ` Leif Lindholm
2018-12-12 15:10   ` Ard Biesheuvel [this message]
2018-12-12 15:17     ` Leif Lindholm
2018-12-19 15:20       ` Leif Lindholm
     [not found]         ` <CAKv+Gu9bC7uoxkjvB9yjuM6DUVAEGjUuUvasWyDOB17+KDXWNQ@mail.gmail.com>
2018-12-19 15:31           ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAKv+Gu_cEpND=4OWv=WWY5CePEt758RUSNzusMXpOWegNu-bHQ@mail.gmail.com' \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox