From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::144; helo=mail-it1-x144.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x144.google.com (mail-it1-x144.google.com [IPv6:2607:f8b0:4864:20::144]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C34BD21199554 for ; Wed, 12 Dec 2018 07:10:50 -0800 (PST) Received: by mail-it1-x144.google.com with SMTP id i145so9473248ita.4 for ; Wed, 12 Dec 2018 07:10:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Mue3YeUemeu33OMjqQHVTfB278W6ZEEwn5DhVOnoI2I=; b=MEWKNG5DkF2XaRkIaQByiaBCgDPA2HFChoWD/OXrryfm4g8DzWoQc3OXEy421LPC3c JtRnrqJloOKpi7VqJENfEG4iPmGp1ngQygWdrLD35mfscZg6u9B/N8Cbu7xUP3aoDeGo MvVLWSos63oazOKEKEK1z8E4p/KyXh7WLvwAs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Mue3YeUemeu33OMjqQHVTfB278W6ZEEwn5DhVOnoI2I=; b=Q6IQ8K7xq+xS4X93CoUcIV8737Duc3fdYsN7yPLya1XJqMgQhx+ZWvLzV2n22Nq1gC auPsqI46PlAEqtEwit6517viBM3UOJIqyb4mfQ1dWSIa8aezNqcWF0fpnFf9gsTOqK53 zMqpWMUYLZCj7mpSWJVIZyZNdhaA3GqKVhd9jJpPmxqTNonwU0fmFBRTdTyRqBjoihI7 RtRx8n01r7j/IWZFaFKb/f31u35XuXa1jRFHqMVtdqI0Rbgxp6JAHK2U9FLVrq/gFR9s AWUjOTokxJm4RVwfQsrGVGNwF36n3m0y++RbHv+bnh6Fp2+LJQoCh7BdX5JKM+sIkPjR /QWw== X-Gm-Message-State: AA+aEWbT5z+9cIhETWfNQeadteLD8JDAB8iudSZjufVhJ1t7oKW3Y7UY ZRAHbyWUEmFCfk2ukPpcVlHASnVsRr7NVWKlxVA3aw== X-Google-Smtp-Source: AFSGD/WXvihDaZtYrWH34V6ldu4p0VIJUIEM6+r04mp8kP31jc2hUlkWH98Hud3Y0Jqjlv2LEJE4w5VxebSghCY6ReA= X-Received: by 2002:a24:edc4:: with SMTP id r187mr6789905ith.158.1544627449948; Wed, 12 Dec 2018 07:10:49 -0800 (PST) MIME-Version: 1.0 References: <20181212124842.15968-1-ard.biesheuvel@linaro.org> <20181212150254.dyncmhmb43imrat3@bivouac.eciton.net> In-Reply-To: <20181212150254.dyncmhmb43imrat3@bivouac.eciton.net> From: Ard Biesheuvel Date: Wed, 12 Dec 2018 16:10:37 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" , Andrew Fish Subject: Re: [PATCH] EmbeddedPkg: remove GdbDebugAgent library X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 12 Dec 2018 15:10:51 -0000 Content-Type: text/plain; charset="UTF-8" On Wed, 12 Dec 2018 at 16:02, Leif Lindholm wrote: > > On Wed, Dec 12, 2018 at 01:48:42PM +0100, Ard Biesheuvel wrote: > > The GdbDebugAgent library is unused and unmaintained, and now it > > turns out it doesn't build with Clang, so let's just get rid of it. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > But that's really only for the ARM-specific bits. > > Andrew, did anyone end up using this library for Ia32/X64? > Considering the commit log from its introduction """ commit 969eba7b0df70c9aa261eaf005085568b88de87c Author: andrewfish Date: Sat Apr 3 00:41:42 2010 +0000 Add the beginning of a GDB based Debug Agent. IA-32 and X64 don't have low level interrupt code yet. I've been testing on ARM. git-svn-id: https://edk2.svn.sourceforge.net/svnroot/edk2/trunk/edk2@10334 6f19259b-4bc3-4df7-8a09-765794883524 """ the lack of low level interrupt code in this patch, and the following snippet from the .inf """ [Sources.X64] Ia32/Processor.c [Sources.Ia32] X64/Processor.c """ I think it is safe to say that this code was never used on anything but ARM.