From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 209AD21ED1C5F for ; Wed, 7 Mar 2018 12:36:40 -0800 (PST) Received: by mail-io0-x242.google.com with SMTP id m22so4510002iob.12 for ; Wed, 07 Mar 2018 12:42:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=ez+xGmmp712xma4NBrqjkP8+Gug/5c9cYtvoTfemEco=; b=Y3KdfQgJTOaqJdYE+lPPzPtEyRifyxa3m2ardQrPq9w4zzIZwq3q5Nb5wW98Qsguv2 XGIOZP31ofXPuDDyVcMSRuWI94ZNEzDpCCsRre7iNQ7xFOPTpHSxRZ86epUI17LF0Gn5 +PF8HkGXOIH3XYH2iWpKJDnv9J1aFUnoEuJcA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=ez+xGmmp712xma4NBrqjkP8+Gug/5c9cYtvoTfemEco=; b=Sjdra+UNRSZv//cP6TMMnH8B86UZ+C7SSIxDrVZwtZk50DoXWTrpDvhvnOYUbHfkGE BfD6zWTYAqxn29lNhTxjlVAqLQ24braQTTYwR29HV3rux57YN4YbRmeJN5lRnU5YMQg3 IBBQC/JpSUKW89Sqh4xNRSrK8BWnNi5dnob1LkSe07T66+L+VSzAOPdBMBJo1hS3jLex Gd81wCDreeKKKviDi6Jy0EhfA+TxIATLey6tuf4cgcTdJwed/w0opBZwqS3QFcfL1Eqs qPDruL9emBNdMu+zEP7brreCLRfTx05mk/zihNBem/iEvatDj4dbun2TPeIHh1uCJyXv 8m0w== X-Gm-Message-State: APf1xPAogx61RVNLbsBCiEnHoIstsh9Ax1FAR7WyOEC72ykJqVtC7+gW SzoKJWta7Qa28P0gCbasG/j9nmlGCik+13uV6U+BsqQJ X-Google-Smtp-Source: AG47ELtbaJKMsVOJXDBGnXeDTQP0hJdRjj3KPSM5bfSVtPwI7UYxOo4+A6YptSH/ScE/31xtFSraLZA9jvts86X2s7M= X-Received: by 10.107.41.16 with SMTP id p16mr28018768iop.173.1520455375506; Wed, 07 Mar 2018 12:42:55 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Wed, 7 Mar 2018 12:42:54 -0800 (PST) In-Reply-To: References: <20180307093259.7682-1-lersek@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E1D8C04@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Wed, 7 Mar 2018 20:42:54 +0000 Message-ID: To: Laszlo Ersek Cc: "Gao, Liming" , edk2-devel-01 , "Zhu, Yonghong" Subject: Re: [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Mar 2018 20:36:41 -0000 Content-Type: text/plain; charset="UTF-8" On 7 March 2018 at 20:28, Laszlo Ersek wrote: > On 03/07/18 12:51, Gao, Liming wrote: >> Reviewed-by: Liming Gao > > Thank you, Liming. > > Ard, are you OK with this patch as well? > Sure Acked-by: Ard Biesheuvel >>> -----Original Message----- >>> From: Laszlo Ersek [mailto:lersek@redhat.com] >>> Sent: Wednesday, March 7, 2018 5:33 PM >>> To: edk2-devel-01 >>> Cc: Gao, Liming ; Zhu, Yonghong >>> Subject: [PATCH] BaseTools/header.makefile: revert gcc-8 "-Wno-xxx" options on OSX >>> >>> I recently added the gcc-8 specific "-Wno-stringop-truncation" and >>> "-Wno-restrict" options to BUILD_CFLAGS, both for "Darwin" (XCODE5 / >>> clang, OSX) and otherwise (gcc, Linux / Cygwin). >>> >>> I also regression-tested the change with gcc-4.8 on Linux -- gcc-4.8 does >>> not know either of the (gcc-8 specific) "-Wno-stringop-truncation" and >>> "-Wno-restrict" options, yet the build completed fine (by GCC design). >>> >>> Regarding OSX, my expectation was that >>> >>> - XCODE5 / clang would either recognize these warnings options (because >>> clang does recognize most -W options of gcc), >>> >>> - or, similarly to gcc, clang would simply ignore the "-Wno-xxx" flags >>> that it didn't recognize. >>> >>> Neither is the case; the new flags have broken the BaseTools build on OSX. >>> Revert them (for OSX only). >>> >>> Cc: Liming Gao >>> Cc: Yonghong Zhu >>> Reported-by: Liming Gao >>> Fixes: 1d212a83df0eaf32a6f5d4159beb2d77832e0231 >>> Fixes: 9222154ae7b3eef75ae88cdb56158256227cb929 >>> Contributed-under: TianoCore Contribution Agreement 1.1 >>> Signed-off-by: Laszlo Ersek >>> --- >>> BaseTools/Source/C/Makefiles/header.makefile | 2 +- >>> 1 file changed, 1 insertion(+), 1 deletion(-) >>> >>> diff --git a/BaseTools/Source/C/Makefiles/header.makefile b/BaseTools/Source/C/Makefiles/header.makefile >>> index 065a998bf5de..db436773cf40 100644 >>> --- a/BaseTools/Source/C/Makefiles/header.makefile >>> +++ b/BaseTools/Source/C/Makefiles/header.makefile >>> @@ -71,7 +71,7 @@ INCLUDE = $(TOOL_INCLUDE) -I $(MAKEROOT) -I $(MAKEROOT)/Include/Common -I $(MAKE >>> BUILD_CPPFLAGS = $(INCLUDE) -O2 >>> ifeq ($(DARWIN),Darwin) >>> # assume clang or clang compatible flags on OS X >>> -BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation >>> -Wno-restrict -Wno-self-assign -Wno-unused-result -nostdlib -c -g >>> +BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-self-assign >>> -Wno-unused-result -nostdlib -c -g >>> else >>> BUILD_CFLAGS = -MD -fshort-wchar -fno-strict-aliasing -Wall -Werror -Wno-deprecated-declarations -Wno-stringop-truncation >>> -Wno-restrict -Wno-unused-result -nostdlib -c -g >>> endif >>> -- >>> 2.14.1.3.gb7cf6e02401b >> >