From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=dNj1r5Gt; spf=pass (domain: linaro.org, ip: 209.85.166.180, mailfrom: ard.biesheuvel@linaro.org) Received: from mail-it1-f180.google.com (mail-it1-f180.google.com [209.85.166.180]) by groups.io with SMTP; Mon, 10 Jun 2019 02:06:30 -0700 Received: by mail-it1-f180.google.com with SMTP id j194so5136401ite.0 for ; Mon, 10 Jun 2019 02:06:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=EDQJMubyKwzJt+MJLsEVyMwkeeHB8/p81LCUBwR1nSc=; b=dNj1r5Gt37+awzsp2AI1ZCtPe1oQs8FrfyhhCL4QohXNDj3UlTzKHJWFY9mSHAJFtn gQ0mE6ig9ObfgE4I85sO5s+eHcI04VEzfn9A9bMVxhp3TNp/eF4NftZjR63j4Xw+aoEX lUKlI5dyyuUuGqVg+ASLrFM8VpPJHYHHOwTnayWC9otbUv5EQtTvkSBZeGBNlwAa2io6 gDpBMlWm+ykzsitcb1vKllXdX3EN/UpmGA23mkl1CctizEfoxoVeL30yYY67RPEGpdLB sKeId2kMRuNI13fU9p1xgVQlJD8/Oi/I2F90rwO72gcWvD0MFcXgWiApyIpgSjB9i8ZF Co3w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=EDQJMubyKwzJt+MJLsEVyMwkeeHB8/p81LCUBwR1nSc=; b=FyJVASWN8hYNZtE9vkx2C4+adc3lA59H1qT49bNcv603Hyfp5jf4iVsB4w32swtCRC BlycBTyukmYi3ebImDprgCRFTbEPHTn7YPY1ZHy8DMmF4oKMip3NMxMZl5QBj87ClF5I b9baZsO1kLBIx69GbBr7DPsziP5RxNA1s5WmCPp9b+SPek+ewV1lSyyMZH9tkKIsKDXn 8D++YPQatfu7MxvE4S4qLy2b9UZfbdryhxEQbKqkdt+lEVIFR22C6IDvEn8JwCF0w6nn t8MKFxqs/gJOfI4fjPrcJtBeUytWwnaV5wI7MXB2PPRz66g63xNoH49qGXSi138EL+jJ OXGA== X-Gm-Message-State: APjAAAVHi7fNNN9vBPM3KHTQELNZlJ788fLzuWW8+Kf8fK2wDoyhnjbX dRzORwKLa6xyYGBSaq80zx7yzdCzuVo4NBUDrFlwDxC+YVxt1A== X-Google-Smtp-Source: APXvYqwcL99PztBAcdNAaZ/oyBS4i1s4Mhy8xciVgw0E9A2/6ya2l0yqpeV0E/W08ap1yLClSZBURG2ENxQXlXFkqDw= X-Received: by 2002:a24:5f87:: with SMTP id r129mr854756itb.104.1560157589991; Mon, 10 Jun 2019 02:06:29 -0700 (PDT) MIME-Version: 1.0 References: <20190528095853.16476-1-liming.gao@intel.com> <20190528095853.16476-3-liming.gao@intel.com> In-Reply-To: <20190528095853.16476-3-liming.gao@intel.com> From: "Ard Biesheuvel" Date: Mon, 10 Jun 2019 11:06:18 +0200 Message-ID: Subject: Re: [edk2-devel] [edk2-platform patch 2/7] RDKQemu: Update RDKQemu.dsc to remove unnecessary Network libs To: edk2-devel-groups-io , "Gao, Liming" Cc: Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Tue, 28 May 2019 at 12:00, Liming Gao wrote: > > Signed-off-by: Liming Gao > Cc: Ard Biesheuvel > Cc: Leif Lindholm This still does not build. It has lots of other errors, but with those fixes, we still need to set NETWORK_ALLOW_HTTP_CONNECTIONS to TRUE to retain the old behavior. I will follow up with a patch that fixes this platform, no need to resend. > --- > Platform/Comcast/RDKQemu/RDKQemu.dsc | 5 +---- > 1 file changed, 1 insertion(+), 4 deletions(-) > > diff --git a/Platform/Comcast/RDKQemu/RDKQemu.dsc b/Platform/Comcast/RDKQemu/RDKQemu.dsc > index 64b6699ae7..e73a907891 100644 > --- a/Platform/Comcast/RDKQemu/RDKQemu.dsc > +++ b/Platform/Comcast/RDKQemu/RDKQemu.dsc > @@ -33,7 +33,7 @@ > # Network definition > # > DEFINE NETWORK_SNP_ENABLE = FALSE > - DEFINE NETWORK_TLS_ENABLE = FALSE > + DEFINE NETWORK_TLS_ENABLE = TRUE > DEFINE NETWORK_IP6_ENABLE = FALSE > DEFINE NETWORK_HTTP_BOOT_ENABLE = TRUE > > @@ -65,9 +65,6 @@ > PciSegmentLib|MdePkg/Library/BasePciSegmentLibPci/BasePciSegmentLibPci.inf > PciHostBridgeLib|ArmVirtPkg/Library/FdtPciHostBridgeLib/FdtPciHostBridgeLib.inf > RdkBootManagerLib|Platform/Comcast/Library/RdkBootManagerLib/RdkBootManagerLib.inf > -!if $(HTTP_BOOT_ENABLE) == TRUE > - HttpLib|MdeModulePkg/Library/DxeHttpLib/DxeHttpLib.inf > -!endif > > [LibraryClasses.common.PEIM] > ArmVirtMemInfoLib|ArmVirtPkg/Library/QemuVirtMemInfoLib/QemuVirtMemInfoPeiLib.inf > -- > 2.13.0.windows.1 > > > >