public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>,
	Eric Dong <eric.dong@intel.com>,
	 Leif Lindholm <leif.lindholm@linaro.org>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [PATCH] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory
Date: Fri, 19 Oct 2018 11:24:49 +0800	[thread overview]
Message-ID: <CAKv+Gu_cSxyE1D6pm5p5PwRnjMBw-OnUkPk3Zyrm61iJDzc4Kw@mail.gmail.com> (raw)
In-Reply-To: <20181019025418.3037-1-ard.biesheuvel@linaro.org>

On 19 October 2018 at 10:54, Ard Biesheuvel <ard.biesheuvel@linaro.org> wrote:
> Given that the firmware itself may access the ESRT table when the OS
> invokes the UpdateCapsule () boot service,

*runtime* service

> it requires a virtual mapping
> and so it needs to be allocated from RtServicesData memory.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
>  MdeModulePkg/Universal/EsrtDxe/EsrtDxe.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.c b/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.c
> index cab8d69e35ad..66266a44cec9 100644
> --- a/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.c
> +++ b/MdeModulePkg/Universal/EsrtDxe/EsrtDxe.c
> @@ -577,7 +577,8 @@ EsrtReadyToBootEventNotify (
>      goto EXIT;
>    }
>
> -  EsrtTable = AllocatePool(sizeof(EFI_SYSTEM_RESOURCE_TABLE) + NonFmpRepositorySize + FmpRepositorySize);
> +  EsrtTable = AllocateRuntimePool (sizeof(EFI_SYSTEM_RESOURCE_TABLE) +
> +                                   NonFmpRepositorySize + FmpRepositorySize);
>    if (EsrtTable == NULL) {
>      DEBUG ((EFI_D_ERROR, "Esrt table memory allocation failure\n"));
>      goto EXIT;
> --
> 2.17.1
>


  reply	other threads:[~2018-10-19  3:24 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-10-19  2:54 [PATCH] MdeModulePkg/EsrtDxe: allocate ESRT table from RtServicesData memory Ard Biesheuvel
2018-10-19  3:24 ` Ard Biesheuvel [this message]
2018-10-19  3:46   ` Zeng, Star
2018-10-19  3:48     ` Ard Biesheuvel
2018-10-19  4:39       ` Zeng, Star
2018-10-19  4:43         ` Ard Biesheuvel
2018-10-19  4:48           ` Zeng, Star
2018-10-19  5:01             ` Ard Biesheuvel
2018-10-19  5:11               ` Ard Biesheuvel
2018-10-19  5:25                 ` Zeng, Star
2018-10-19  5:28                   ` Ard Biesheuvel
2018-10-19  6:01                     ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_cSxyE1D6pm5p5PwRnjMBw-OnUkPk3Zyrm61iJDzc4Kw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox