From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::242; helo=mail-io0-x242.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x242.google.com (mail-io0-x242.google.com [IPv6:2607:f8b0:4001:c06::242]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8EA30223FCF4E for ; Thu, 15 Mar 2018 00:58:56 -0700 (PDT) Received: by mail-io0-x242.google.com with SMTP id d71so7515502iog.4 for ; Thu, 15 Mar 2018 01:05:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=PH8ShEM4ahCAl857YY3BLapr2jSe+fSp7Bsb+agxvQs=; b=JyBAYMl2gGsIp73j6QzXa9bwVXBY9Y8iUpG1p1zScOZWmEL1E1HDilAFOpn6i9Gx6V hssV+q/lcrbQ62dtIPXcjM7DRYY5ALDNCrAVH28aLmIm0LSdZsUAsQfYRDvG8gs61m9E 0sRcOIcs+3saVDRB3sSPbjCGhsmzmaXNjIpmE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=PH8ShEM4ahCAl857YY3BLapr2jSe+fSp7Bsb+agxvQs=; b=fEYroSUe5mlJKL2D7xXzYAm9vh0oV5yo0BaaecjLXxkpPJu6pNDNI2w5Ut45/ZYIo3 W7GcCdYJV0rEubwulKUDO/j6EAJ9qrXJsrLL0bxrOUmlQ8QjwG/64w9kX1IGkTE54HGE 9avKeSJOYcbA6QYFfYZnG329NeHlZKxTJ3r+xqu2/RMcwOQKcXbVoz9rO71gGfaOt8W5 3h4Q7QDU9gf04nd8YFbA88r+7wkYaAF7ZRQmRtm2CQzplqKYlghvxPGtcHjnEkCr36aJ jOn/a/R7PZKt54BJjY0zN/DU2eFFsyuPhpeg9X6KCE44u3CqS5wSyYSZTAnXHahm8Fsa Ttrw== X-Gm-Message-State: AElRT7E+DiyZcfO81g1/TnhswL30IHNff/LmmKVVPnC/7Z1MXNYyCtvv 1iunnMY3j23gvSuNQ6EDIeoGo0j64dXhRQAJ2ELAFg== X-Google-Smtp-Source: AG47ELv73hwYhTFs570e9km4YtthQ19Owt3ckk+vX86vJtJAeDWJwIXU1RZ+nc17cJAeSW4bI8mnd+xF12+deuMB+LY= X-Received: by 10.107.151.74 with SMTP id z71mr7435780iod.277.1521101119618; Thu, 15 Mar 2018 01:05:19 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.138.209 with HTTP; Thu, 15 Mar 2018 01:05:19 -0700 (PDT) In-Reply-To: <1521093843-48615-1-git-send-email-heyi.guo@linaro.org> References: <1521093843-48615-1-git-send-email-heyi.guo@linaro.org> From: Ard Biesheuvel Date: Thu, 15 Mar 2018 08:05:19 +0000 Message-ID: To: Heyi Guo , Ruiyu Ni , Maurice Ma , Benjamin You , Prince Agyeman Cc: "edk2-devel@lists.01.org" , Star Zeng , Eric Dong , Laszlo Ersek , Michael D Kinney , Jordan Justen , Anthony Perard , Julien Grall Subject: Re: [PATCH v7 0/6] Add translation support to generic PciHostBridge X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Mar 2018 07:58:57 -0000 Content-Type: text/plain; charset="UTF-8" On 15 March 2018 at 06:03, Heyi Guo wrote: > Code can also be found here: > https://github.com/iwishguo/edk2/tree/patch-pci-host-bridge-v7 > > v7: > - Patch 4: implement 1 comments from Ray. > Thanks Heyi. I will merge this v7 by the end of today unless anyone objects. Maurice, Prince, Benjamin: you have had ample time to respond to the Coreboot changes. I am going to assume that you have no objections unless you raise them today. Thanks all, Ard. > v6: > - Patch 1, 2: implement 3 comments from Laszlo. > - Patch 4: implement 3 comments from Ray. > > Patch v5 inherits the code from RFC v4; we don't restart the version number for > RFC to PATCH change. > > v5: > - Patch 4/6: Modify the code according to the comments from Ray. > - Patch 1/6 and 2/6 are totally new. They add initialization for all fields of > PCI_ROOT_BRIDGE_APERTURE temporary variables in PciHostBridgeLib instances, so > that they will not suffer from extension of PCI_ROOT_BRIDGE_APERTURE > structure. > - Generate a separate patch (3/6) for PciHostBridgeLib.h change. Though it is a > prerequisite for patch 4/6, it does not change the code in PciHostBridge > driver and won't cause any build failure or functional issue. > > > v4: > - Modify the code according to the comments from Ray, Laszlo and Ard (Please see > the notes of Patch 1/3) > - Ignore translation of bus in CreateRootBridge. > > > v3: > - Keep definition of Translation consistent in EDKII code: Translation = device > address - host address. > - Patch 2/2 is split into 2 patches (2/3 and 3/3). > - Refine comments and commit messages to make the code easier to understand. > > > v2: > Changs are made according to the discussion on the mailing list, including: > > - PciRootBridgeIo->Configuration should return CPU view address, as well as > PciIo->GetBarAttributes, and Translation Offset should be equal to PCI view > address - CPU view address. > - Add translation offset to PCI_ROOT_BRIDGE_APERTURE structure definition. > - PciHostBridge driver internally used Base Address is still based on PCI view > address, and translation offset = CPU view - PCI view, which follows the > definition in ACPI, and not the same as that in UEFI spec. > > Cc: Ruiyu Ni > Cc: Ard Biesheuvel > Cc: Star Zeng > Cc: Eric Dong > Cc: Laszlo Ersek > Cc: Michael D Kinney > Cc: Maurice Ma > Cc: Prince Agyeman > Cc: Benjamin You > Cc: Jordan Justen > Cc: Anthony Perard > Cc: Julien Grall > > > Heyi Guo (6): > CorebootPayloadPkg/PciHostBridgeLib: clear aperture vars for (re)init > OvmfPkg/PciHostBridgeLib: clear PCI aperture vars for (re)init > MdeModulePkg/PciHostBridgeLib.h: add address Translation > MdeModulePkg/PciHostBridgeDxe: Add support for address translation > MdeModulePkg/PciBus: convert host address to device address > MdeModulePkg/PciBus: return CPU address for GetBarAttributes > > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.h | 21 +++ > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostResource.h | 3 + > MdeModulePkg/Include/Library/PciHostBridgeLib.h | 19 +++ > CorebootPayloadPkg/Library/PciHostBridgeLib/PciHostBridgeSupport.c | 7 +- > MdeModulePkg/Bus/Pci/PciBusDxe/PciIo.c | 12 +- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciHostBridge.c | 129 ++++++++++++++++--- > MdeModulePkg/Bus/Pci/PciHostBridgeDxe/PciRootBridgeIo.c | 135 ++++++++++++++++++-- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 4 + > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 7 +- > 9 files changed, 306 insertions(+), 31 deletions(-) > > -- > 2.7.4 >