From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f65.google.com (mail-wm1-f65.google.com [209.85.128.65]) by mx.groups.io with SMTP id smtpd.web12.7192.1578487377823824021 for ; Wed, 08 Jan 2020 04:42:58 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@linaro.org header.s=google header.b=Q1g0mGh3; spf=pass (domain: linaro.org, ip: 209.85.128.65, mailfrom: ard.biesheuvel@linaro.org) Received: by mail-wm1-f65.google.com with SMTP id u2so2349043wmc.3 for ; Wed, 08 Jan 2020 04:42:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=NXUc2Mn+T8zO1A/Yt8Rz+rJgWxHQzo1yF5gMxBGUgsM=; b=Q1g0mGh3aq/6gIsgojRffl/V+wkDH3I4lyvpupAd7wkBa/L15LK6SgWehicX7pKUp8 o9OgrDPRQQB+YwLY7Gr33avm6OHv+7rk6hxtEkLYYVN4cOVixxMcCnOoG1TBGue6HUZs Q2LS00EXIoI+s9+aAuD0M7e6i2KFhh7zejLkadWXN3fo4g+DLFE93oRaB4OxKYX9i2Uw iPhzsK2oD4r3Y3qPFAK+nUiCK/GAEsfkwpiskOTjKXCRvkW9VMyN3qQE1GhQDqFyzOIj /9rpOjcsFaW5GOh7bwFWWFZ2yDlorNo3c23aH5xSqATXi6pXeFtwPQSIJ4IYNjH1917F QcWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=NXUc2Mn+T8zO1A/Yt8Rz+rJgWxHQzo1yF5gMxBGUgsM=; b=VJSto2gxoGUZ3rRP5UqHZ5FRV4NGEAvqbHV9SjGPFeDzdyCxQlh73DoxlXfWMxOSux klvgEdxf7JmD/+at1FUQp+WfzMmgKar2A9JLWaGfRD7WVguXBisNlYCFBG3ETnmUm5rn T6OYS9x5b9LMfckLrAJEs8BrklK02xYUTcG7L+zsCrGJzvVF7vOz2TaP+IFtlUYObCn9 2N3AvNJxJL9BCzafAL5jeTDkUjG0iFQlp1ldL14aEraa2lGIVdGaqTf/zo9Vun2nCtaL zFMRHea7AI1ClaUaytRPfrTYyyNhPOryCFCxuMY/Dm/ZSVU/SsPUSqPVaG3yGDQAOYvU zuhg== X-Gm-Message-State: APjAAAXC8droieYkMeKYwlM67ByvTodju3zu/4CzdqUQwF45mXXZXePs kTJY1jB/sZzDKKMCKs/gl8smTtPqN3mqhAU6WetJXA== X-Google-Smtp-Source: APXvYqz1maMTfdTDqHTeQMCQjE8B/2cY92qAt/rSTAbD3VheMy67VbYLqNGU4MBzVP6cxj3YWy6hD6Ob9B64Fe6u41g= X-Received: by 2002:a1c:3dc3:: with SMTP id k186mr3550637wma.95.1578487376337; Wed, 08 Jan 2020 04:42:56 -0800 (PST) MIME-Version: 1.0 References: <20200103090812.10592-1-philmd@redhat.com> <20200103090812.10592-4-philmd@redhat.com> In-Reply-To: <20200103090812.10592-4-philmd@redhat.com> From: "Ard Biesheuvel" Date: Wed, 8 Jan 2020 13:42:45 +0100 Message-ID: Subject: Re: [PATCH v2 03/78] EmbeddedPkg/VirtualKeyboard: Fix few typos To: Philippe Mathieu-Daude Cc: edk2-devel-groups-io , Antoine Coeur , Leif Lindholm Content-Type: text/plain; charset="UTF-8" On Fri, 3 Jan 2020 at 10:08, Philippe Mathieu-Daude wrote: > > From: Antoine Coeur > > Fix few typos in the documentation. > > Cc: Leif Lindholm > Cc: Ard Biesheuvel > Signed-off-by: Antoine Coeur > Reviewed-by: Philippe Mathieu-Daude > Signed-off-by: Philippe Mathieu-Daude Reviewed-by: Ard Biesheuvel Nit below > --- > .../Drivers/VirtualKeyboardDxe/VirtualKeyboard.h | 14 +++++++------- > .../Drivers/VirtualKeyboardDxe/VirtualKeyboard.c | 16 ++++++++-------- > 2 files changed, 15 insertions(+), 15 deletions(-) > > diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h > index 29bc7a06fb16..026449046653 100644 > --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h > +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.h > @@ -323,7 +323,7 @@ VirtualKeyboardReset ( > ); > > /** > - Reset the input device and optionaly run diagnostics > + Reset the input device and optionally run diagnostics > > @param This Protocol instance pointer. > @param ExtendedVerification Driver may perform diagnostics on reset. > @@ -373,7 +373,7 @@ VirtualKeyboardSetState ( > > > @retval EFI_SUCCESS The notification function was registered successfully. > - @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary data structures. > + @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necessary data structures. > @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL. > > **/ > @@ -429,7 +429,7 @@ VirtualKeyboardFreeNotifyList ( > state data for the key that was pressed. > > @retval TRUE Key be pressed matches a registered key. > - @retval FLASE Match failed. > + @retval FALSE Match failed. > > **/ > BOOLEAN > @@ -441,7 +441,7 @@ IsKeyRegistered ( > /** > Waiting on the keyboard event, if there's any key pressed by the user, signal the event > > - @param Event The event that be siganlled when any key has been stroked. > + @param Event The event that be signalled when any key has been stroked. stroked -> struck? > @param Context Pointer of the protocol EFI_SIMPLE_TEXT_INPUT_PROTOCOL. > > **/ > @@ -455,7 +455,7 @@ VirtualKeyboardWaitForKey ( > /** > Waiting on the keyboard event, if there's any key pressed by the user, signal the event > > - @param Event The event that be siganlled when any key has been stroked. > + @param Event The event that be signalled when any key has been stroked. > @param Context Pointer of the protocol EFI_SIMPLE_TEXT_INPUT_EX_PROTOCOL. > > **/ > @@ -514,14 +514,14 @@ VirtualKeyboardReadKeyStroke ( > > /** > Reads the next keystroke from the input device. The WaitForKey Event can > - be used to test for existance of a keystroke via WaitForEvent () call. > + be used to test for existence of a keystroke via WaitForEvent () call. > > @param This Protocol instance pointer. > @param KeyData A pointer to a buffer that is filled in with the keystroke > state data for the key that was pressed. > > @retval EFI_SUCCESS The keystroke information was returned. > - @retval EFI_NOT_READY There was no keystroke data availiable. > + @retval EFI_NOT_READY There was no keystroke data available. > @retval EFI_DEVICE_ERROR The keystroke information was not returned due to > hardware errors. > @retval EFI_INVALID_PARAMETER KeyData is NULL. > diff --git a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c > index 750371a06723..e9d0b72ee6c3 100644 > --- a/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c > +++ b/EmbeddedPkg/Drivers/VirtualKeyboardDxe/VirtualKeyboard.c > @@ -437,7 +437,7 @@ VirtualKeyboardFreeNotifyList ( > pressed. > > @retval TRUE Key be pressed matches a registered key. > - @retval FLASE Match failed. > + @retval FALSE Match failed. > > **/ > BOOLEAN > @@ -476,7 +476,7 @@ IsKeyRegistered ( > Signal the event if there is key available > > @param Event the event object > - @param Context waitting context > + @param Context waiting context > > **/ > VOID > @@ -580,7 +580,7 @@ VirtualKeyboardReset ( > } > > /** > - Reset the input device and optionaly run diagnostics > + Reset the input device and optionally run diagnostics > > @param This Protocol instance pointer. > @param ExtendedVerification Driver may perform diagnostics on reset. > @@ -621,7 +621,7 @@ VirtualKeyboardResetEx ( > > /** > Reads the next keystroke from the input device. The WaitForKey Event can > - be used to test for existance of a keystroke via WaitForEvent () call. > + be used to test for existence of a keystroke via WaitForEvent () call. > > @param VirtualKeyboardPrivate Virtualkeyboard driver private structure. > @param KeyData A pointer to a buffer that is filled in > @@ -629,7 +629,7 @@ VirtualKeyboardResetEx ( > that was pressed. > > @retval EFI_SUCCESS The keystroke information was returned. > - @retval EFI_NOT_READY There was no keystroke data availiable. > + @retval EFI_NOT_READY There was no keystroke data available. > @retval EFI_DEVICE_ERROR The keystroke information was not returned > due to hardware errors. > @retval EFI_INVALID_PARAMETER KeyData is NULL. > @@ -731,14 +731,14 @@ VirtualKeyboardReadKeyStroke ( > > /** > Reads the next keystroke from the input device. The WaitForKey Event can > - be used to test for existance of a keystroke via WaitForEvent () call. > + be used to test for existence of a keystroke via WaitForEvent () call. > > @param This Protocol instance pointer. > @param KeyData A pointer to a buffer that is filled in with the > keystroke state data for the key that was pressed. > > @retval EFI_SUCCESS The keystroke information was returned. > - @retval EFI_NOT_READY There was no keystroke data availiable. > + @retval EFI_NOT_READY There was no keystroke data available. > @retval EFI_DEVICE_ERROR The keystroke information was not returned > due to hardware errors. > @retval EFI_INVALID_PARAMETER KeyData is NULL. > @@ -808,7 +808,7 @@ VirtualKeyboardSetState ( > > @retval EFI_SUCCESS The notification function was registered > successfully. > - @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necesssary > + @retval EFI_OUT_OF_RESOURCES Unable to allocate resources for necessary > data structures. > @retval EFI_INVALID_PARAMETER KeyData or NotifyHandle is NULL. > > -- > 2.21.0 >