From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Laszlo Ersek <lersek@redhat.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
"Gao, Liming" <liming.gao@intel.com>,
"Feng, Bob C" <bob.c.feng@intel.com>,
Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [PATCH 2/3] BaseTools/tools_def ARM CLANG35: work around -mno-movt option name change
Date: Wed, 12 Dec 2018 12:51:12 +0100 [thread overview]
Message-ID: <CAKv+Gu_dV2qKFLpXOhjmAjof-OSK9yD8Zm6Fy_xKdfHvFKerLQ@mail.gmail.com> (raw)
In-Reply-To: <0f1b613c-e027-e025-ccc1-d2526653d0ca@redhat.com>
On Wed, 12 Dec 2018 at 12:50, Laszlo Ersek <lersek@redhat.com> wrote:
>
> On 12/12/18 11:33, Ard Biesheuvel wrote:
> > PE/COFF only has a very limited id space for runtime relocations, and
> > so it defines only a single relocation for movw/movt instruction pairs,
> > which can be combined to load a 32-bit symbol reference into a register.
> > For this to work as expected, these instructions must always appear in
> > the same order and adjacently, and this is something few compilers take
> > into account, unless they target PE/COFF explicitly (and this is not the
> > case for our ELF based toolchains)
> >
> > For Clang 3.6 and later, we can pass the -mno-movt option to suppress
> > movw/movt pairs entirely, which works around the issue. Unfortunately,
> > for Clang 3.5, the option is called differently (-mllvm -arm-use-movt=0)
> > and mutually incompatible between 3.5 and 3.6.
> >
> > Since it is desirable for the CLANG35 toolchain to be usable on newer
> > versions of Clang as well (given that it is the only non-LTO alternative
> > to CLANG38), let's work around this issue in a way that permits versions
> > 3.5 and newer of Clang to be used with the CLANG35 profile.
> >
> > So pass the -mkernel flag instead (and drop the -mno-unaligned-access
> > in *_CLANG35_ARM_CC_XIPFLAGS which now becomes redundant, and which
> > Clang complains about). This also inhibits movw/movt generation, along
> > with some other changes (e.g., long calls) which do affect code generation
> > but not in a undesirable manner.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> > ---
> > BaseTools/Conf/tools_def.template | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/BaseTools/Conf/tools_def.template b/BaseTools/Conf/tools_def.template
> > index ac2b95e0f5ba..2ba833e1fb06 100755
> > --- a/BaseTools/Conf/tools_def.template
> > +++ b/BaseTools/Conf/tools_def.template
> > @@ -5249,7 +5249,7 @@ DEFINE CLANG35_AARCH64_CC_FLAGS = DEF(GCC_AARCH64_CC_FLAGS) DEF(CLANG35_AARCH64
> > *_CLANG35_ARM_ASM_FLAGS = DEF(GCC_ASM_FLAGS) DEF(CLANG35_ARM_TARGET) $(ARCHASM_FLAGS) $(PLATFORM_FLAGS) -Qunused-arguments
> > *_CLANG35_ARM_DLINK_FLAGS = DEF(CLANG35_ARM_TARGET) DEF(GCC_ARM_DLINK_FLAGS)
> > *_CLANG35_ARM_DLINK2_FLAGS = DEF(GCC_DLINK2_FLAGS_COMMON) -Wl,--defsym=PECOFF_HEADER_SIZE=0x220
> > -*_CLANG35_ARM_PLATFORM_FLAGS = -march=armv7-a
> > +*_CLANG35_ARM_PLATFORM_FLAGS = -march=armv7-a -mkernel -Qunused-arguments
> > *_CLANG35_ARM_PP_FLAGS = DEF(GCC_PP_FLAGS) DEF(CLANG35_ARM_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS)
> > *_CLANG35_ARM_RC_FLAGS = DEF(GCC_ARM_RC_FLAGS)
> > *_CLANG35_ARM_VFRPP_FLAGS = DEF(GCC_VFRPP_FLAGS) DEF(CLANG35_ARM_TARGET) $(ARCHCC_FLAGS) $(PLATFORM_FLAGS)
> >
>
> The commit message speaks about adding -mkernel, and removing
> -mno-unaligned-access (elsewhere). In the patch, I only see -mkernel
> (plus an un-announced -Qunused-arguments option).
>
> Is the commit message slightly out-of-date relative to the code? (Or
> perhaps the other way around?)
>
Ah yes. The -mno-unaligned-access became redundant, but instead of
removing it, i ended up adding the -Qunused-arguments to stop Clang
from complaining about it.
next prev parent reply other threads:[~2018-12-12 11:51 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-12 10:33 [PATCH 0/3] fixes for CLANG35 on ARM Ard Biesheuvel
2018-12-12 10:33 ` [PATCH 1/3] MdePkg/BaseMemoryLibOptDxe ARM: add missing function annotations Ard Biesheuvel
2018-12-12 11:48 ` Laszlo Ersek
2018-12-12 10:33 ` [PATCH 2/3] BaseTools/tools_def ARM CLANG35: work around -mno-movt option name change Ard Biesheuvel
2018-12-12 11:49 ` Laszlo Ersek
2018-12-12 11:51 ` Ard Biesheuvel [this message]
2018-12-12 12:04 ` Laszlo Ersek
2018-12-12 12:30 ` Ard Biesheuvel
2018-12-12 12:34 ` Leif Lindholm
2018-12-12 10:33 ` [PATCH 3/3] ArmVirtPkg/PrePi ARM CLANG35: drop incompatible command line option Ard Biesheuvel
2018-12-12 11:51 ` Laszlo Ersek
2018-12-12 12:37 ` [PATCH 0/3] fixes for CLANG35 on ARM Leif Lindholm
2018-12-12 14:01 ` Gao, Liming
2018-12-12 14:02 ` Ard Biesheuvel
2018-12-12 14:19 ` Gao, Liming
2018-12-12 14:19 ` Ard Biesheuvel
2018-12-13 10:49 ` Ard Biesheuvel
2018-12-13 11:42 ` Gao, Liming
2018-12-13 11:49 ` Ard Biesheuvel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAKv+Gu_dV2qKFLpXOhjmAjof-OSK9yD8Zm6Fy_xKdfHvFKerLQ@mail.gmail.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox