From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::229; helo=mail-io0-x229.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x229.google.com (mail-io0-x229.google.com [IPv6:2607:f8b0:4001:c06::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1EAD1211F8891 for ; Tue, 26 Jun 2018 11:51:56 -0700 (PDT) Received: by mail-io0-x229.google.com with SMTP id f1-v6so16925367ioh.6 for ; Tue, 26 Jun 2018 11:51:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=Zva2vhc2oly0KikkcJJQrD/vrNCL3lD9a+o4zbg0z8U=; b=Z/3lyHowpuTQR9lQbVD3mYVNDwh8E7279M936WNl1QHbe3R3L6MoCSg6T2+z95G5rI ns6kurYuZ5rLQRlCvC29OQ5PJOGDgdrj/+pESWr4Cy/O8VLABX7KezQzQiQN/Xaz0ynV Fwt73PRe0fnuSdOh3V4IN9Yf996MNOdW46ZL4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=Zva2vhc2oly0KikkcJJQrD/vrNCL3lD9a+o4zbg0z8U=; b=H95FgsvSGpml3nPRDpdx4rP7N4uo+1fuQs77i+Qplp9y+zqqGoa9eesNTE1oi5gkxr vcX05qp5c8krXIP4QvJUCDN5x32TCa/WgBzYmYsF1kfewwxCI34eYtJRCHdzyZXr9V3F fhSoFWqaV2mS4WHDIuOvui6qF0BjNl/ZvZiyrcsyFgcac7T6IQrAYzHhwfJqe/AOENQI mtcb4iMvmgADovUoVvVpUC8G+4fvHvt/F0BiJSV0+Kr5F80NirmhK0ju+5llpmx472t8 pA53BkHzgYkoa5wESV1vwofxOLf6XbVJijLxg123FMEbOXDr1Bz+ixM27OciyHjO7+AV xI2g== X-Gm-Message-State: APt69E187oqc+gAdEaiPyYA5nFInRjf5TU/tjE37BJBh/OoipUmTQcPg OGgkQS+mg8c4xTwN0MILD/g5c2DuIVOjrIlVnKUylA== X-Google-Smtp-Source: AAOMgpeX657+b8oeZfqIYfDxoq96/hhN1s/xxzkwvtDi32cMn6jz7ch18Wnxd3wvpdeniawUAVsrQeN9L7DbX4Uu6rc= X-Received: by 2002:a6b:520d:: with SMTP id g13-v6mr2451909iob.60.1530039115215; Tue, 26 Jun 2018 11:51:55 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:bbc7:0:0:0:0:0 with HTTP; Tue, 26 Jun 2018 11:51:54 -0700 (PDT) In-Reply-To: References: <20180623005740.43200-1-christopher.co@microsoft.com> <20180623005740.43200-2-christopher.co@microsoft.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E29D4B5@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E29D7EF@SHSMSX104.ccr.corp.intel.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E29DED3@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Tue, 26 Jun 2018 20:51:54 +0200 Message-ID: To: Chris Co Cc: "Gao, Liming" , Leif Lindholm , "edk2-devel@lists.01.org" , Charles Garcia-Tobin Subject: Re: [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL Toolchain support X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 26 Jun 2018 18:51:56 -0000 Content-Type: text/plain; charset="UTF-8" On 26 June 2018 at 20:42, Chris Co wrote: > > >> -----Original Message----- >> From: Ard Biesheuvel >> Sent: Tuesday, June 26, 2018 1:22 AM >> To: Gao, Liming >> Cc: Chris Co ; edk2-devel@lists.01.org; Leif >> Lindholm ; Charles Garcia-Tobin > Tobin@arm.com> >> Subject: Re: [edk2] [PATCH v2 1/1] BaseTools/tools_def: Add GCC49xASL >> Toolchain support >> >> On 26 June 2018 at 06:40, Gao, Liming wrote: >> > Chris: >> > Here is the example usage. You can add below [BuildOptions] in your >> platform DSC. Then, it will use override ASL path and flag. >> > >> > [BuildOptions] >> > *_*_*_ASL_PATH == C:\Asl\asl.exe >> > *_*_*_ASL_FLAGS == /MsftInternal >> > *_*_*_ASL_OUTFLAGS == /Fo= >> > >> >> I strongly prefer this over adding a new MS specific toolchain definition. >> > > Thanks Liming! I added these overrides and they works great. Since we can do platform dsc overrides, I also used it to override the objcopy_path and symrename_path which was the other change we needed for building on Windows. > GCC:*_*_*_OBJCOPY_PATH = noop > GCC:*_*_*_SYMRENAME_PATH = noop > > Ard, I agree this is the better method. We can drop this patch in favor of the platform dsc overrides. > > Leif, I tested GCC7.3 arm-eabi and ran into build errors. Found out this was an issue encountered before: https://bugs.linaro.org/show_bug.cgi?id=2909 > I made a couple modifications to Trim.py to fix the errors and was able to successfully build and test. Will submit the fix for review and update our toolchain to use GCC7.3 with GCC5 profile. > That is good news. So I guess we're all set to start incorporating this platform. Any clue whether there is also a device tree available for this platform? I would prefer it if we could make the firmware OS agnostic, rather than have Windows-only and Linux-only platforms in the edk2-platforms tree.