From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c06::243; helo=mail-io0-x243.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-io0-x243.google.com (mail-io0-x243.google.com [IPv6:2607:f8b0:4001:c06::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 190732034AB2C for ; Tue, 31 Oct 2017 01:23:16 -0700 (PDT) Received: by mail-io0-x243.google.com with SMTP id h70so33197434ioi.4 for ; Tue, 31 Oct 2017 01:27:08 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=rhwGGLIaBzCFytrwpPnInY1UodgFvmE5EJQ955TL8Zk=; b=eNCJ3t8s7ZaTkbTuecuOCOaoaVXUzOeWtrTPxajMG/cWmp9CkAffjwudLCHtdkQ4b5 XdDp8dAajrF3lh21AKmUy0HciG1975RO6u+wgnWBzuPTJaIknKimInJUBUPwsuHYQLIL ksD60zVVu4NRTdgOVDIsThB5DLMymtWQnIjBE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=rhwGGLIaBzCFytrwpPnInY1UodgFvmE5EJQ955TL8Zk=; b=ew72bkD85iC1n1mYp9pdwodPTqYg1qDo4wgPIP01Y15mjbVBQwq46X1e3ReXtInuEF XUUA4GZGRlpLDhgAa5dcVvdPQtLtLmlqycofhf83wYfVIoSQgn/7RfFcItT44Q892sL+ ySzJCFrvnDOgu+MV96hXmLSvp7k1nXgRttTTc64ROikc/Qve1/iwJom8R7dnVVwQKrUr 5+Ls7x/4Oao+XK7SQSgQQ61nVx+WPTov3EY1QWXsWuhjw00MERvW1TkE+kjRZntQHNs/ 7k2PZ37ntqjCbB1AiSyg2bgjZ/WfN4Q+4+f2BQHZM2W8TQwOZYdJhjS+m1HpOa4StRIl 7Ljw== X-Gm-Message-State: AMCzsaWRzY2+I24FceJj0+DaH9EAfz8wL5BbhDR2mJjq1uPNc4QnjlIH 8hoVmpB5bMwibfjHtYGK3fP0sXxjW4oiXG9GA+I2V+cedXk= X-Google-Smtp-Source: ABhQp+RNCQC8PjSBju0M0ZBgbeDrYanlh3sE7L/4uqWblQ1+jm2kq2l/lLsHcOtMJdRwMwoUqwgD+C4tvtIq1N7Gwpo= X-Received: by 10.36.233.133 with SMTP id f127mr2032412ith.34.1509438427821; Tue, 31 Oct 2017 01:27:07 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.131.167 with HTTP; Tue, 31 Oct 2017 01:27:07 -0700 (PDT) In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E175A32@SHSMSX104.ccr.corp.intel.com> References: <20171026101209.31630-1-ard.biesheuvel@linaro.org> <4A89E2EF3DFEDB4C8BFDE51014F606A14E175A32@SHSMSX104.ccr.corp.intel.com> From: Ard Biesheuvel Date: Tue, 31 Oct 2017 08:27:07 +0000 Message-ID: To: "Gao, Liming" Cc: "edk2-devel@lists.01.org" , "leif.lindholm@linaro.org" , "Zhu, Yonghong" Subject: Re: [PATCH] BaseTools/tools_def: suppress GCC predefined macros in DTB compilation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 31 Oct 2017 08:23:17 -0000 Content-Type: text/plain; charset="UTF-8" On 31 October 2017 at 05:41, Gao, Liming wrote: > Ard: > I have no other comments. > > Reviewed-by: Liming Gao > Thanks. I already pushed this as 8512fc5731df >>-----Original Message----- >>From: Ard Biesheuvel [mailto:ard.biesheuvel@linaro.org] >>Sent: Thursday, October 26, 2017 6:12 PM >>To: edk2-devel@lists.01.org >>Cc: leif.lindholm@linaro.org; Gao, Liming ; Zhu, >>Yonghong ; Ard Biesheuvel >> >>Subject: [PATCH] BaseTools/tools_def: suppress GCC predefined macros in >>DTB compilation >> >>The standard GCC preprocessor we use to preprocess device tree sources >>files has a whole bunch of macros predefined, among which >> >>This causes a property like 'linux,code' to be converted into '1,code' >>which is obviously wrong. So let's get rid of all the predefined macros >>by passing -undef to the preprocessor command line. >> >>Contributed-under: TianoCore Contribution Agreement 1.1 >>Signed-off-by: Ard Biesheuvel >>--- >> BaseTools/Conf/tools_def.template | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >>diff --git a/BaseTools/Conf/tools_def.template >>b/BaseTools/Conf/tools_def.template >>index df7c109438fd..98df0ffc9294 100755 >>--- a/BaseTools/Conf/tools_def.template >>+++ b/BaseTools/Conf/tools_def.template >>@@ -4369,7 +4369,7 @@ DEFINE GCC_VFRPP_FLAGS = -x c -E -P - >>DVFRCOMPILE --include $(DEST_DI >> DEFINE GCC_ASLPP_FLAGS = -x c -E -include AutoGen.h >> DEFINE GCC_ASLCC_FLAGS = -x c >> DEFINE GCC_WINDRES_FLAGS = -J rc -O coff >>-DEFINE GCC_DTCPP_FLAGS = -E -x assembler-with-cpp -imacros >>$(DEST_DIR_DEBUG)/AutoGen.h -nostdinc >>+DEFINE GCC_DTCPP_FLAGS = -E -x assembler-with-cpp -imacros >>$(DEST_DIR_DEBUG)/AutoGen.h -nostdinc -undef >> DEFINE GCC_IA32_RC_FLAGS = -I binary -O elf32-i386 -B i386 -- >>rename-section .data=.hii >> DEFINE GCC_X64_RC_FLAGS = -I binary -O elf64-x86-64 -B i386 -- >>rename-section .data=.hii >> DEFINE GCC_IPF_RC_FLAGS = -I binary -O elf64-ia64-little -B ia64 -- >>rename-section .data=.hii >>-- >>2.11.0 >