From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::22a; helo=mail-it0-x22a.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x22a.google.com (mail-it0-x22a.google.com [IPv6:2607:f8b0:4001:c0b::22a]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B8B9721BADAB2 for ; Wed, 18 Jul 2018 17:07:36 -0700 (PDT) Received: by mail-it0-x22a.google.com with SMTP id s7-v6so6682950itb.4 for ; Wed, 18 Jul 2018 17:07:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=zG9BARL2ucu8D7YQDkLnrLLrKtk1PlGarCOTpEdM51w=; b=VojQ4x818nAKf0KuWvV94TozXS2nOkT4ZN4KWBfmfjBtUo2ar18RJfQQ1YzkZKuN/o gHx6qdcXdm9q83gAX4XMSCIr/qguGr7LHcMQm+1oM0zQ7ASMoXmWCJC1fNuPUJ5OuOwi LCPz1lFjXWMYlIQ0tvo8aZ3/6T3vRin9v9vaw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=zG9BARL2ucu8D7YQDkLnrLLrKtk1PlGarCOTpEdM51w=; b=bEw7jmSofnHBEF3tSuU/AUtGv2uybjurYSw8J9BfcqcRsI+J6zcbQpbFGUG9oa8/7a Ty46JQT4Sbq96qRAhJetFsQeXihlkEzkrRD4cWTmLVPfsF4MLyZNMjSAr9dL1K1t0B/k 3e1bvKM53YNeKlMYmFvnqx0obf8yDtEnU90VcLJz+W1mXr63qW1Br5L/fEG/R9fgs1ae 93R8/VUa4RzcaIFHPLwzq0GBppe6DmEQsZs6jGSNRQmiPgq+uYX2R1KgA9CuqYwdKS8w aneLIdat6pwkrIj+vBSfKqO+7I0HJVXSTGQ5N2Eco9qrvr4G/GLF0rUWK9poHFF95IKg fFbQ== X-Gm-Message-State: AOUpUlFLcwqXHtyVd8fqUhqr328Jis3/aoN8eRe8O6ar0s1dc1GEu+ER 8PYz+++XfrGvfuuip6B7xPTAjvLVtH6mXbqMhkSI5g== X-Google-Smtp-Source: AAOMgpfu+mIoVRxZLW1bL1dJ7S9h8sG6YsGBz10UknUTxDOdbN5tHV3n21/i1p420DxQ1jiltDsEVguegZrr2Pp62Ho= X-Received: by 2002:a02:a1d9:: with SMTP id o25-v6mr7534549jah.86.1531958855542; Wed, 18 Jul 2018 17:07:35 -0700 (PDT) MIME-Version: 1.0 Received: by 2002:a6b:ac05:0:0:0:0:0 with HTTP; Wed, 18 Jul 2018 17:07:34 -0700 (PDT) In-Reply-To: References: <20180718205043.17574-1-lersek@redhat.com> From: Ard Biesheuvel Date: Thu, 19 Jul 2018 09:07:34 +0900 Message-ID: To: "Carsey, Jaben" Cc: Laszlo Ersek , edk2-devel-01 , "Ni, Ruiyu" , "Dong, Eric" , "Gao, Liming" , "Wu, Jiaxin" , "Yao, Jiewen" , "Zeng, Star" , "Kinney, Michael D" , "Fu, Siyuan" , "Zhang, Chao B" Subject: Re: [PATCH 0/6] UefiLib: centralize OpenFileByDevicePath() and fix its bugs X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 19 Jul 2018 00:07:37 -0000 Content-Type: text/plain; charset="UTF-8" On 19 July 2018 at 06:15, Carsey, Jaben wrote: > Reviewed-by: Jaben Carsey > > One question (do hold up push). Is there a reason to use the former over the latter? I use latter and I see you use the former. > > ASSERT(EFI_ERROR (Status)); > ASSERT_EFI_ERROR (Status); > The former asserts that an error has occurred, the latter does the opposite. It seems Laszlo is using this to ensure we don't end up in the error handling path if no error occurred. -- Ard. >> -----Original Message----- >> From: Laszlo Ersek [mailto:lersek@redhat.com] >> Sent: Wednesday, July 18, 2018 1:51 PM >> To: edk2-devel-01 >> Cc: Zhang, Chao B ; Dong, Eric >> ; Carsey, Jaben ; Wu, Jiaxin >> ; Yao, Jiewen ; Gao, Liming >> ; Kinney, Michael D ; >> Roman Bacik ; Ni, Ruiyu >> ; Fu, Siyuan ; Zeng, Star >> >> Subject: [PATCH 0/6] UefiLib: centralize OpenFileByDevicePath() and fix its >> bugs >> Importance: High >> >> Repo: https://github.com/lersek/edk2.git >> Branch: open_file_by_devpath_tiano_1008 >> >> This series addresses >> . >> >> In this version of the patch set, EfiOpenFileByDevicePath() is not added >> to the FrameworkUefiLib instance. If FrameworkUefiLib actually needs a >> definition of the function, I suggest that we add it once everybody >> agrees on the implementation. >> >> Tested with: >> >> - MdeModulePkg/RamDiskDxe: created a virtual disk from an ISO file, >> using the HII form; browsed the disk contents from the UEFI shell. >> >> - NetworkPkg/TlsAuthConfigDxe: loaded a CA certificate from a file via >> the HII form, successfully booted via HTTPSv4. >> >> - SecurityPkg/SecureBootConfigDxe: enrolled >> "MicCorKEKCA2011_2011-06-24.crt", "MicCorUEFCA2011_2011-06-27.crt", >> and "MicWinProPCA2011_2011-10-19.crt", using the HII form; verified >> Secure Boot with a Fedora guest. >> >> - ShellPkg/UefiShellLib: couldn't test the "old shell method" code path. >> Help with testing would be appreciated. >> >> Cc: Chao Zhang >> Cc: Eric Dong >> Cc: Jaben Carsey >> Cc: Jiaxin Wu >> Cc: Jiewen Yao >> Cc: Liming Gao >> Cc: Michael D Kinney >> Cc: Roman Bacik >> Cc: Ruiyu Ni >> Cc: Siyuan Fu >> Cc: Star Zeng >> >> Thanks, >> Laszlo >> >> Laszlo Ersek (6): >> MdePkg/UefiLib: introduce EfiOpenFileByDevicePath() >> MdeModulePkg/RamDiskDxe: replace OpenFileByDevicePath() with UefiLib >> API >> NetworkPkg/TlsAuthConfigDxe: replace OpenFileByDevicePath() with >> UefiLib API >> SecurityPkg/SecureBootConfigDxe: replace OpenFileByDevicePath() with >> UefiLib API >> ShellPkg/UefiShellLib: drop DeviceHandle param of >> ShellOpenFileByDevicePath() >> ShellPkg/UefiShellLib: rebase ShellOpenFileByDevicePath() to UefiLib >> API >> >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >> | 1 - >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskFileExplorer.c >> | 140 ------------ >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.c >> | 2 +- >> MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskImpl.h >> | 39 ---- >> MdePkg/Include/Library/UefiLib.h | 86 ++++++++ >> MdePkg/Library/UefiLib/UefiLib.c | 226 >> ++++++++++++++++++++ >> MdePkg/Library/UefiLib/UefiLib.inf | 1 + >> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigDxe.inf | 1 >> - >> NetworkPkg/TlsAuthConfigDxe/TlsAuthConfigImpl.c | 141 >> +----------- >> >> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi >> gDxe.inf | 1 - >> >> SecurityPkg/VariableAuthenticated/SecureBootConfigDxe/SecureBootConfi >> gFileExplorer.c | 151 +------------ >> ShellPkg/Include/Library/ShellLib.h | 2 - >> ShellPkg/Library/UefiShellLib/UefiShellLib.c | 118 +------- >> -- >> ShellPkg/Library/UefiShellLib/UefiShellLib.inf | 3 +- >> 14 files changed, 321 insertions(+), 591 deletions(-) >> >> -- >> 2.14.1.3.gb7cf6e02401b > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel