* [PATCH] ArmPkg: copy/paste fixes in ARM ArmHvcLib/ArmSmcLib
@ 2017-04-12 20:22 Leif Lindholm
2017-04-13 7:32 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2017-04-12 20:22 UTC (permalink / raw)
To: edk2-devel; +Cc: ard.biesheuvel
ARM ArmHvcLib looks like it was created from copy of ArmSmcLib which
looks like it was created from a copy of the AArch64 version.
Both of these files include AsmMacroIoLibV8.h instead of
AsmMacroIoLib.h, although since they only use macros that are identical
between the two, there was no functional issue caused by this.
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
---
ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S | 2 +-
ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
index be4693796f..fef51e7521 100644
--- a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
+++ b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
@@ -12,7 +12,7 @@
//
//
-#include <AsmMacroIoLibV8.h>
+#include <AsmMacroIoLib.h>
.arch_extension virt
diff --git a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
index afb2e9bc90..990e12ef75 100644
--- a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
+++ b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
@@ -11,7 +11,7 @@
//
//
-#include <AsmMacroIoLibV8.h>
+#include <AsmMacroIoLib.h>
.arch_extension sec
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg: copy/paste fixes in ARM ArmHvcLib/ArmSmcLib
2017-04-12 20:22 [PATCH] ArmPkg: copy/paste fixes in ARM ArmHvcLib/ArmSmcLib Leif Lindholm
@ 2017-04-13 7:32 ` Ard Biesheuvel
2017-04-13 9:59 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2017-04-13 7:32 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On 12 April 2017 at 21:22, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> ARM ArmHvcLib looks like it was created from copy of ArmSmcLib which
> looks like it was created from a copy of the AArch64 version.
>
> Both of these files include AsmMacroIoLibV8.h instead of
> AsmMacroIoLib.h, although since they only use macros that are identical
> between the two, there was no functional issue caused by this.
>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> ---
> ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S | 2 +-
> ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
> index be4693796f..fef51e7521 100644
> --- a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
> +++ b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
> @@ -12,7 +12,7 @@
> //
> //
>
> -#include <AsmMacroIoLibV8.h>
> +#include <AsmMacroIoLib.h>
>
> .arch_extension virt
>
> diff --git a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
> index afb2e9bc90..990e12ef75 100644
> --- a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
> +++ b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
> @@ -11,7 +11,7 @@
> //
> //
>
> -#include <AsmMacroIoLibV8.h>
> +#include <AsmMacroIoLib.h>
>
> .arch_extension sec
>
> --
> 2.11.0
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg: copy/paste fixes in ARM ArmHvcLib/ArmSmcLib
2017-04-13 7:32 ` Ard Biesheuvel
@ 2017-04-13 9:59 ` Leif Lindholm
0 siblings, 0 replies; 3+ messages in thread
From: Leif Lindholm @ 2017-04-13 9:59 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel@lists.01.org
On Thu, Apr 13, 2017 at 08:32:32AM +0100, Ard Biesheuvel wrote:
> On 12 April 2017 at 21:22, Leif Lindholm <leif.lindholm@linaro.org> wrote:
> > ARM ArmHvcLib looks like it was created from copy of ArmSmcLib which
> > looks like it was created from a copy of the AArch64 version.
> >
> > Both of these files include AsmMacroIoLibV8.h instead of
> > AsmMacroIoLib.h, although since they only use macros that are identical
> > between the two, there was no functional issue caused by this.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Leif Lindholm <leif.lindholm@linaro.org>
>
> Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Thanks!
Pushed as d63ed30.
> > ---
> > ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S | 2 +-
> > ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S | 2 +-
> > 2 files changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
> > index be4693796f..fef51e7521 100644
> > --- a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
> > +++ b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S
> > @@ -12,7 +12,7 @@
> > //
> > //
> >
> > -#include <AsmMacroIoLibV8.h>
> > +#include <AsmMacroIoLib.h>
> >
> > .arch_extension virt
> >
> > diff --git a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
> > index afb2e9bc90..990e12ef75 100644
> > --- a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
> > +++ b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S
> > @@ -11,7 +11,7 @@
> > //
> > //
> >
> > -#include <AsmMacroIoLibV8.h>
> > +#include <AsmMacroIoLib.h>
> >
> > .arch_extension sec
> >
> > --
> > 2.11.0
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-04-13 9:59 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-04-12 20:22 [PATCH] ArmPkg: copy/paste fixes in ARM ArmHvcLib/ArmSmcLib Leif Lindholm
2017-04-13 7:32 ` Ard Biesheuvel
2017-04-13 9:59 ` Leif Lindholm
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox