From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x234.google.com (mail-io0-x234.google.com [IPv6:2607:f8b0:4001:c06::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E0FD52194EB71 for ; Thu, 13 Apr 2017 00:32:33 -0700 (PDT) Received: by mail-io0-x234.google.com with SMTP id r16so67833402ioi.2 for ; Thu, 13 Apr 2017 00:32:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=bOu/f2YjcN3o4QblJuxlUs6PFcP/++ucAyL3Na20m4I=; b=jPY4fPPS88dLShl7SD/GvWNHlNTqGyV31AV1aHSUw/nEUuiN7fueo+wC60tCHzDGV2 ywJJwQG+1lWKbnOJvX1S/becfUZRZVgLgyqcIAUo/3st9d3rZ8Mj/oerlJn8YN5ygMfu XwT0uIrB6oG6qNAeuSUaD7vx2gSW/L5e2Oqxs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=bOu/f2YjcN3o4QblJuxlUs6PFcP/++ucAyL3Na20m4I=; b=c62d4hWivbmtoiaFIHSzfi++uf7oEM5uaIIrrtgxvrXt0ldGM8luD+a9pxx+hoHzgj Hrymljm5qGXwR9bJQ56FXENfiHf54Hd3/2aiTnR5NAK0mr0yMH2uQkh8i6zGjGk6n3Qu RSKGjuaVmog0pY8sBlZeSXjdccyjqVc/Sl7EJI5yd5u+2y7/zUbOTYEWSDay4y0Qkk+9 wlvJtF5Nl/BRvHt1E0f/0mFYAid+PTKZFVSTcJtIvfhUjsKsUXsyE8TvxDB1clU4ArsS qa0f+3dKzOG0UAStb88zDW6Vgz7FixQrlBQpt0oGThsO4ZktmIwfhWw5kU6nKoxCyPIq qQ1g== X-Gm-Message-State: AN3rC/6hDYSKN7NqL3G61bo3dnC0VDm0Vb3zWXn1PjEqN7nS3eXZ1eQ1 dn5RmR6fBxeR3+xQVNKsojRqnyQuCCs+ X-Received: by 10.36.160.133 with SMTP id o127mr17868154ite.37.1492068753214; Thu, 13 Apr 2017 00:32:33 -0700 (PDT) MIME-Version: 1.0 Received: by 10.107.201.76 with HTTP; Thu, 13 Apr 2017 00:32:32 -0700 (PDT) In-Reply-To: <20170412202229.28396-1-leif.lindholm@linaro.org> References: <20170412202229.28396-1-leif.lindholm@linaro.org> From: Ard Biesheuvel Date: Thu, 13 Apr 2017 08:32:32 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg: copy/paste fixes in ARM ArmHvcLib/ArmSmcLib X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 13 Apr 2017 07:32:34 -0000 Content-Type: text/plain; charset=UTF-8 On 12 April 2017 at 21:22, Leif Lindholm wrote: > ARM ArmHvcLib looks like it was created from copy of ArmSmcLib which > looks like it was created from a copy of the AArch64 version. > > Both of these files include AsmMacroIoLibV8.h instead of > AsmMacroIoLib.h, although since they only use macros that are identical > between the two, there was no functional issue caused by this. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Leif Lindholm Reviewed-by: Ard Biesheuvel > --- > ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S | 2 +- > ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S > index be4693796f..fef51e7521 100644 > --- a/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S > +++ b/ArmPkg/Library/ArmHvcLib/Arm/ArmHvc.S > @@ -12,7 +12,7 @@ > // > // > > -#include > +#include > > .arch_extension virt > > diff --git a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S > index afb2e9bc90..990e12ef75 100644 > --- a/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S > +++ b/ArmPkg/Library/ArmSmcLib/Arm/ArmSmc.S > @@ -11,7 +11,7 @@ > // > // > > -#include > +#include > > .arch_extension sec > > -- > 2.11.0 >