public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: Leif Lindholm <leif.lindholm@linaro.org>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include
Date: Thu, 17 Jan 2019 10:38:13 +0100	[thread overview]
Message-ID: <CAKv+Gu_hMUsuCRrx7TPu2DKNwHBDJQfVeo2pfk2Gis3GCUTW3A@mail.gmail.com> (raw)
In-Reply-To: <20190117093611.yefkrgbl4wpbx4vf@bivouac.eciton.net>

On Thu, 17 Jan 2019 at 10:36, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote:
> > Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console
> > if available") added calls to AsciiPrint() to the default exception
> > handler code, but the ARM version did not include UefiLib.h yet
> > (even though the .INF declares it unconditionally), resulting in
> > build breakage. So add the missing include.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>

Thanks

Pushed as 3837e2e03840..00755e1c8019

> > ---
> >  ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 +
> >  1 file changed, 1 insertion(+)
> >
> > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > index 2e0cfb2d4e03..476ec2061084 100644
> > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > @@ -22,6 +22,7 @@
> >  #include <Library/ArmDisassemblerLib.h>
> >  #include <Library/SerialPortLib.h>
> >  #include <Library/UefiBootServicesTableLib.h>
> > +#include <Library/UefiLib.h>
> >
> >  #include <Guid/DebugImageInfoTable.h>
> >
> > --
> > 2.17.1
> >


      reply	other threads:[~2019-01-17  9:38 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-01-16 20:50 [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include Ard Biesheuvel
2019-01-17  9:36 ` Leif Lindholm
2019-01-17  9:38   ` Ard Biesheuvel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_hMUsuCRrx7TPu2DKNwHBDJQfVeo2pfk2Gis3GCUTW3A@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox