* [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include
@ 2019-01-16 20:50 Ard Biesheuvel
2019-01-17 9:36 ` Leif Lindholm
0 siblings, 1 reply; 3+ messages in thread
From: Ard Biesheuvel @ 2019-01-16 20:50 UTC (permalink / raw)
To: edk2-devel
Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console
if available") added calls to AsciiPrint() to the default exception
handler code, but the ARM version did not include UefiLib.h yet
(even though the .INF declares it unconditionally), resulting in
build breakage. So add the missing include.
Contributed-under: TianoCore Contribution Agreement 1.1
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
index 2e0cfb2d4e03..476ec2061084 100644
--- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
+++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
@@ -22,6 +22,7 @@
#include <Library/ArmDisassemblerLib.h>
#include <Library/SerialPortLib.h>
#include <Library/UefiBootServicesTableLib.h>
+#include <Library/UefiLib.h>
#include <Guid/DebugImageInfoTable.h>
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include
2019-01-16 20:50 [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include Ard Biesheuvel
@ 2019-01-17 9:36 ` Leif Lindholm
2019-01-17 9:38 ` Ard Biesheuvel
0 siblings, 1 reply; 3+ messages in thread
From: Leif Lindholm @ 2019-01-17 9:36 UTC (permalink / raw)
To: Ard Biesheuvel; +Cc: edk2-devel
On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote:
> Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console
> if available") added calls to AsciiPrint() to the default exception
> handler code, but the ARM version did not include UefiLib.h yet
> (even though the .INF declares it unconditionally), resulting in
> build breakage. So add the missing include.
>
> Contributed-under: TianoCore Contribution Agreement 1.1
> Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
> ---
> ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> index 2e0cfb2d4e03..476ec2061084 100644
> --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> @@ -22,6 +22,7 @@
> #include <Library/ArmDisassemblerLib.h>
> #include <Library/SerialPortLib.h>
> #include <Library/UefiBootServicesTableLib.h>
> +#include <Library/UefiLib.h>
>
> #include <Guid/DebugImageInfoTable.h>
>
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include
2019-01-17 9:36 ` Leif Lindholm
@ 2019-01-17 9:38 ` Ard Biesheuvel
0 siblings, 0 replies; 3+ messages in thread
From: Ard Biesheuvel @ 2019-01-17 9:38 UTC (permalink / raw)
To: Leif Lindholm; +Cc: edk2-devel@lists.01.org
On Thu, 17 Jan 2019 at 10:36, Leif Lindholm <leif.lindholm@linaro.org> wrote:
>
> On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote:
> > Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console
> > if available") added calls to AsciiPrint() to the default exception
> > handler code, but the ARM version did not include UefiLib.h yet
> > (even though the .INF declares it unconditionally), resulting in
> > build breakage. So add the missing include.
> >
> > Contributed-under: TianoCore Contribution Agreement 1.1
> > Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>
> Reviewed-by: Leif Lindholm <leif.lindholm@linaro.org>
>
Thanks
Pushed as 3837e2e03840..00755e1c8019
> > ---
> > ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > index 2e0cfb2d4e03..476ec2061084 100644
> > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c
> > @@ -22,6 +22,7 @@
> > #include <Library/ArmDisassemblerLib.h>
> > #include <Library/SerialPortLib.h>
> > #include <Library/UefiBootServicesTableLib.h>
> > +#include <Library/UefiLib.h>
> >
> > #include <Guid/DebugImageInfoTable.h>
> >
> > --
> > 2.17.1
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-17 9:38 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2019-01-16 20:50 [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include Ard Biesheuvel
2019-01-17 9:36 ` Leif Lindholm
2019-01-17 9:38 ` Ard Biesheuvel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox