From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4864:20::141; helo=mail-it1-x141.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it1-x141.google.com (mail-it1-x141.google.com [IPv6:2607:f8b0:4864:20::141]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7C817211B6C3F for ; Thu, 17 Jan 2019 01:38:26 -0800 (PST) Received: by mail-it1-x141.google.com with SMTP id a6so293837itl.4 for ; Thu, 17 Jan 2019 01:38:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YoNfe8NonyROJj6U36SJcEXnXxcTqx5zUBD+jSDRbFQ=; b=Ubma40RTzHmb3I44u745lt0bo09bwTWzMYKrqgPUnPhR2VKEySKZSGNJdMQ7+C0yPH YYCnkFCuIhOxDF/2YE+k8pQV1QVwca8KR5jmj29P5BWSE02VehXcpTgNgyBjHAd5OHvZ jSHsiWARYsTpA18UJfyQd3H9VAGwgxhkdkC68= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YoNfe8NonyROJj6U36SJcEXnXxcTqx5zUBD+jSDRbFQ=; b=a3xkp74Ut/EaQC2h7IOzB4B8kXdZ0v1OP1ft0BfuBCr/gI6pXoV8vzF4sL1pyDuhYN 7Pp3R1z9bksNNtEdFvBN8M4B+mWLOclxQcwgyIvgV+LtRbwcQ+rTT/+V0WTXi6CykcmL Gia6obY4CcxSL3IgR8E4EiUHQjpISuhlc+5zsN8HRM4IvfhwtlTJBf8yGFXZESjys+nL mNEPIqwpFGnQs7hhk0GK/OTQH4CrR7jikgLD2nAoN+Ga7qxJAF9e6+ZljaaBrL74q71P dfRXnBJvOQjPES9rEaySnBitWg7g/J8WOUEZPGjctwp9D1bx2cG/sPfTaYSC6Ox7UnN7 KVrA== X-Gm-Message-State: AJcUukdiIhT8omjgguXti9QXktAlL2zOvVsE3Wrw4EDZ9L026aIFyZXb GT18zzy8PNqxEYS7oeF69d2O+7HXsI+m49DwudVdRw== X-Google-Smtp-Source: ALg8bN7a7eRruhf/k5OhUIXQugOB2JBKIMXUN2J7OmUjH8Eu4Ep1240Lr3UjURFUKQq2QXkwdB1w3IEnxUv75wtOrUE= X-Received: by 2002:a24:710:: with SMTP id f16mr7056943itf.121.1547717905663; Thu, 17 Jan 2019 01:38:25 -0800 (PST) MIME-Version: 1.0 References: <20190116205059.3488-1-ard.biesheuvel@linaro.org> <20190117093611.yefkrgbl4wpbx4vf@bivouac.eciton.net> In-Reply-To: <20190117093611.yefkrgbl4wpbx4vf@bivouac.eciton.net> From: Ard Biesheuvel Date: Thu, 17 Jan 2019 10:38:13 +0100 Message-ID: To: Leif Lindholm Cc: "edk2-devel@lists.01.org" Subject: Re: [PATCH] ArmPkg/DefaultExceptionHandlerLib: add missing UefiLib include X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 17 Jan 2019 09:38:26 -0000 Content-Type: text/plain; charset="UTF-8" On Thu, 17 Jan 2019 at 10:36, Leif Lindholm wrote: > > On Wed, Jan 16, 2019 at 09:50:59PM +0100, Ard Biesheuvel wrote: > > Commit 31f5388006fc ("ArmPkg/DefaultExceptionHandlerLib: use console > > if available") added calls to AsciiPrint() to the default exception > > handler code, but the ARM version did not include UefiLib.h yet > > (even though the .INF declares it unconditionally), resulting in > > build breakage. So add the missing include. > > > > Contributed-under: TianoCore Contribution Agreement 1.1 > > Signed-off-by: Ard Biesheuvel > > Reviewed-by: Leif Lindholm > Thanks Pushed as 3837e2e03840..00755e1c8019 > > --- > > ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > > index 2e0cfb2d4e03..476ec2061084 100644 > > --- a/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > > +++ b/ArmPkg/Library/DefaultExceptionHandlerLib/Arm/DefaultExceptionHandler.c > > @@ -22,6 +22,7 @@ > > #include > > #include > > #include > > +#include > > > > #include > > > > -- > > 2.17.1 > >