From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22b.google.com (mail-io0-x22b.google.com [IPv6:2607:f8b0:4001:c06::22b]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7884C821B9 for ; Wed, 1 Mar 2017 03:46:37 -0800 (PST) Received: by mail-io0-x22b.google.com with SMTP id 90so29120333ios.1 for ; Wed, 01 Mar 2017 03:46:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=DoqoLt3rPTJjfZeNrdoRA6qiBtDqKEvS10TZiR0kA8Q=; b=C2r2p5nfvuSYVrWKBMnaawp++ZoQuVmMKVlrt/w72qLN3wwbiYIl5F4/SviBqERkNA pwCnP05OswonsaGo6ebVRRmGRTJdxk5etk+0JLOcPdGu23OZxqebCwwY8GVgT7SeuGsv cvXTBSSgm3qd3Svb78WMQfoxLu4LTZcBBPRgg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=DoqoLt3rPTJjfZeNrdoRA6qiBtDqKEvS10TZiR0kA8Q=; b=VZtDaeTbHd9pIbsyYV9yNGQ7koj56MMZie+zwLI202BJTfQP6xEGOaGruwkypjMH70 t6D3k9y+rC6ujK/OgSs2sIY1z+0S2KPVHNTVfZ02sLcuvsdBfL/pQ3Gw+Z9HCiLoh5J6 XXCuoxCRHNFrpuDBIHgQetyW5Pm3Kpp71pzxZAnch7gnJBh+6q2jHXryphNCfSpA4gQY YwQ0EpSgxY6hlB/9cn2OMs9M7DSBSkBEBOv4BJrMSWVoj1Kk/lVX8TzSx8myaDU94qCS SZXQKseeXzOL155UEF0sTCGYsuKKztqvpZr1Fsst5LHWu7fzheHUV+jw8ABGChJTgX4S gJmQ== X-Gm-Message-State: AMke39lmCfmrc9Vb8zdTy8HDAbGcKMyA4uvjhzNVmijN615NkHifundiPtD6MTs8x/9cspHQ9vsdIrX7pqVldPl6 X-Received: by 10.107.168.21 with SMTP id r21mr7553306ioe.45.1488368796866; Wed, 01 Mar 2017 03:46:36 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.10.27 with HTTP; Wed, 1 Mar 2017 03:46:36 -0800 (PST) In-Reply-To: <8083aa5e-fe40-4096-3ee1-25623e7bf533@redhat.com> References: <1488355525-29098-1-git-send-email-ard.biesheuvel@linaro.org> <8083aa5e-fe40-4096-3ee1-25623e7bf533@redhat.com> From: Ard Biesheuvel Date: Wed, 1 Mar 2017 11:46:36 +0000 Message-ID: To: Laszlo Ersek Cc: "edk2-devel@lists.01.org" , Ruiyu Ni Subject: Re: [PATCH] ArmVirtPkg: move UefiBootManagerLib resolution to ArmVirt.dsc.inc X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 01 Mar 2017 11:46:37 -0000 Content-Type: text/plain; charset=UTF-8 On 1 March 2017 at 09:27, Laszlo Ersek wrote: > On 03/01/17 09:05, Ard Biesheuvel wrote: >> Recent changes to ShellPkg require a resolution for UefiBootManagerLib >> for all platforms in ArmVirtPkg. So move the resolution to the shared >> include ArmVirt.dsc.inc. >> >> Contributed-under: TianoCore Contribution Agreement 1.0 >> Signed-off-by: Ard Biesheuvel >> --- >> ArmVirtPkg/ArmVirt.dsc.inc | 1 + >> ArmVirtPkg/ArmVirtQemu.dsc | 1 - >> ArmVirtPkg/ArmVirtQemuKernel.dsc | 1 - >> 3 files changed, 1 insertion(+), 2 deletions(-) >> >> diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc >> index d40ea69b072d..2b0a44e14d24 100644 >> --- a/ArmVirtPkg/ArmVirt.dsc.inc >> +++ b/ArmVirtPkg/ArmVirt.dsc.inc >> @@ -151,6 +151,7 @@ [LibraryClasses.common] >> AuthVariableLib|MdeModulePkg/Library/AuthVariableLibNull/AuthVariableLibNull.inf >> !endif >> VarCheckLib|MdeModulePkg/Library/VarCheckLib/VarCheckLib.inf >> + UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >> >> [LibraryClasses.common.SEC] >> PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf >> diff --git a/ArmVirtPkg/ArmVirtQemu.dsc b/ArmVirtPkg/ArmVirtQemu.dsc >> index 00cdd7c20201..615e1fca4877 100644 >> --- a/ArmVirtPkg/ArmVirtQemu.dsc >> +++ b/ArmVirtPkg/ArmVirtQemu.dsc >> @@ -60,7 +60,6 @@ [LibraryClasses.common] >> NorFlashPlatformLib|ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.inf >> >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> - UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >> BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >> PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf >> diff --git a/ArmVirtPkg/ArmVirtQemuKernel.dsc b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> index 8354b13ddb1a..e4902690123c 100644 >> --- a/ArmVirtPkg/ArmVirtQemuKernel.dsc >> +++ b/ArmVirtPkg/ArmVirtQemuKernel.dsc >> @@ -59,7 +59,6 @@ [LibraryClasses.common] >> NorFlashPlatformLib|ArmVirtPkg/Library/NorFlashQemuLib/NorFlashQemuLib.inf >> >> CapsuleLib|MdeModulePkg/Library/DxeCapsuleLibNull/DxeCapsuleLibNull.inf >> - UefiBootManagerLib|MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf >> BootLogoLib|MdeModulePkg/Library/BootLogoLib/BootLogoLib.inf >> PlatformBootManagerLib|ArmVirtPkg/Library/PlatformBootManagerLib/PlatformBootManagerLib.inf >> CustomizedDisplayLib|MdeModulePkg/Library/CustomizedDisplayLib/CustomizedDisplayLib.inf >> > > Reviewed-by: Laszlo Ersek Pushed, thanks.