From mboxrd@z Thu Jan  1 00:00:00 1970
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@linaro.org header.s=google header.b=iD2aVFQp;
 spf=pass (domain: linaro.org, ip: 209.85.221.45, mailfrom: ard.biesheuvel@linaro.org)
Received: from mail-wr1-f45.google.com (mail-wr1-f45.google.com [209.85.221.45])
 by groups.io with SMTP; Mon, 16 Sep 2019 23:29:09 -0700
Received: by mail-wr1-f45.google.com with SMTP id o18so1702937wrv.13
        for <devel@edk2.groups.io>; Mon, 16 Sep 2019 23:29:08 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=linaro.org; s=google;
        h=mime-version:references:in-reply-to:from:date:message-id:subject:to
         :cc;
        bh=PAW1fix5dR6uR2rrglOSPX0D1mhGEpSF1HqSfCVaEPc=;
        b=iD2aVFQpZfo9f54MOtrT80IAQVEMyr7a8NY36H5bE75WAKnUs9BYUIGV+B8tQqJoOx
         9zFHpy9mlQvZ6IwrvIah1FnFTXPx0xjlU9foaeLmEUT2g9XHaArlhBJfAIu8eGk87ZuC
         1FSS6ghkeUpooiVe7oCUKp5mMGwQa2zOY7vKTnEb4mkY6aqtNElwZ8sraEbg2KOAVHZ/
         wYqEC76EF15fdReTquD3b8BdJ+ufZAkE+prUY2gDsWKlH7EuU61baqQvlJ3XCuoLTwRI
         ZlM4Gkm+gAX/fxmSbTVnajZ/MQ6hupp9OTLlOqBDCHYuPiNbKNaRvSZVW7xjstWgR8xo
         8TBw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
        d=1e100.net; s=20161025;
        h=x-gm-message-state:mime-version:references:in-reply-to:from:date
         :message-id:subject:to:cc;
        bh=PAW1fix5dR6uR2rrglOSPX0D1mhGEpSF1HqSfCVaEPc=;
        b=p4fYMbhYKYN1tBI58pKbKcCd8YDfyDOo+pzKBiOw8CQ/M1BHW2b1LI/NtCE/QB1ZY5
         W91iZ2EhjE2tW/kcwnB6IYSt3PA9R8aawIRfqAwkdlAOIlG17ZHiRK89LHbphpQ9C8ZH
         T5RrmNl3FgV/zSCZs0pGLiNyZAMa4+Qa9c0EhAuMhbRNe7MXRBVCO5pT2UvjL+DN9xAA
         Mnml7ooteJnv51TOplDRyRsltFeTc3iS1KvaL62wm+fvl47+0EAFcOGo3p2uTTf+B3AC
         FBOHVCPKNJq3chNeCuZe/Oi6OXjfHK7UYoJPQ/g5bva1DnWIEWMyZHqqYrZJAWU/P4pi
         7d3g==
X-Gm-Message-State: APjAAAVHM4dDPTipUPgyUYlDuP7VtR9COm0l4+39s/RwgiqyftLTXrJW
	pdAl1QM2YU+lLJi/AEYbVfCJI62bRSoUQ3yrcMCCtg==
X-Google-Smtp-Source: APXvYqx+qFZMSwf7FZ9OI/3K65M6urEa5QQvB66DHEKb7ekeSfoM7uTPr5vhWKSJGYBUkHW8NsfHLgCXhSavDg9U5rg=
X-Received: by 2002:a05:6000:82:: with SMTP id m2mr1605234wrx.241.1568701747207;
 Mon, 16 Sep 2019 23:29:07 -0700 (PDT)
MIME-Version: 1.0
References: <20190917061912.17420-1-zhichao.gao@intel.com>
In-Reply-To: <20190917061912.17420-1-zhichao.gao@intel.com>
From: "Ard Biesheuvel" <ard.biesheuvel@linaro.org>
Date: Tue, 17 Sep 2019 07:28:42 +0100
Message-ID: <CAKv+Gu_iyxTbf3mNa1QW6K+Qny1tp604WAoBOdSczk9tNOthAw@mail.gmail.com>
Subject: Re: [edk2-devel] [PATCH V2 0/3] MdeModulePkg/TerminalConsole: Extend the support terminal types
To: "Gao, Zhichao" <zhichao.gao@intel.com>
Cc: edk2-devel-groups-io <devel@edk2.groups.io>, Jian J Wang <jian.j.wang@intel.com>, 
	Hao A Wu <hao.a.wu@intel.com>, Ray Ni <ray.ni@intel.com>, Laszlo Ersek <lersek@redhat.com>, 
	Liming Gao <liming.gao@intel.com>
Content-Type: text/plain; charset="UTF-8"

On Tue, 17 Sep 2019 at 07:22, Gao, Zhichao <zhichao.gao@intel.com> wrote:
>
> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=2186
>
> Putty is a very popular terminal tool in windows. So add the whole support
> terminal keyboard type for it. The new introduced type is Linux, XtermR6,
> VT400 and SCO. And enhance the support for VT100+.
> This patch set only add the support of function key. Refer to the link:
> https://www.ssh.com/ssh/putty/putty-manuals/0.68/Chapter4.html#config-funkeys
>
> V2:
> Fix typo.
> Merge the type guid defination into TtyTerm.h.
>

Hello Zhichao,

Since you already pushed the broken patch, you should really be
posting an updated patch with just the fix.

In any case, this makes me wonder how you tested this code, since it
won't even build. Could you elaborate?

-- 
Ard.


> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Ray Ni <ray.ni@intel.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-of-by: Zhichao Gao <zhichao.gao@intel.com>
>
> Zhichao Gao (3):
>   MdeModulePkg: Extend the support keyboard type of Terminal console
>   MdeModulePkg/TerminalDxe: Extend the terminal console support types
>   MdeModulePkg/BM_UI: Add the new terminal types to related menu
>
>  MdeModulePkg/Include/Guid/TtyTerm.h           |  13 +
>  .../BootMaintenanceManager.h                  |  12 +-
>  .../BootMaintenanceManagerStrings.uni         |  10 +-
>  .../ConsoleOption.c                           |  35 +--
>  .../BootMaintenanceManagerUiLib/Data.c        |  16 +-
>  MdeModulePkg/MdeModulePkg.dec                 |   4 +
>  .../Universal/Console/TerminalDxe/Terminal.c  |  17 +-
>  .../Universal/Console/TerminalDxe/Terminal.h  |  37 ++-
>  .../Console/TerminalDxe/TerminalConIn.c       | 281 ++++++++++++++++--
>  .../Console/TerminalDxe/TerminalConOut.c      |   4 +
>  .../Console/TerminalDxe/TerminalDxe.inf       |   6 +-
>  11 files changed, 375 insertions(+), 60 deletions(-)
>
> --
> 2.21.0.windows.1
>
>
> 
>