public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Ard Biesheuvel <ard.biesheuvel@linaro.org>
To: "Gao, Liming" <liming.gao@intel.com>
Cc: "edk2-devel@lists.01.org" <edk2-devel@lists.01.org>,
	"lersek@redhat.com" <lersek@redhat.com>,
	 "Shi, Steven" <steven.shi@intel.com>,
	"Zhu, Yonghong" <yonghong.zhu@intel.com>,
	"Justen, Jordan L" <jordan.l.justen@intel.com>,
	 "leif.lindholm@linaro.org" <leif.lindholm@linaro.org>
Subject: Re: [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode
Date: Mon, 1 Aug 2016 08:03:06 +0200	[thread overview]
Message-ID: <CAKv+Gu_jNbD002e5528+cwUJ73MFFBT3JT64i2KM3C0QC9qomw@mail.gmail.com> (raw)
In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A1155E2CFC@shsmsx102.ccr.corp.intel.com>

On 1 August 2016 at 04:26, Gao, Liming <liming.gao@intel.com> wrote:
> Ard:
>  My GNU ld (GNU Binutils for Ubuntu) 2.24. Which version you use?
>
> 1. #pragma GCC visibility push (hidden) , GCC5 with GCC49 tool chain pass. GCC5 with GCC5 tool chain failure. Here is failure message.
> GenFw: Elf64Convert.c:424: ScanSections64: Assertion `((BOOLEAN)(0==1))' failed.
> GenFw: ERROR 3000: Invalid
>   Did not find any '.text' section.
> Aborted (core dumped)
>
> 2. #pragma GCC visibility push (protected), GCC5 with GCC49 tool chain failure, GCC5 with GCC5 tool chain pass. Failure message is below.
>

Thanks for checking. The problem with GCC5 is that the fact that
'_ModuleEntryPoint' is also hidden, which confuses the LTO code and
makes it eliminate all input objects. I think this is a bug in LTO,
since the entry point is passed explicitly to the linker using the -e
option. But we still need to work around it.

Since the current issue (#2) is a problem with GCC49, I will propose a
separate patch to fix it by changing the 'protected' to 'hidden'. I
will then add a patch to my GCC5 series as well to work around the LTO
problem.

Thanks,
Ard.


  reply	other threads:[~2016-08-01  6:03 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1469618017-6534-1-git-send-email-ard.biesheuvel@linaro.org>
2016-07-29  4:47 ` [PATCH v4 0/7] BaseTools: add support for GCC5 in LTO mode Gao, Liming
2016-07-29  6:09   ` Ard Biesheuvel
2016-07-29  6:40     ` Ard Biesheuvel
2016-07-29 15:18       ` Gao, Liming
2016-07-29 18:21         ` Ard Biesheuvel
2016-07-30 14:34         ` Ard Biesheuvel
2016-07-31 19:04           ` Ard Biesheuvel
2016-08-01  2:26             ` Gao, Liming
2016-08-01  6:03               ` Ard Biesheuvel [this message]
2016-07-29 20:33     ` Jordan Justen
2016-07-30  9:22       ` Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAKv+Gu_jNbD002e5528+cwUJ73MFFBT3JT64i2KM3C0QC9qomw@mail.gmail.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox