From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-io0-x22f.google.com (mail-io0-x22f.google.com [IPv6:2607:f8b0:4001:c06::22f]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8652C82096 for ; Mon, 19 Dec 2016 05:44:01 -0800 (PST) Received: by mail-io0-x22f.google.com with SMTP id h30so152413006iod.2 for ; Mon, 19 Dec 2016 05:44:01 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=7GCTA8MzChptz6zYvJZgk9v9kVwzSnG/daStlHcHw6k=; b=XD/iMOd0Rgt0oyh32+TV/5le3PbMzb1N5s0E38JiovtH64+41Xg+ZZOsfqKVrJAC+Q WfclafgULSpRbRIB8AL6gnIB+hU+gu7+/PP2UyQ/u5C8Iw/wNcLN2XLpb3goUsM/QBf1 ewdgXgzSJw/KkAeUEFu0mEWFYPT6LH1EwzkHc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=7GCTA8MzChptz6zYvJZgk9v9kVwzSnG/daStlHcHw6k=; b=bcknuGnSypdhB8Mq3YXjJ8YjuS0oezsHIV8gUq50XqS6CVY+nZywjpzsned2VJNfSP kpxQ3yUz0lssy3xmKlcohwYKM7WHupByoP/44BAExWsKmazMQ4HWTncI7Esr8gsjuGtx 37LtfLuporaUuV9K7VIv6uD/DiU/Mbx5n2dSKBYhvy1XG9SQWF+y+9pKR9Ha5KKji9FD 2qO2eSJCNgOjS0Qj/S2uD+sdGtFSbTtvYNXkPkJwpYpDC8gtGTTo6gSpisTgGvC6Pltt teEOxOqwvp2S2VKmeEmM6JFGkYjs/UBG/OnY9dkucIuaZnQImsUPqiXH00duP0m0gYia /cMQ== X-Gm-Message-State: AIkVDXIPH816akZhPjK5pw8xGdXsJxMye7xIx99wlPyxGazJGdc/+ruuPF4BchI/SPgNcLk9nTDV/s2nLELM93bx X-Received: by 10.107.2.8 with SMTP id 8mr13932973ioc.83.1482155040513; Mon, 19 Dec 2016 05:44:00 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.198.67 with HTTP; Mon, 19 Dec 2016 05:44:00 -0800 (PST) In-Reply-To: <1482132023-10416-9-git-send-email-dandan.bi@intel.com> References: <1482132023-10416-1-git-send-email-dandan.bi@intel.com> <1482132023-10416-9-git-send-email-dandan.bi@intel.com> From: Ard Biesheuvel Date: Mon, 19 Dec 2016 13:44:00 +0000 Message-ID: To: Dandan Bi Cc: "edk2-devel@lists.01.org" , Ruiyu Ni Subject: Re: [patch 8/8] MdeModulePkg/NonDiscoverableDeviceRegistrationLib: Fix coding style issues X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 19 Dec 2016 13:44:01 -0000 Content-Type: text/plain; charset=UTF-8 On 19 December 2016 at 07:20, Dandan Bi wrote: > 1. Fix issues comments > 2. Fix Guid/protocol format > > Cc: Ard Biesheuvel > Cc: Ruiyu Ni > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi Reviewed-by: Ard Biesheuvel > --- > .../Library/NonDiscoverableDeviceRegistrationLib.h | 4 +++- > .../NonDiscoverableDeviceRegistrationLib.c | 14 ++++++++++++-- > .../NonDiscoverableDeviceRegistrationLib.inf | 22 ++++++++++++---------- > 3 files changed, 27 insertions(+), 13 deletions(-) > > diff --git a/MdeModulePkg/Include/Library/NonDiscoverableDeviceRegistrationLib.h b/MdeModulePkg/Include/Library/NonDiscoverableDeviceRegistrationLib.h > index 120d914..c2d9e48 100644 > --- a/MdeModulePkg/Include/Library/NonDiscoverableDeviceRegistrationLib.h > +++ b/MdeModulePkg/Include/Library/NonDiscoverableDeviceRegistrationLib.h > @@ -30,21 +30,23 @@ typedef enum { > } NON_DISCOVERABLE_DEVICE_TYPE; > > /** > Register a non-discoverable MMIO device > > - @param[in] DeviceType The type of non-discoverable device > + @param[in] Type The type of non-discoverable device > @param[in] DmaType Whether the device is DMA coherent > @param[in] InitFunc Initialization routine to be invoked when > the device is enabled > @param[in,out] Handle The handle onto which to install the > non-discoverable device protocol. > If Handle is NULL or *Handle is NULL, a > new handle will be allocated. > @param[in] NumMmioResources The number of UINTN base/size pairs that > follow, each describing an MMIO region > owned by the device > + @param[in] ... The variable argument list which contains the > + info about MmioResources. > > @retval EFI_SUCCESS The registration succeeded. > @retval Other The registration failed. > > **/ > diff --git a/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.c b/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.c > index 94cd946..6f46dfa 100644 > --- a/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.c > +++ b/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.c > @@ -23,10 +23,18 @@ > #include > > #include > #include > > +/** > + Get Guid form the type of non-discoverable device. > + > + @param[in] Type The type of non-discoverable device. > + > + @retval Return the Guid. > + > +**/ > STATIC > CONST EFI_GUID * > GetGuidFromType ( > IN NON_DISCOVERABLE_DEVICE_TYPE Type > ) > @@ -72,23 +80,25 @@ typedef struct { > EFI_DEVICE_PATH_PROTOCOL End; > } NON_DISCOVERABLE_DEVICE_PATH; > #pragma pack () > > /** > - Register a non-discoverable MMIO device > + Register a non-discoverable MMIO device. > > - @param[in] DeviceType The type of non-discoverable device > + @param[in] Type The type of non-discoverable device > @param[in] DmaType Whether the device is DMA coherent > @param[in] InitFunc Initialization routine to be invoked when > the device is enabled > @param[in,out] Handle The handle onto which to install the > non-discoverable device protocol. > If Handle is NULL or *Handle is NULL, a > new handle will be allocated. > @param[in] NumMmioResources The number of UINTN base/size pairs that > follow, each describing an MMIO region > owned by the device > + @param[in] ... The variable argument list which contains the > + info about MmioResources. > > @retval EFI_SUCCESS The registration succeeded. > @retval EFI_INVALID_PARAMETER An invalid argument was given > @retval Other The registration failed. > > diff --git a/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf b/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > index ba32324..dfcf8dc 100644 > --- a/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > +++ b/MdeModulePkg/Library/NonDiscoverableDeviceRegistrationLib/NonDiscoverableDeviceRegistrationLib.inf > @@ -1,6 +1,8 @@ > # @file > +# Component Description File for NonDiscoverableDeviceRegistrationLib. > +# > # Copyright (c) 2016, Linaro, Ltd. All rights reserved.
> # > # This program and the accompanying materials > # are licensed and made available under the terms and conditions of the BSD License > # which accompanies this distribution. The full text of the license may be found at > @@ -30,17 +32,17 @@ [LibraryClasses] > DebugLib > DevicePathLib > UefiBootServicesTableLib > > [Protocols] > - gEdkiiNonDiscoverableDeviceProtocolGuid > + gEdkiiNonDiscoverableDeviceProtocolGuid ## PRODUCES > > [Guids] > - gEdkiiNonDiscoverableAhciDeviceGuid > - gEdkiiNonDiscoverableAmbaDeviceGuid > - gEdkiiNonDiscoverableEhciDeviceGuid > - gEdkiiNonDiscoverableNvmeDeviceGuid > - gEdkiiNonDiscoverableOhciDeviceGuid > - gEdkiiNonDiscoverableSdhciDeviceGuid > - gEdkiiNonDiscoverableUfsDeviceGuid > - gEdkiiNonDiscoverableUhciDeviceGuid > - gEdkiiNonDiscoverableXhciDeviceGuid > + gEdkiiNonDiscoverableAhciDeviceGuid ## CONSUMES ## GUID > + gEdkiiNonDiscoverableAmbaDeviceGuid ## CONSUMES ## GUID > + gEdkiiNonDiscoverableEhciDeviceGuid ## CONSUMES ## GUID > + gEdkiiNonDiscoverableNvmeDeviceGuid ## CONSUMES ## GUID > + gEdkiiNonDiscoverableOhciDeviceGuid ## CONSUMES ## GUID > + gEdkiiNonDiscoverableSdhciDeviceGuid ## CONSUMES ## GUID > + gEdkiiNonDiscoverableUfsDeviceGuid ## CONSUMES ## GUID > + gEdkiiNonDiscoverableUhciDeviceGuid ## CONSUMES ## GUID > + gEdkiiNonDiscoverableXhciDeviceGuid ## CONSUMES ## GUID > -- > 1.9.5.msysgit.1 >