Re: [PATCH edk2-platforms v2 00/18] ARM: Update GOP

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 22 December 2017 at 19:08,  <evan.lloyd@arm.com> wrote:
> From: EvanLloyd <evan.lloyd@arm.com>
>

Hello Evan,

Before reviewing in detail, could you please confirm that replying to
the addresses below is going to work as expected for non @arm.com
reviewers? They look a bit odd, but perhaps the arm.com SMTP server
doesn't care??

Cc: Arvind Chauhan <Arvind.Chauhan@arm.com>, Daniil Egranov
<Daniil.Egranov@arm.com>, Thomas Panakamattam Abraham
<thomas.abraham@arm.com>, "ard.biesheuvel@linaro.org"@arm.com,
"leif.lindholm@linaro.org"@arm.com, "Matteo.Carlini@arm.com"@arm.com,
"nd@arm.com"@arm.com

-- 
Ard.


> This patch series addresses comments on the original
> (https://lists.01.org/pipermail/edk2-devel/2017-September/015356.html)
> reworking of the Graphics Output Protocol code in Platform/ARM.
> It also contains updates for the new SCMI protocol (MTL Library).
>
> After a number of format and quality modifications, several errors
> are corrected and new functionality added for Mali DP.
>
> The changes are tested on Juno, and FVP.
>
> Code is available for examination at:
>   https://github.com/EvanLloyd/edk2-platforms/tree/166_gop_v2
>
> Ard Biesheuvel (1):
>   ARM/VExpressPkg: Fix MODULE_TYPE of HDLCD/PL111 platform libraries
>
> EvanLloyd (1):
>   ARM/VExpressPkg: HdLcdArmVExpressLib: Remove redundant Bpp
>
> Girish Pathak (16):
>   ARM/VExpressPkg: Tidy HDLCD and PL11LCD platform Lib: Coding standard
>   ARM/VExpressPkg: Tidy HdLcd/PL111Lcd code: Updated comments
>   ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf
>   ARM/VExpressPkg: PL111 and HDLCD: add const qualifier
>   ARM/VExpressPkg: Add and update debug ASSERTS
>   ARM/VExpressPkg: PL111LcdArmVExpressLib: Minor code cleanup
>   ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32
>   ARM/VExpressPkg: PL11LcdArmVExpressLib: Improvement conditional
>   ARM/VExpressPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT
>   ARM/VExpressPkg: Redefine LcdPlatformGetTimings function
>   ARM/VExpressPkg: PL111 and HDLCD: Add PCD to select pixel format
>   ARM/VExpressPkg: Reserving framebuffer at build
>   ARM/VExpressPkg: New DP500/DP550/DP650 platform library.
>   ARM/JunoPkg: Mapping Non-Trused SRAM as device memory
>   ARM/JunoPkg: Adding SCMI MTL library
>   ARM/JunoPkg: Add HDLCD platform library
>
>  Platform/ARM/JunoPkg/ArmJuno.dec                                                   |  17 +-
>  Platform/ARM/VExpressPkg/ArmVExpressPkg.dec                                        |   3 +-
>  Platform/ARM/JunoPkg/ArmJuno.dsc                                                   |  32 ++
>  Platform/ARM/JunoPkg/ArmJuno.fdf                                                   |  12 +-
>  Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf                             |   5 +-
>  Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtl.inf                                     |  39 ++
>  Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJunoLib.inf                   |  40 ++
>  Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.inf                     |  45 ++
>  Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf             |   7 +-
>  Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf       |  13 +-
>  Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf |   9 +-
>  Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtlPrivate.h                                |  94 ++++
>  Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c                               |  24 +-
>  Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtl.c                                       | 195 +++++++
>  Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c                        | 559 ++++++++++++++++++++
>  Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.c                       | 374 +++++++++++++
>  Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c                      |  28 +-
>  Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c            | 309 +++++++----
>  Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c      | 425 +++++++++------
>  19 files changed, 1920 insertions(+), 310 deletions(-)
>  create mode 100644 Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtl.inf
>  create mode 100644 Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJunoLib.inf
>  create mode 100644 Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.inf
>  create mode 100644 Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtlPrivate.h
>  create mode 100644 Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtl.c
>  create mode 100644 Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c
>  create mode 100644 Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.c
>
> --
> Guid("CE165669-3EF3-493F-B85D-6190EE5B9759")
>