From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=2607:f8b0:4001:c0b::229; helo=mail-it0-x229.google.com; envelope-from=ard.biesheuvel@linaro.org; receiver=edk2-devel@lists.01.org Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0E3C5222F4E04 for ; Fri, 22 Dec 2017 11:24:54 -0800 (PST) Received: by mail-it0-x229.google.com with SMTP id u62so15391094ita.2 for ; Fri, 22 Dec 2017 11:29:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=t/bLsKSsjKY+/PW8f55x29acg/Z2wrIbXZY1cYGtEhQ=; b=M18Ky1jCgADz24hS3InM9kKkZ6BURn2i9lc1VrCHf90XxMTYFudbTeW75NhbZIu/6g c64fUu7jaAGg+FnRU0XUNRzAqgHWR131S7OwB8fBRmm74/RTqmRrH9DhLmGdB+/UBEsp ErELJ0IbzUil4fWO0/AO54dhvnKyVFy5cdl1w= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=t/bLsKSsjKY+/PW8f55x29acg/Z2wrIbXZY1cYGtEhQ=; b=GHvdrCWOU2Bg5ZqxDqvFQc+LzJ+dWjuN7lakeV99bKrDi2XWRZBCmOwKTf3+eF604d urbdr0pq1OLFbUUa24mtOFAKyFX/IdOV1+WRBTW/xu/MssUDdO901PICOk9nBKnr0tm3 meiQ6950sxpYHhp8AMoEeo0nnYmyXeyTCqjsLtHu40/VCGJPmP5NX9pJfD6XKmt7+Lh9 kZ4k3tvsAmCmq7CJ5aEVvEk6KQl/117eRYBa/b+8t24CFWQQcHmtuSdrgElAJimBqoO8 szFA09aFBCr5ltkhoIbcPskk9mtIb2oNjviFxq49CCmCmfPKnxNNGrBf8TZT+yVgyPyf BF+A== X-Gm-Message-State: AKGB3mIntsK4M0HD30OzJt1zZFYRAxXr2eNvUrkaapp/pIjaLhx4BeT7 RrPhls5qeHphI0uMU1zG5W5DkevF0S9UuTyBQJLubQ== X-Google-Smtp-Source: ACJfBoucSOo6v+z6XZNYk3HMVaCb6OK3fWtZ/OA+yplJtFcM6Z2lX0qPSqmbCt//RD+Y6M9yz9HFJ3Hmn8htGDvg5WY= X-Received: by 10.36.145.216 with SMTP id i207mr19304982ite.73.1513970984287; Fri, 22 Dec 2017 11:29:44 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.52.14 with HTTP; Fri, 22 Dec 2017 11:29:43 -0800 (PST) In-Reply-To: <20171222190821.12440-1-evan.lloyd@arm.com> References: <20171222190821.12440-1-evan.lloyd@arm.com> From: Ard Biesheuvel Date: Fri, 22 Dec 2017 19:29:43 +0000 Message-ID: To: Evan Lloyd , Leif Lindholm , Ard Biesheuvel , Matteo Carlini Cc: "edk2-devel@lists.01.org" , Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham Subject: Re: [PATCH edk2-platforms v2 00/18] ARM: Update GOP X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 22 Dec 2017 19:24:55 -0000 Content-Type: text/plain; charset="UTF-8" On 22 December 2017 at 19:08, wrote: > From: EvanLloyd > Hello Evan, Before reviewing in detail, could you please confirm that replying to the addresses below is going to work as expected for non @arm.com reviewers? They look a bit odd, but perhaps the arm.com SMTP server doesn't care?? Cc: Arvind Chauhan , Daniil Egranov , Thomas Panakamattam Abraham , "ard.biesheuvel@linaro.org"@arm.com, "leif.lindholm@linaro.org"@arm.com, "Matteo.Carlini@arm.com"@arm.com, "nd@arm.com"@arm.com -- Ard. > This patch series addresses comments on the original > (https://lists.01.org/pipermail/edk2-devel/2017-September/015356.html) > reworking of the Graphics Output Protocol code in Platform/ARM. > It also contains updates for the new SCMI protocol (MTL Library). > > After a number of format and quality modifications, several errors > are corrected and new functionality added for Mali DP. > > The changes are tested on Juno, and FVP. > > Code is available for examination at: > https://github.com/EvanLloyd/edk2-platforms/tree/166_gop_v2 > > Ard Biesheuvel (1): > ARM/VExpressPkg: Fix MODULE_TYPE of HDLCD/PL111 platform libraries > > EvanLloyd (1): > ARM/VExpressPkg: HdLcdArmVExpressLib: Remove redundant Bpp > > Girish Pathak (16): > ARM/VExpressPkg: Tidy HDLCD and PL11LCD platform Lib: Coding standard > ARM/VExpressPkg: Tidy HdLcd/PL111Lcd code: Updated comments > ARM/VExpressPkg: Remove unused PcdPL111LcdMaxMode from HDLCD inf > ARM/VExpressPkg: PL111 and HDLCD: add const qualifier > ARM/VExpressPkg: Add and update debug ASSERTS > ARM/VExpressPkg: PL111LcdArmVExpressLib: Minor code cleanup > ARM/VExpressPkg: PL111 and HDLCD: Use FixedPcdGet32 > ARM/VExpressPkg: PL11LcdArmVExpressLib: Improvement conditional > ARM/VExpressPkg: HdLcdArmVExpressLib: Remove status check EFI_TIMEOUT > ARM/VExpressPkg: Redefine LcdPlatformGetTimings function > ARM/VExpressPkg: PL111 and HDLCD: Add PCD to select pixel format > ARM/VExpressPkg: Reserving framebuffer at build > ARM/VExpressPkg: New DP500/DP550/DP650 platform library. > ARM/JunoPkg: Mapping Non-Trused SRAM as device memory > ARM/JunoPkg: Adding SCMI MTL library > ARM/JunoPkg: Add HDLCD platform library > > Platform/ARM/JunoPkg/ArmJuno.dec | 17 +- > Platform/ARM/VExpressPkg/ArmVExpressPkg.dec | 3 +- > Platform/ARM/JunoPkg/ArmJuno.dsc | 32 ++ > Platform/ARM/JunoPkg/ArmJuno.fdf | 12 +- > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoLib.inf | 5 +- > Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtl.inf | 39 ++ > Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJunoLib.inf | 40 ++ > Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.inf | 45 ++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/ArmVExpressLib.inf | 7 +- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpressLib.inf | 13 +- > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpressLib.inf | 9 +- > Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtlPrivate.h | 94 ++++ > Platform/ARM/JunoPkg/Library/ArmJunoLib/ArmJunoMem.c | 24 +- > Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtl.c | 195 +++++++ > Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c | 559 ++++++++++++++++++++ > Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.c | 374 +++++++++++++ > Platform/ARM/VExpressPkg/Library/ArmVExpressLibRTSM/RTSMMem.c | 28 +- > Platform/ARM/VExpressPkg/Library/HdLcdArmVExpressLib/HdLcdArmVExpress.c | 309 +++++++---- > Platform/ARM/VExpressPkg/Library/PL111LcdArmVExpressLib/PL111LcdArmVExpress.c | 425 +++++++++------ > 19 files changed, 1920 insertions(+), 310 deletions(-) > create mode 100644 Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtl.inf > create mode 100644 Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJunoLib.inf > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.inf > create mode 100644 Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtlPrivate.h > create mode 100644 Platform/ARM/JunoPkg/Library/ArmMtl/ArmMtl.c > create mode 100644 Platform/ARM/JunoPkg/Library/HdLcdArmJunoLib/HdLcdArmJuno.c > create mode 100644 Platform/ARM/VExpressPkg/Library/ArmMaliDpLib/ArmMaliDpLib.c > > -- > Guid("CE165669-3EF3-493F-B85D-6190EE5B9759") >