Re: [PATCH V2 3/3] ArmVirtPkg DxeHobLib: Update func header description of BuildFv(2)Hob()

[Ard Biesheuvel <ard.biesheuvel@linaro.org>]

On 16 November 2016 at 02:17, Star Zeng <star.zeng@intel.com> wrote:
> Update the function header description of BuildFv(2)Hob() to match
> with HobLib.h in MdePkg.
>
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=205
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>

Reviewed-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>

> ---
>  ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
> index 81196b207d1e..9e617b8e6991 100644
> --- a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
> +++ b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c
> @@ -1,7 +1,7 @@
>  /** @file
>    HOB Library implemenation for Dxe Phase with DebugLib dependency removed
>
> -Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
>  Copyright (c) 2014, Linaro Ltd. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD License
> @@ -395,6 +395,7 @@ BuildGuidDataHob (
>    for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
>
>    If there is no additional space for HOB creation, then ASSERT().
> +  If the FvImage buffer is not at its required alignment, then ASSERT().
>
>    @param  BaseAddress   The base address of the Firmware Volume.
>    @param  Length        The size of the Firmware Volume in bytes.
> @@ -421,6 +422,7 @@ BuildFvHob (
>    for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase.
>
>    If there is no additional space for HOB creation, then ASSERT().
> +  If the FvImage buffer is not at its required alignment, then ASSERT().
>
>    @param  BaseAddress   The base address of the Firmware Volume.
>    @param  Length        The size of the Firmware Volume in bytes.
> --
> 2.7.0.windows.1
>