From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-it0-x229.google.com (mail-it0-x229.google.com [IPv6:2607:f8b0:4001:c0b::229]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D876881EF3 for ; Wed, 16 Nov 2016 03:26:48 -0800 (PST) Received: by mail-it0-x229.google.com with SMTP id b123so47978059itb.0 for ; Wed, 16 Nov 2016 03:26:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=yW5CvJlsP4Mi4edi5hnof3dbbUlktmTUlSAW55V5sro=; b=PnR2MzJo3xvmawlc060PqifTmphuSA6ZsMxqitNkRw/8sfKESMlQ+cEcFYhvbxzGW/ NxsECWcJWQ8AECYmMSEltOUmkkbP+0DZMYiH9d+avQ12NF675ecy04se0wH2QPd52DrK nHw4qqE2u8/2ExgGfJua1CXW9zA/1vDz3YCp4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=yW5CvJlsP4Mi4edi5hnof3dbbUlktmTUlSAW55V5sro=; b=B5VlyF1cZ9whN3lV/J0Q4TomL7Gw+NkgIYQUWoX2/zb2DgLMuq3/lW+Bd+m/uSb7/V EIflq28Qzx9MoSrIfEmVhO+WbBuiNMQPDo/MLT/AkRSgrCpqEhnfVf+Oli5A4UWYPAgM qggkpJYRE1SEl84CaENFuISj+sSCqtCRM9Y/wk32qsKnAvlLVQd8+QP4JdfL/6DEMQ1W OgfrzyZkDWryTSsB1JSswqBNsCIdUuQ6tid57EyepG5WWNk2hb3K/RA0sEI0KhT0oZyx fKrCDQTuBBiQdrzoEmlmmj//K2Eu80xV0+E45e57OR0xclD37DiYF0a691K7aytIIc9v mMbg== X-Gm-Message-State: ABUngvcEmf0UzqI30iLjG7D3KJ/Q7TrHi2VrNkj4lc3DOoFOQJLDZFgo1cA0U8Rn22yelit8hByJaI07gVpv/PcE X-Received: by 10.36.14.131 with SMTP id 125mr7111330ite.59.1479295613181; Wed, 16 Nov 2016 03:26:53 -0800 (PST) MIME-Version: 1.0 Received: by 10.107.59.147 with HTTP; Wed, 16 Nov 2016 03:26:52 -0800 (PST) In-Reply-To: <1479262660-54096-4-git-send-email-star.zeng@intel.com> References: <1479262660-54096-1-git-send-email-star.zeng@intel.com> <1479262660-54096-4-git-send-email-star.zeng@intel.com> From: Ard Biesheuvel Date: Wed, 16 Nov 2016 11:26:52 +0000 Message-ID: To: Star Zeng Cc: edk2-devel-01 , Jiewen Yao , Liming Gao , Michael D Kinney , Laszlo Ersek Subject: Re: [PATCH V2 3/3] ArmVirtPkg DxeHobLib: Update func header description of BuildFv(2)Hob() X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2016 11:26:49 -0000 Content-Type: text/plain; charset=UTF-8 On 16 November 2016 at 02:17, Star Zeng wrote: > Update the function header description of BuildFv(2)Hob() to match > with HobLib.h in MdePkg. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=205 > > Cc: Jiewen Yao > Cc: Liming Gao > Cc: Michael D Kinney > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Star Zeng Reviewed-by: Ard Biesheuvel > --- > ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c > index 81196b207d1e..9e617b8e6991 100644 > --- a/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c > +++ b/ArmVirtPkg/Library/ArmVirtDxeHobLib/HobLib.c > @@ -1,7 +1,7 @@ > /** @file > HOB Library implemenation for Dxe Phase with DebugLib dependency removed > > -Copyright (c) 2006 - 2012, Intel Corporation. All rights reserved.
> +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> Copyright (c) 2014, Linaro Ltd. All rights reserved.
> This program and the accompanying materials > are licensed and made available under the terms and conditions of the BSD License > @@ -395,6 +395,7 @@ BuildGuidDataHob ( > for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase. > > If there is no additional space for HOB creation, then ASSERT(). > + If the FvImage buffer is not at its required alignment, then ASSERT(). > > @param BaseAddress The base address of the Firmware Volume. > @param Length The size of the Firmware Volume in bytes. > @@ -421,6 +422,7 @@ BuildFvHob ( > for DXE phase, it will ASSERT() since PEI HOB is read-only for DXE phase. > > If there is no additional space for HOB creation, then ASSERT(). > + If the FvImage buffer is not at its required alignment, then ASSERT(). > > @param BaseAddress The base address of the Firmware Volume. > @param Length The size of the Firmware Volume in bytes. > -- > 2.7.0.windows.1 >